Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <9bd9c89a-b2fb-04dd-0aac-c42f2ee9e1a1@oracle.com>
Date:   Wed, 20 Apr 2022 16:30:02 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v8 1/4] mm: hugetlb_vmemmap: introduce
 CONFIG_HUGETLB_PAGE_HAS_OPTIMIZE_VMEMMAP
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>,
        Muchun Song <songmuchun@bytedance.com>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Oscar Salvador <osalvador@suse.de>,
        David Hildenbrand <david@redhat.com>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        duanxiongchun@bytedance.com, smuchun@gmail.com
References: <20220413144748.84106-1-songmuchun@bytedance.com>
 <20220413144748.84106-2-songmuchun@bytedance.com>
 <CAK7LNARNyYNMMYcEwU-pVFb-b21cKN+K_jwseLTtoOfscS2Ggw@mail.gmail.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <CAK7LNARNyYNMMYcEwU-pVFb-b21cKN+K_jwseLTtoOfscS2Ggw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXJXUENNTjJXT1I0akhvZUNaZ3ZRQXNPVThOVUl0QjJlQlJ0SlVKU1ZQSXJy?=
 =?utf-8?B?Vm5LL01CTWIvTkRaTUkzaVpOQzZxcGxDVXpkWDI1Tml3S3ppU2VYQ3J2ajRt?=
 =?utf-8?B?d0tNOEN4d3luRFEwUDlNbkVrUDArekhVQUtGYmVzSEcyaEIvUXptdTRoRVZ2?=
 =?utf-8?B?YVExc0llaG16bVlhc1pRVzJoMVc0QWowZkZ6dytEblYycGZNNFdMR1FPQnJL?=
 =?utf-8?B?MEowZmpCNkhqaFZJYVFCZ0tSOXBpWCs5ekNOQnozdzFCekV3ZkUrOWlleHk2?=
 =?utf-8?B?cGhjV3p0TU01NkVLRTlRY05mRzhSQnlpSG81ZHh3RW85eG9abGZNMVF2VitN?=
 =?utf-8?B?U1l1MWdNaUpIUE92bXlKOGxyVk1mRW4zaE85UGZmVHdETXJzcFdqZnV4dTY1?=
 =?utf-8?B?SnlrSFhteTlIcUFBbGpyTk50MlpjMTc1WUZqaTNUdnFWdjRNbFErQmtDd1Rj?=
 =?utf-8?B?YXRqeVFlV1NJT2lKcDNnOGxGWlJRdUJuTW5YYTVobExkK096WW5ocXBLSjBk?=
 =?utf-8?B?cnkrR2RZd21LUmlPOTBPRzFMdFRUMWNSMGxxU3paOVhuTzY0SlYxZEJYWVds?=
 =?utf-8?B?WHZKQzQwcXVRZVZOdWtYcG1tMDFDMmVKLzdmdHhKT2RLNWNvMTZDSFF6L0pE?=
 =?utf-8?B?L2hOY25zNWh0ZlJXdnB2eVg4bkQxd2Y5YytHUzZlditDOTdMelhrWGpnck5h?=
 =?utf-8?B?d0N0dHRwTTBIS0hRbnY2bXNmZHc2WEh6dUdXUHlGVFRpNXhjdUZNTGw3UXhQ?=
 =?utf-8?B?UStsdUVBSnBCWHhUejV0b09WNGkvZElZSG1hUWtPKzcwYSt5RTJXbEpENVg4?=
 =?utf-8?B?c2N0M0NmWlpYb3V4eE81aVhPbzRCMGJpNVd3ZWRacS9nYkVYOG1PeE1ncjZF?=
 =?utf-8?B?TFBXdEFWMGw4SmF5LzY0dDREN01FdzBSa2JmQVBNcmRmeXRUakgwa3N3bTlI?=
 =?utf-8?B?cytvb1NVUzV1T0xlTExVNlB1Z1B4aWJBSnZYSDNUSTcxbWI4UFY1ZWVXS0pi?=
 =?utf-8?B?TW9rRUNlZ2x2NSt2T2o3UVoxWk50M2pTSGdSSWhkL1Z5VHZFTUpQcURsMFJN?=
 =?utf-8?B?ZVJrWGxDYXBMZnk0Y1JWc0hqb0VsV1Y2bWlVblp2WURNaGR6K0RyWU9jU2sz?=
 =?utf-8?B?ZHQySjBwZHBZdmV6N29yK250RWh2ZHIwQWNOOWw3VGZpN1BhR1VvQXpRTHZB?=
 =?utf-8?B?L1k4WWxTT2xxTkFWVURwa1c5bXdmckFVQXNkZW5DSDlLNnU2VnlXenArT3Fq?=
 =?utf-8?B?WHA0VEhYTFFnKzBaWHppUWJscWMwMUVWNGVPeEQxaHFvdjdGTSs0Y2NOeGdV?=
 =?utf-8?B?czhuRGRkKzRqc0srNVRUd1dkT2JuczY1WVpSZ1poajdoS3doNTVDWEJNRjVD?=
 =?utf-8?B?VTNwZGJzRURrWHZBaUpSWlpvakY4RUxCQXp1eHRYbWJwTHNEZ1RuRG5MNHpS?=
 =?utf-8?B?bjJTRXBVbVRRellqR0RsYndUSmVYTCtkYWRHbWJMc3AyZzZWMjl1YUFpY1pz?=
 =?utf-8?B?ZmptRmJEeWpINFN6TEhDRHhpY0J0a0I4YUQxeERKUnFQODgrOW9nNXZTUmJv?=
 =?utf-8?B?OUVFWXhkTGY4eWd0MGRZTndQTnpUSzU5V0Z4VzFXWnZYUVlQMWFEbHh2V3Nr?=
 =?utf-8?B?R0ZYRUJiN3VIeWZkZVF6MGxHRzlSYnJ1OE40ODNnVnlzamhhUHZxRXJTTnp6?=
 =?utf-8?B?WW1DcEFyVHMxUk1VU2xObTlZWnQzbkRCMTZ3U2xQZnVNUkdWRTVGSm1TcktT?=
 =?utf-8?B?bDdYTTExcVhubmM5Yit4OHBtZUVEaDNaMldlSDE3UHJoWGRHSlgybmRwMWFI?=
 =?utf-8?B?bSt4dkJvRHAwSjhBa01OdWNYVWxVOEY3UzlXek85bjlXT241YTA5MHhad0t0?=
 =?utf-8?B?UURJdEhCeThMWmdQMUtNcXJkVDBNSFByN3U5aG9Fc0cvVzNJUERDcjAybDhQ?=
 =?utf-8?B?R09FOHplS1RIZlV2VzhwYmcrMVVrMTc2dE13eDJHbm9NOTFSa3RkZEF6bm50?=
 =?utf-8?B?V2h4L0tqY3hoSEJBSkhrd0V6U2pDKzJZRjFSSFB4d1l0bDZ5c29OUTVuYkQv?=
 =?utf-8?B?Y2VkeXVaNTRnVnNqL0RVam5oa3lpUkFXUDdCeDRxVmxUR0RWM29YdWlhMW1j?=
 =?utf-8?B?Z1BSU2tONENTR1Y3MVN2UEM1bVA0QytudVRMRmg5TmppRVRaTE9iODFicEQv?=
 =?utf-8?B?NU9MQ1liSG5sbHhEMHUrNzNZdXNWc08zcGhFTTVGNjJubkpsMHVDZE1UZEZU?=
 =?utf-8?B?UzdZWEdROTVPWGFiTWhPMW44U01ydmppQUtJaUhNZEhnUkU0WE8vQnNmRXdY?=
 =?utf-8?B?SGwvVUROS3Vkc05ienRzemo4RnBLaUowVDd4OE1DTVdLVWhWL0FwNjZ5WWtI?=
 =?utf-8?Q?xm1yMFEhOxQwH/1U=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85b4d73c-ed0c-4344-9f88-08da2325b2c9
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 23:30:04.8490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oKXA3R7oQzwkmLt4evzjI1XLPZ1mFP6inzweSW88/nmDGG/jA7CXkEUs1gpx25509o76vKiaJshViNjlbD8Tog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5740
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-20_06:2022-04-20,2022-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204200133
X-Proofpoint-GUID: rfKq2R9KS4rPeLk2S7eH_7Sr6ux_kjLo
X-Proofpoint-ORIG-GUID: rfKq2R9KS4rPeLk2S7eH_7Sr6ux_kjLo
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/20/22 10:11, Masahiro Yamada wrote:
> On Wed, Apr 13, 2022 at 11:48 PM Muchun Song <songmuchun@bytedance.com> wrote:
>>
>> If the size of "struct page" is not the power of two but with the feature
>> of minimizing overhead of struct page associated with each HugeTLB is
>> enabled, then the vmemmap pages of HugeTLB will be corrupted after
>> remapping (panic is about to happen in theory).  But this only exists when
>> !CONFIG_MEMCG && !CONFIG_SLUB on x86_64.  However, it is not a conventional
>> configuration nowadays.  So it is not a real word issue, just the result
>> of a code review.  But we have to prevent anyone from configuring that
>> combined configurations.  In order to avoid many checks like "is_power_of_2
>> (sizeof(struct page))" through mm/hugetlb_vmemmap.c.  Introduce a new macro

Sorry for jumping in so late.  I am far from expert in Kconfig so did not pay
much attention to all those discussions.

Why not just add one (or a few) simple runtime checks for struct page not a
power of two before enabling hugetlb vmemmap optimization in the code?  Sure,
it would be ideal to never build/include the vmemmap optimization code if
this can be detected at config time.  However, it seems this is a very rare
combination and the checks for it at config time are very complex.

Would we really need many checks throughout the code as you mention above?
Or, do we only need to check or two before enabling
hugetlb_optimize_vmemmap_key?
-- 
Mike Kravetz