Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 16:33:15 +0200
Message-ID: <s5hy1zxrxw4.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Thorsten Leemhuis <regressions@leemhuis.info>
Cc:     Takashi Iwai <tiwai@suse.de>,
        Shreeya Patel <shreeya.patel@collabora.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        regressions@lists.linux.dev,
        Mario Limonciello <mario.limonciello@amd.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [REGRESSION] Missing IRQ via amd_gpio
In-Reply-To: <e4c9bb60-210d-243a-e225-6b3546c0b42b@leemhuis.info>
References: <s5ha6cdtglj.wl-tiwai@suse.de>
        <e4c9bb60-210d-243a-e225-6b3546c0b42b@leemhuis.info>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 22 Apr 2022 16:17:36 +0200,
Thorsten Leemhuis wrote:
> 
> Hi Takashi! Thx for CCing the regression list.
> 
> On 22.04.22 15:03, Takashi Iwai wrote:
> > Hi,
> > 
> > we received a bug report for 5.17.3 kernel showing a new error:
> > 
> >  amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
> > 
> > Not only an error message but in practice this leads to a missing IRQ
> > assignment; the IRQ 27 is no longer assigned to amd_gpio driver.
> > 
> > As the error number (EPROBE_DEFER) indicates, this seems to be the
> > side-effect of the recent fix, the upstream commit 5467801f1fcb
> > ("gpio: Restrict usage of GPIO chip irq members before
> > initialization").  As far as I understand, the problem is in
> > acpi_gpiochip_request_interrupts() call that is called from
> > gpiochip_add_irqchip() itself.  Since it's called before the
> > initialized flag set, it always fails now.
> > 
> > Below is a temporary quick fix and it seems working.  But I'm not sure
> > whether I overlooked something obvious...
> 
> A patch that afaics will fix this hopefully should get merged really
> soon now:
> 
> https://lore.kernel.org/all/20220422131452.20757-1-mario.limonciello@amd.com/
> 
> See also v1:
> 
> https://lore.kernel.org/all/20220414025705.598-1-mario.limonciello@amd.com/

Thanks, good to know that we reached to the very same fix :)

So, feel free to take my tags to Mario's patch, if any:

Reviewed-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Takashi Iwai <tiwai@suse.de>


Takashi