Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp894630pxb; Fri, 22 Apr 2022 13:39:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCXy1+t/ngWzBQI+i+sNp5GBfmw3AnHfHJCUBGBbo4XFHKzz7iejeJcPVpL52GTTFRShen X-Received: by 2002:a17:90a:c302:b0:1bd:14ff:15 with SMTP id g2-20020a17090ac30200b001bd14ff0015mr18114936pjt.19.1650659982313; Fri, 22 Apr 2022 13:39:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650659982; cv=none; d=google.com; s=arc-20160816; b=YUaliLKAFSCBtybI7pswA4Y6Ykw/TiWBnZcTyt0tr/S4L9nesdK6+P2j+cyaWwOZfG s6wfRsqHBGZobHCOySWqTGBMh37riI2s7UDxgQ26feUnck2eV7/SHMycLDWyURVk7w66 uEupHohGsHtwaMqWM5R2oF7nI5u+pTKcM39z8M+N1+5kkOo96HcOv8bt1fSbfBCtd0nx zu595DAQNFo+jCTcWWAZTTYrOChtzO4qSwnBZrR6uAK7SvgWghH+4raKZZw+ajRjgXkD nRs0cmLfPzq9SZfp7oFVvnlraOPq41e/BqWTKYh8PamSnLA3MFMkn4FfUmj8B1wGbeIX o5zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:references :in-reply-to:subject:cc:to:from:date:mime-version; bh=HWM0Kp1hsFiffrQSN8LxCtb7ijYC4AJ16tzgl0Ztjmk=; b=fpNLRr+7pEKfsyGrqI0NyHwN2vZOe+J0C/qb0y70oL99gpmnrU8+xVce+2uGtmg+S7 uQriUqxJpj5OaaMTeUWWvyRqmHIJPHJbRa1KMz3d0W1rCi0fYxA7/gwn4tPALZbTQTeL UX+OrlTPj8MD0eEM8y3u2tkA01C2D0E/0Uw8X2tkCpCXuvIrAoU0NjjvzeJLUirZyA5F phznL8G6qg7Gvu9Kp4kYBNHJehoeoFE8JaFw04XB0sghaoTW03RXwhO8iD3qoA3n2ajV xLkrSLWrAZYhhC3sfXeFFB9yEcxBwWwzlN5pRTWpDF9htT8WhRvZ1ex49qhTGkxZaXl+ g8pA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l193-20020a6391ca000000b0039da9a719e1si8710745pge.25.2022.04.22.13.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 13:39:42 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 591C9252B2; Fri, 22 Apr 2022 12:24:38 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377770AbiDTXPV (ORCPT + 99 others); Wed, 20 Apr 2022 19:15:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345452AbiDTXPT (ORCPT ); Wed, 20 Apr 2022 19:15:19 -0400 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38B9913DF0; Wed, 20 Apr 2022 16:12:31 -0700 (PDT) Received: (Authenticated sender: joao@overdrivepizza.com) by mail.gandi.net (Postfix) with ESMTPA id 1377F100003; Wed, 20 Apr 2022 23:12:26 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 20 Apr 2022 16:12:26 -0700 From: Joao Moreira To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, peterz@infradead.org, jpoimboe@redhat.com, andrew.cooper3@citrix.com, samitolvanen@google.com, mark.rutland@arm.com, hjl.tools@gmail.com, alyssa.milburn@linux.intel.com, ndesaulniers@google.com, gabriel.gomes@linux.intel.com, rick.p.edgecombe@intel.com Subject: Re: [RFC PATCH 11/11] driver/int3400_thermal: Fix prototype matching In-Reply-To: <202204201601.8291F550@keescook> References: <20220420004241.2093-1-joao@overdrivepizza.com> <20220420004241.2093-12-joao@overdrivepizza.com> <202204191946.2843CF71@keescook> <06435f0b44681588052d145a17d60316@overdrivepizza.com> <202204201601.8291F550@keescook> Message-ID: <4dd9a9a3a7fb6f9af0fa04b8d2e3d5a2@overdrivepizza.com> X-Sender: joao@overdrivepizza.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Ah-ha, thanks. I think this will fix it, but I haven't tested it: I tried that, and IIRC, there was an error or warning in the assignment that happens a bit further in the file. My bad for not having it all properly tracked.