Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp894748pxb; Fri, 22 Apr 2022 13:39:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd2QyzuHlrHcnxH/YsECxrPaqgIxARg6KXBT3dhHRxYMDEhKEO1Jk68bZ9d5t6JlM8H3WW X-Received: by 2002:a17:902:8214:b0:158:b5c2:1d02 with SMTP id x20-20020a170902821400b00158b5c21d02mr6322105pln.27.1650659991734; Fri, 22 Apr 2022 13:39:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650659991; cv=none; d=google.com; s=arc-20160816; b=lDq+g/plf/u1kN9E6lmesYIto4+B5yMY/BIVukoB2GTjbSyyE8OAX/d2SaTYUHt4HH ler9QS2TKXMWM5xG84niT9SwVhJRL3EaXRtD0pE/QYyCfr+BB7DV3uTAATCmPyl2osAL MweEzTRSgj6O2+ZbxyLAJKJyPYHgvTejyhMg+Ea9sWpN7p5MIJOyunI91OssIiF0irzG pDJs/sg8D+5ipkSjHasmoemeLV/nlKCqXKdSL9B0Et0JR7RxEONHJPJ4P1BcvNgX0JJ+ OCs14Q6PfUsouAi1dPEUhIx01dLCXp/Qdv7jXzYsQ9lGjuAt4k5EvDuPmNTG1uLWK9HU eArQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=zAr4gmtCKw+5qx3+HCVINyCrVnj2C+GTCJlBiL2CqF0=; b=o35tNNhjsxVXLWoYy/aVesb1L0VvBPKn62BdxguAwLDl9am60gXHmBRHPor2Wv9m3R 0s1z+UTioJlzpCmb9IbabFn+X1LvhwsF6PPgRdVeysIIBH2dUwtaBK81G09tMZD0ImwG dkRQqxUngWRAQjT4Xjz/1w2KM6EMVxU91AXthFaGtymwGSDcMQUGTxpCWSvT5d0KmDoQ fM6+XUIsLhZLuFLo2FVAPDH7o/tDz6I9hEzc1fBuNh2xnceyHTAT76XovHYK3t2JW8x1 joG5uvdlOzVwo5laF7lGgyilqKI3vTLcayqxhEfVM1W1J5bYODJAN0wIvP0ZzJIGDyOF oYBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id s18-20020a63e812000000b003816043f16fsi9465885pgh.868.2022.04.22.13.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 13:39:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F06F92A7DA5; Fri, 22 Apr 2022 12:24:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236352AbiDSC3O (ORCPT + 99 others); Mon, 18 Apr 2022 22:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344541AbiDSC3K (ORCPT ); Mon, 18 Apr 2022 22:29:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 826C92C130 for ; Mon, 18 Apr 2022 19:26:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 007A660A75 for ; Tue, 19 Apr 2022 02:26:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86DD1C385A1; Tue, 19 Apr 2022 02:26:27 +0000 (UTC) Date: Mon, 18 Apr 2022 22:26:25 -0400 From: Steven Rostedt To: Jeff Xie Cc: mhiramat@kernel.org, mingo@redhat.com, zanussi@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 1/4] trace: Add trace any kernel object Message-ID: <20220418222625.3e0c5ff8@rorschach.local.home> In-Reply-To: <20220418214400.2ab7f932@rorschach.local.home> References: <20220204035644.734878-1-xiehuan09@gmail.com> <20220204035644.734878-2-xiehuan09@gmail.com> <20220418214400.2ab7f932@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Apr 2022 22:14:31 -0400 Steven Rostedt wrote: > We need to consolidate the code a bit, and add helper functions to > share between them, instead of just cut and pasting and tweaking. > That's a maintenance nightmare. And I forgot that Tom started to do this and I haven't applied his patches yet. I'll start applying them now. https://lore.kernel.org/all/cover.1644010575.git.zanussi@kernel.org/ So when that is done, you can look at rebasing on top of it. Which will hopefully make the code a bit simpler. -- Steve