Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 20 Apr 2022 22:11:57 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Brian Norris <briannorris@chromium.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: core: Replace _regulator_enable_delay()
 with fsleep()
Message-ID: <YmB3HWEIv8m+BP1w@sirena.org.uk>
References: <20220418141158.1.If0fc61a894f537b052ca41572aff098cf8e7e673@changeid>
 <20220418141158.2.I31ef0014c9597d53722ab513890f839f357fdfb3@changeid>
 <YmA0vq3qkAEYGk03@sirena.org.uk>
 <YmBPyJfN7we4k78/@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="MBlKhS3PxJRqZiM8"
Content-Disposition: inline
In-Reply-To: <YmBPyJfN7we4k78/@google.com>
Precedence: bulk


--MBlKhS3PxJRqZiM8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 20, 2022 at 11:24:08AM -0700, Brian Norris wrote:
> On Wed, Apr 20, 2022 at 05:28:46PM +0100, Mark Brown wrote:

> > Did the issue with the delay functions preferring delays on the higher
> > end of the allowed range get fixed?  That might be an issue for larger
> > usleep() values.

> Hmm, good question. I had a faint memory of this problem, and searching
> around, I couldn't find that anybody *thought* they fixed it, and I
> found evidence to the contrary (some reports complaining about, e.g.,
> boot-time performance issues in drivers/usb due to the same, with no
> indication that anybody truly fixed the problem).

That's what I feared :/

> So maybe it's better to retain the regulator core helper
> (_regulator_enable_delay()) and rename/repurpose it for my patch 1?

Sounds like a plan.

> I feel like there's some room for improvement in either fsleep() or
> usleep_range() or both, but I'm not sure exactly how to go about that
> right now.

It's really difficult to design an API that's both tasteful and clear
about intent - it's relatively easy for something like a driver that
just has a single hard coded value so you can just use usleep_range()
directly but it gets awkward once you start being generic and the code
really has no idea what the actual delay it's dealing with is.

--MBlKhS3PxJRqZiM8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJgdx0ACgkQJNaLcl1U
h9BNngf+LUIMyIBXhnQk7dsM8g3YL+uGLxUSOp7J+4ytI/gqL5rDnAYjhiZHyMIF
bGXVQLoxRfI97mNc1bkMTdfn4E+GdisohnZTeWBC2EWJsgp+hqNp4OJjvNmnG7fA
G3HWRFVuNJRFZXuNR/xV40gMbF90YzMxd5O5jEAy4ClG15+lOKYX7ufazU+TOXjt
7UA05qUreEvo/If3W8ku3s/s4Z0IBArkjNv1Ympm6BzXZvUxzL/OIxpDlK7Wu9CJ
1Uld08J7g1jVMX3lFhq2RqCJuCwwQqdhikh+npjZ+Nljtc2h8zXveuRcmbeN0TQl
iBXESTgNXEIu0yuktqT1k9pTkhnGqQ==
=5nW2
-----END PGP SIGNATURE-----

--MBlKhS3PxJRqZiM8--