Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp901754pxb; Fri, 22 Apr 2022 13:52:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ0jpU1PaHIhx03dmwhWhVA74gHSoOhU8dwPimnHNv6bC1pzzrnR0fAinYyoOBBzQgBWm/ X-Received: by 2002:a05:6a00:26cf:b0:4f6:fc52:7b6a with SMTP id p15-20020a056a0026cf00b004f6fc527b6amr6804514pfw.39.1650660725629; Fri, 22 Apr 2022 13:52:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650660725; cv=none; d=google.com; s=arc-20160816; b=FFI0TlLhBqChU3yZ/lko86Kda418UZsTB/TMn93e3kes2LxYBLuPW5bXh67+56MHoB 2TF405HM/caHtRfN0Sr0W5LFsICN5ByE7dn7pmWh6V3k7sBhU06Tnejrt48IrbgZlmx8 VIBLLwQmCZVOvLuA8wDiHBByEm0qnDDptZttP4yeQdmwParuNrsRGRe2kN/7+zsYL48C jGI2zxoH6HEZNb7EnM0/QCjYFhh+08cytAUeTfI9UUEeAFLGuFxHzPqSYnIInqFoerqW cVaq2rah59Q/dUGDDLcwJgIjG3lWP7dcuIM9ahSTEwz26KJhy6wXtZFuUctAJeFWR/Uh bIBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=4jU55ttnkGA9W+XKCmJXdLWIsz4rp3Q076zooBZ1bjY=; b=kvxxsfRTq0JBkKDY7EBnH/m29gDrb4NZl6ttf2JS0b/b9dxQyDRJEGFWNaKfDcj6uW S+1vSuoeqM8fAcNZqJrTd9scLVMD6vSwj1LhJ58prcDzrNZRw35GNwZq+D2eXfho3YcP WmBVQblm9jm0U0RimeYePvEmRHikzbyT1odOTDNAnCVUEpuRTh6vrmhy7Q+fd7LbqkNK QUnNirx+k2dgCqX7ic1BxZpb19aJo2Pat/WiiRArvTD+Rpz0473HSOVU7R+UT+wGbPiX K4iqpR5CGEaz1Ph3gMk6wmiDV0UG0QoOODPp4mhtCD59+qOn2pU51gA1ucFRnPiUD9b1 7vCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="clT3/67C"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id bf10-20020a170902b90a00b00158f8093113si8262681plb.284.2022.04.22.13.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 13:52:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="clT3/67C"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B1FFD1CA888; Fri, 22 Apr 2022 12:44:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385879AbiDUHit (ORCPT + 99 others); Thu, 21 Apr 2022 03:38:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385824AbiDUHia (ORCPT ); Thu, 21 Apr 2022 03:38:30 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E85E13D7B for ; Thu, 21 Apr 2022 00:35:41 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 19572FF80D; Thu, 21 Apr 2022 07:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650526540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4jU55ttnkGA9W+XKCmJXdLWIsz4rp3Q076zooBZ1bjY=; b=clT3/67CqxmY3hfrSvsstLcHrhFXDFRERcvVI8evEAfUsSJZ8s1NWP6+aHOtTla54sdNTQ LflefWK98THbIKM48sAok0bDep2v3FVhzddSYd7TyZ/oaFrNRjSPLx6CKMiOWhE/0fmLEJ 3xV7WrYt2b8HHT1/HF/Zhnth7qrLn0hZfEVfRGQkmahQBLOiLfWHoh+sNC+ZLFvpKc13m8 iqgrNydZ9sYUZ2dUaAYVnvnB51GDuUhvYMg5QUEmTmk98d6Lc2+g2AD0UB2LRCtH+XyUG3 2j7t7bZ4k4RDPLrsMJit86iJ0bSBCYW31eEtNuosfTpB4udW3pGOgJJk65a17g== From: Miquel Raynal To: Miaoqian Lin , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Paul Cercueil , Alexandre Belloni , Pratyush Yadav , Artem Bityutskiy , Bastian Hecht , Guennadi Liakhovetski , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mtd: rawnand: Fix return value check of wait_for_completion_timeout Date: Thu, 21 Apr 2022 09:35:37 +0200 Message-Id: <20220421073537.71822-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220412083435.29254-1-linmq006@gmail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'084c16ab423a8890121b902b405823bfec5b4365' Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-04-12 at 08:34:31 UTC, Miaoqian Lin wrote: > wait_for_completion_timeout() returns unsigned long not int. > It returns 0 if timed out, and positive if completed. > The check for <= 0 is ambiguous and should be == 0 here > indicating timeout which is the only error case. > > Fixes: 83738d87e3a0 ("mtd: sh_flctl: Add DMA capabilty") > Signed-off-by: Miaoqian Lin Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel