Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <ccb8e7f0-c038-c525-0902-47c321c19a10@intel.com>
Date:   Thu, 21 Apr 2022 13:23:53 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 2/2] igc: Trigger proper interrupts in igc_xsk_wakeup
Content-Language: en-US
To:     <jeff.evanson@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Vedang Patel <vedang.patel@intel.com>,
        Andre Guedes <andre.guedes@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jithu Joseph <jithu.joseph@intel.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
CC:     Jeff Evanson <jeff.evanson@qsc.com>
References: <20220420012635.13733-1-jeff.evanson@qsc.com>
 <20220420012635.13733-3-jeff.evanson@qsc.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20220420012635.13733-3-jeff.evanson@qsc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2RsWHFpb3ZpRFUrZVQ4dkFoZytXL3BpZUs1TFcvbnJiMkJYS1BPc2FGOUcr?=
 =?utf-8?B?UlFoakpFRXF4VjVsTEJ3dUprK1ZGdUhONDdqbmg2QVc5cU1qN21KS0lGbE94?=
 =?utf-8?B?SUVrS1hNMitPY2RmdU8yV3B6aFRqN0h6SlNhdHVQVzVwQm5GWnhCYVJVdDNt?=
 =?utf-8?B?ZnFHbnJldHgxVmN2QUZWN0wvUnZaUkZPWk5FZDc3VGtSS0M4MEsyYnZmdVpm?=
 =?utf-8?B?czUrWFlHVlRrSDNHSjBsOVEzb0RhMXZRSEx6V2k0d2JmMmRoUzYvdm5PVTNl?=
 =?utf-8?B?aUlhRGhGWlFpTUVDaFdVUlhXTG4zRGVLU2I1NzNqZTVyUlI4RlpmTHFpSkUz?=
 =?utf-8?B?aUp0MGRBd1Q1OXBNQzBhU2JySHFxeW5VcWFIM2pKWEk4T0JUQTN6bndQTVow?=
 =?utf-8?B?ZXRxelNkcmlRZkRYM21UTXVWblBOUG1tNFcyVTU0a2NBOEdTZmdwWTdyaExV?=
 =?utf-8?B?MDNPU2hWaEhVbjEyRXFwVCt0NWR4UzMzQzdSbGdScUxBQ0I5bmVYalVMNjd1?=
 =?utf-8?B?T2k3Z2dnTkNoa2F1d3ZUOUQvQThpWXVKUmlkMFFiRUFvYUtOMEtxWGp3M1Jv?=
 =?utf-8?B?dmZGeVM1VVREWGlwaVRmcjBrOXViMkVDR1NpTkJlVFp4TTNDME5nQlc5ZS9s?=
 =?utf-8?B?alpyMHN3NzNURHZ6bVJ1Z1JKQk9GeHQwMTRpUG56UW9ZUWZOUDlrRUkzVklT?=
 =?utf-8?B?alRmb05QUXp4aVJZNmRXOHY2VXNZZEZCUHN2Nk9vNFF1NGdwdE5pRlZ4ZnZh?=
 =?utf-8?B?dHZpbklZb29uVnZtcmI1cFRocEdaVWN3WkZXRzc3RktETjc5ZU9ZQWh4ZTRw?=
 =?utf-8?B?OG9vYUt6cjJFWFFDdFI1emJBS1g0aUV5UkpiZnQvM2puTm9HeDM4b015T09B?=
 =?utf-8?B?TFVHWmFlWU95cWl2SmxzSU1SaytiUXczZUZrcWcvQWJ6RUxOMnlBUUhHYmZJ?=
 =?utf-8?B?b3RsTzQ4Y3NtYnVZbHJKSFdXQkJJRHc3b28yNkVlS25vYjJFdklkTXI2VGZ1?=
 =?utf-8?B?bmdNTGpicG5zRVdaWHlhOVZiZUVUTlNFY21wTTBBaU5IQStTQTdUT215eUJ4?=
 =?utf-8?B?dGh5L3Npa21QU0N6UjJuc1hlSmNOQnVoYVFSQ0c4L3NYbjRxMU44bG5xMjJi?=
 =?utf-8?B?VE9UUzhzQlFwaFdLSTlRQWowZzFnTUhkVmpvcTdUL2xDUnUyMEF4TGNtdDdk?=
 =?utf-8?B?Y214bGhKWVp1NDFBandNUkxnUXJhbFJ0cUY0T1hUQWRnSXZlWTE2VmlSSzcy?=
 =?utf-8?B?b3lpWEhFU0NCOGtmSzEvcHQrRGhBelZlU0FCcWt4d3NtcmVZZUg3eDdGVmw5?=
 =?utf-8?B?NWFRSWE2cHdDaG4xZVFHQUVoa3VxODUxZFRXamtmQlI2YmpHNmZHbit3SUtr?=
 =?utf-8?B?M3lacDYzTXhMU20ybzBVYk00Um5vdDEzTlR5M3Q4MkxQQ1Q0U2FwbDlSbmx2?=
 =?utf-8?B?R0NBZzY4NlAwWW5zNVdrbWt4SEdyc1ZTLzFReEFwUk5hUUE1K0tZeU1qYnA5?=
 =?utf-8?B?NDNkZmlmNlZMenZKNlp3dGtxL1c5VW11blluc2NvRS8rSXhMbHhhTEk3c2tM?=
 =?utf-8?B?bXV5VG9zbldEREM4NGpSdlk0bVRDbDVrTitVRnRsL1dsa1hiNit4UDJOTzJD?=
 =?utf-8?B?S25BaGtIUkE0bWdBd1FFVEpTWUFiOTc1VW85bmtQUGRlYlhoa3VteXMxUDUw?=
 =?utf-8?B?c3pRQWErYm5UeWNjT3JaQUNwa2dLQUd2Zy83NnZhRHZLbjFycTF5dFJsclZN?=
 =?utf-8?B?dzR4cVVrOWlZWEIwSnpOVUhidzNCZDArMmovSTJlUlc5cVlZYXBieVVBNzZr?=
 =?utf-8?B?Y0xDcVJYdkFXMktZcmlqNFhXRXByQ08wYnJVa0Q2clRQR0VjYnVVTGpzcWFT?=
 =?utf-8?B?WVZxeWdYdUhzVFM0UVZHUW9ZOE52RHdKMWNQV09hOERpcXpPQ1gwVXJ3M1dD?=
 =?utf-8?B?dS9jV3B5V052Sk8zNjlqSWhWMmFGS20wcmRaSWFncXBiYmpCbXc5WWJjamJn?=
 =?utf-8?B?b2dweit1aDM4N2xwZU5rMmFYbnF5ZmNCOFdSZkNzK1c0Zi9La1FieEVhRWNX?=
 =?utf-8?B?dTB2SXFXTitTbXhaSEhJci9HdTVkdUNJS3NiNTBKanVmczExb3plS0JHVlNk?=
 =?utf-8?B?UFN6Wk9XbTNkaXhhOUEzZXZuS1ErWHdOZXdnUEZUY2V5Qk90dzMwNEo0eXFu?=
 =?utf-8?B?MzF3WFZJbmM0UnBQaFh1UGsxY2tJUFpjRTBkNzNTeFVBQWY2UjdzeUJXajR6?=
 =?utf-8?B?NG9JdGdpcUppM2twakpyOUd3MUIrWDZTaHBsT1dyMFZ0U29Yd2Z3VWMvNkxh?=
 =?utf-8?B?N0dDWU9UTGVONk85eTVHMTRnV0orTWtyN2tBVVJRdmdPaFpNdEI5eTNvVGdG?=
 =?utf-8?Q?JPopNAxF1Tgt06k8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9563c60e-060e-4c68-69cf-08da23d4eac8
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 20:24:20.7419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QfMJ0kMGFfeRPURYIJlzY1e+Nb7bZtk0+2BP6DTTKR23Kc2N6yNNJOr7gMSuFIl7kbgy2ZmxZoSTWykQnwU/YL2kMm8uBCCMC/hEDyTgPhw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2278
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/19/2022 6:26 PM, jeff.evanson@gmail.com wrote:
> From: Jeff Evanson <jeff.evanson@qsc.com>
>
> In igc_xsk_wakeup, trigger the proper interrupt based on whether flags
> contains XDP_WAKEUP_RX and/or XDP_WAKEUP_TX.
>
> Consider a scenario where the transmit queue interrupt is mapped to a
> different irq from the receive queue. If XDP_WAKEUP_TX is set in the
> flags argument, the interrupt for transmit queue must be triggered,
> otherwise the transmit queue's napi_struct will never be scheduled.
>
> In the case where both XDP_WAKEUP_TX and XDP_WAKEUP_RX are both set,
> the receive interrupt should always be triggered, but the transmit
> interrupt should only be triggered if its q_vector differs from the
> receive queue's interrupt.
>
> Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy")

You're missing your sign-off; same for patch 1. Also, there's a handful 
of issues being reported by checkpatch [1]

Thanks,

Tony

[1] 
https://patchwork.kernel.org/project/netdevbpf/patch/20220420012635.13733-3-jeff.evanson@qsc.com/