Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp910593pxb; Fri, 22 Apr 2022 14:05:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWYktrrobEucFsJxCAQi80GBYKD0pp2oSc7Fkwnp5PO5KxLr5JnKs8mNHF4S31Qca/Sb2a X-Received: by 2002:a17:902:76ca:b0:157:1c6:5660 with SMTP id j10-20020a17090276ca00b0015701c65660mr6461755plt.105.1650661525083; Fri, 22 Apr 2022 14:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650661525; cv=none; d=google.com; s=arc-20160816; b=kUk9yw5n3iIHVxXLKvhspf90I8majwtXo1Iv9ULtT8RuW2DgkmagayqDOWhGWfQKsK 8qeMj9ZHpEqj+6XTb4wia9rSXfSIVgaNYbZ8/I1my4c8PDlO06YCVDjaBNP3USgVBQ3T xyORkuyLPEVX+Q4j98jhIuLbnGlVO3xEXaLoK1C7Jh9sLfUB1bz6QPeiCoY2CJTgyjsS X3jiHbl6I+JHzzxShi2z3WIwnxLHynuyPmWgOB85VQnFev3mjoWbV6d11dReQX7q4QVt RJambCWKS3skEOVdywxDiUqRYWzBIbzzjoXVLhFuQ2lAf24uNqbI6jP/uuHVItE9DxEo iPpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cDxTioHiBNl0ShGtOtJTiJLp7g6rOsr5782kvRAjCUQ=; b=cy9VnCXvgxEFBIRNQmLk4vSqlSTKZ1lacW2a87waLVfkLRQ/ldWLFxgMKeX2mRhHjc haile6m+ceXnEL94yAO6PkB/zvKCcAG4p90PuiAEm0jM99QQzSOJwtXi9DHlMfTfDhT2 YrtoLR5TiLaXt4dLXJ3gb1166qvpVJO4PmPt0XuVsCQMqWUDL4yZig1We8BXYxlNvagh tgOU/DVyUUhQ6zbzhtrZNy1bp07IzlNktuuM6sPZyOj2+PxWlCHCjeypcX4++Suok8Yp j0cjsJRTjr2CBcoqcyf4PuR2NFDlkkjUvIvt6DYdWzyuXkHmgddyWeTzPo/fpc3kntFC uJ+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=otANhqrg; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f12-20020a170902ce8c00b001568cc6d92bsi10334764plg.335.2022.04.22.14.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 14:05:25 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=otANhqrg; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5EC8F329355; Fri, 22 Apr 2022 13:02:31 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1448873AbiDVOsy (ORCPT + 99 others); Fri, 22 Apr 2022 10:48:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380235AbiDVOsw (ORCPT ); Fri, 22 Apr 2022 10:48:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACF0E5C34F for ; Fri, 22 Apr 2022 07:45:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48A8860E84 for ; Fri, 22 Apr 2022 14:45:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A526C385A9; Fri, 22 Apr 2022 14:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650638758; bh=cDxTioHiBNl0ShGtOtJTiJLp7g6rOsr5782kvRAjCUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=otANhqrgOZHmla1PLVJTn+/PeBD/i4BRde0GTTPX7VRnhwthPs/KGhRuF8kJSCKYE eAehXxRmztorxGkk/oohqzi/Qlv0yNaXqK6nhnE4nIA/qGxpsl+65hipm9jHw0KdI7 6MQ41ud0P6T2NoQtjVu69UE+FCa5dTyZrooqIids= Date: Fri, 22 Apr 2022 16:45:55 +0200 From: Greg KH To: Jaehee Park Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Pavel Skripkin Subject: Re: [PATCH v4 7/7] staging: r8188eu: remove unused else condition Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 03:20:32PM -0400, Jaehee Park wrote: > s_ret cannot return '2' so this else condition is unused. Remove this > unnecessary else statement. s_ret is not a function, it is a value. rtw_select_and_join_from_scanned_queue() is the function here. Can you fix up the wording in this changelog text and resubmit? thanks, greg k-h