Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 22 Apr 2022 11:17:11 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Rahul T R <r-ravikumar@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>, <kristo@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski@canonical.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <tomi.valkeinen@ideasonboard.com>,
        <laurent.pinchart@ideasonboard.com>, <kishon@ti.com>
Subject: Re: [PATCH v3 0/2] DSS: Add support for DisplayPort
Message-ID: <20220422161711.jkderbw5r4wxwgjf@crudeness>
References: <20220406165852.13026-1-r-ravikumar@ti.com>
 <ed64bf63-95c6-94ae-4c4f-a206250f44a9@ti.com>
 <20220422141637.4hz5nrlpjapmqezw@uda0490373>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220422141637.4hz5nrlpjapmqezw@uda0490373>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 19:46-20220422, Rahul T R wrote:
> On 12:51-20220415, Vignesh Raghavendra wrote:
> > 
> > 
> > On 06/04/22 10:28 pm, Rahul T R wrote:
> > > The following series of patches enables DisplayPort on
> > > j721e-evm
> > > 
> > > Tomi Valkeinen (2):
> > >   arm64: dts: ti: k3-j721e-main: add DP & DP PHY
> > >   arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm
> > > 
> > > v2:
> > >    - use phandle with a parameter to refer clocks insted of
> > >      sub nodes in serdes_wiz node
> > >    - move phy link node to board DTS file
> > > 
> > > v3:
> > >    - Fix the regulator node name as per the DT spec
> > >    - Use Macro for GPIO type
> > > 
> > > boot logs:
> > >    https://gist.githubusercontent.com/ravi-rahul/1bdbc3f77ab381e486c8394650c2e85d/raw/f04584c30181821c4ee83aee7781a9ba143cd3f3/j7_DP_upstream.log
> > > 
> > > kernel patch verify report:
> > >    https://gist.githubusercontent.com/ravi-rahul/a982fef3fae03ec0dbdd5cb475a4cb25/raw/c8230370746e9878daf9527c3aa9d82eed7aa33c/report-kernel-patch-verify.txt
> > 
> > Hmm, With dtbs_check I see (on v5.18-rc1 tag)
> > 
> > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: ports: 'port@0' is a required property
> > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: ports: 'port@4' is a required property
> > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: 'phys' is a required property
> > +/workdir/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: dp-bridge@a000000: 'phy-names' is a required property
> > 
> > This goes away with 2/2 although adds:
> > +<stdout>: Warning (graph_child_address): /bus@100000/dss@4a00000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > 
> > 
> > Do we need to have empty ports node in j721e-main.dtsi for dp-bridge?   And something similar wrt phys as well?
> > 
> > Regards
> > Vignesh
> 
> Hi Vignesh,
> 
> Thanks for the review!
> Not sure why kernel patch verify did not catch this

if you are'nt able to install all the required packages and version of
packages, then use the kpv wrapper script for docker container that
already packages things.
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D