Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp918456pxb; Fri, 22 Apr 2022 14:16:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwggqCf645NmTlZZfE1IyTCFxXLe/bzA+c2f3u+5q+nT4xZ8M4F6aIZd7kCja0BGI4z0OSw X-Received: by 2002:a17:902:7244:b0:158:41d3:b79b with SMTP id c4-20020a170902724400b0015841d3b79bmr6593519pll.50.1650662219366; Fri, 22 Apr 2022 14:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650662219; cv=none; d=google.com; s=arc-20160816; b=l3OhouVa1YV3KZKxSBeqpRmjssRHjGrzTYbFuycK3u4aY97liK8D6a+p7p5P3rwVJC HuFxbOgrYIHIf72198NuYXoniIRZQgIot10W79xFgU2om6NH2tkVM9jgt00ebzpwh9Sy OXg7E52sluayZ+e2yeVrKpok0opquRBtmBuP0zGtlc4FtUDg60ZnxPN5fv1q2nDIDtYp j4VYlzCJVFxV3bMxZDUrA3gMxkKAtNaJ2E2dgpCw4Ua9kxspN0rN9Bn7eiodoO55hbyE Zus3QUyjD1fx/B0YnwRLcoxVfGxz2/Ul2baDuqwB/ncwlYtafhRsBVjvv6FqpeYfF/Dq UT9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=+93kuj/MOMnHj2QW/LSXD1C8J8Ra9JlHlyTHo5/AZ7E=; b=QlgesiQkmyFl2iVmlcp84+D8w8aGgsBHmMkyeSL8XIIhEYaaxfLCbIyZLkYNTWLl15 oXyWbEqWGyNjw6lgr5gIiDShX6ZIXy5wIzymKXHFqStNid3ohJSGXRToxOxBEVb+3tBd LwFNIT7Qn3nKtnN7EOFqIcQ+uuR0mEas7UQ5Anet3kq9KMsPiP551Aq/H5okOgCFrBI8 RXkahsa+veEPWPSswZzz6Rx+X8TtGJsibmuuCY3YVqoA1KxfGCyy9UXkt7dPaPuxJ7r6 wa6MyAafVDipLP4ivKB79LLj9pS4H421ZtgcLkeSAtyZIRhTg8Kqhd7+Mj6Cgkgf3UUf 3myA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b18-20020a170902e95200b00158ea24bbb5si10129582pll.197.2022.04.22.14.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 14:16:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 51B6711F600; Fri, 22 Apr 2022 12:25:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387212AbiDUJUp (ORCPT + 99 others); Thu, 21 Apr 2022 05:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387582AbiDUJUf (ORCPT ); Thu, 21 Apr 2022 05:20:35 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A08AB25C47; Thu, 21 Apr 2022 02:17:40 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 21 Apr 2022 17:17:40 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 21 Apr 2022 17:17:38 +0800 From: Haowen Bai To: Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires CC: Haowen Bai , , Subject: [PATCH] HID: amd_sfh: Drop redundant memset Date: Thu, 21 Apr 2022 17:17:36 +0800 Message-ID: <1650532656-27602-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. So we drop redundant memset. Signed-off-by: Haowen Bai --- drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c index 76095bd53c65..26ccdcfbcda5 100644 --- a/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c +++ b/drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c @@ -33,27 +33,22 @@ int get_report_descriptor(int sensor_idx, u8 *rep_desc) { switch (sensor_idx) { case accel_idx: /* accel */ - memset(rep_desc, 0, sizeof(accel3_report_descriptor)); memcpy(rep_desc, accel3_report_descriptor, sizeof(accel3_report_descriptor)); break; case gyro_idx: /* gyro */ - memset(rep_desc, 0, sizeof(gyro3_report_descriptor)); memcpy(rep_desc, gyro3_report_descriptor, sizeof(gyro3_report_descriptor)); break; case mag_idx: /* Magnetometer */ - memset(rep_desc, 0, sizeof(comp3_report_descriptor)); memcpy(rep_desc, comp3_report_descriptor, sizeof(comp3_report_descriptor)); break; case als_idx: /* ambient light sensor */ - memset(rep_desc, 0, sizeof(als_report_descriptor)); memcpy(rep_desc, als_report_descriptor, sizeof(als_report_descriptor)); break; case HPD_IDX: /* HPD sensor */ - memset(rep_desc, 0, sizeof(hpd_report_descriptor)); memcpy(rep_desc, hpd_report_descriptor, sizeof(hpd_report_descriptor)); break; -- 2.7.4