Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Mime-Version: 1.0
Subject: Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver
Reply-To: wangseok.lee@samsung.com
Sender: Wangseok Lee <wangseok.lee@samsung.com>
From:   Wangseok Lee <wangseok.lee@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        robh+dt <robh+dt@kernel.org>, krzk+dt <krzk+dt@kernel.org>,
        kishon <kishon@ti.com>, vkoul <vkoul@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "jesper.nilsson" <jesper.nilsson@axis.com>,
        "lars.persson" <lars.persson@axis.com>
CC:     bhelgaas <bhelgaas@google.com>,
        linux-phy <linux-phy@lists.infradead.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        "lorenzo.pieralisi" <lorenzo.pieralisi@arm.com>, kw <kw@linux.com>,
        linux-arm-kernel <linux-arm-kernel@axis.com>,
        kernel <kernel@axis.com>, Moon-Ki Jun <moonki.jun@samsung.com>,
        Dongjin Yang <dj76.yang@samsung.com>
In-Reply-To: <4a6dd90c-3f8e-ad18-0136-88b75f4d9cf9@kernel.org>
Message-ID: <20220421235725epcms2p1fc34c904f960cba958fa692c6d5dad9c@epcms2p1>
Date:   Fri, 22 Apr 2022 08:57:25 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <4a6dd90c-3f8e-ad18-0136-88b75f4d9cf9@kernel.org>
        <20220418072049epcms2p463a9f01d8ae3e29f75b746a0dce934f1@epcms2p4>
        <CGME20220418072049epcms2p463a9f01d8ae3e29f75b746a0dce934f1@epcms2p1>
Precedence: bulk

> On=C2=A018/04/2022=C2=A009:20,=C2=A0Wangseok=C2=A0Lee=C2=A0wrote:=0D=0A>>=
>>=C2=A0Also,=C2=A0as=C2=A0you=C2=A0know,=0D=0A>>>>=C2=A0exynos=C2=A0driver=
=C2=A0is=C2=A0designed=C2=A0according=C2=A0to=C2=A0exynos=C2=A0SoC=C2=A0pla=
tform,=0D=0A>>>>=C2=A0so=C2=A0both=C2=A0function=C2=A0and=C2=A0variable=C2=
=A0names=C2=A0start=C2=A0with=C2=A0exynos.=0D=0A>>>=0D=0A>>>=C2=A0That's=C2=
=A0hardly=C2=A0a=C2=A0problem...=0D=0A>>>=0D=0A>>>>=C2=A0Compared=C2=A0to=
=C2=A0the=C2=A0existing=C2=A0exynos=C2=A0driver,=C2=A0=0D=0A>>>>=C2=A0you=
=C2=A0can=C2=A0see=C2=A0that=C2=A0the=C2=A0structure=C2=A0and=C2=A0type=C2=
=A0of=C2=A0function=C2=A0are=C2=A0different.=0D=0A>>>=0D=0A>>>=C2=A0No,=C2=
=A0I=C2=A0cannot=C2=A0see=C2=A0it.=C2=A0You=C2=A0coded=C2=A0the=C2=A0driver=
=C2=A0that=C2=A0way,=C2=A0you=C2=A0can=C2=A0code=C2=A0it=C2=A0in=0D=0A>>>=
=C2=A0other=C2=A0way.=0D=0A>>>=0D=0A>>>>=C2=A0For=C2=A0this=C2=A0reason,=C2=
=A0it=C2=A0is=C2=A0difficult=C2=A0to=C2=A0use=C2=A0the=C2=A0existing=C2=A0e=
xynos=C2=A0driver=C2=A0=0D=0A>>>>=C2=A0for=C2=A0artpec.=0D=0A>>>=0D=0A>>>=
=C2=A0Naming=C2=A0of=C2=A0functions=C2=A0and=C2=A0structures=C2=A0is=C2=A0n=
ot=C2=A0making=C2=A0it=C2=A0difficult.=C2=A0That's=0D=0A>>>=C2=A0not=C2=A0t=
he=C2=A0reason.=0D=0A>>>=0D=0A>>>>=C2=A0Our=C2=A0idea=C2=A0is=C2=A0to=C2=A0=
register=C2=A0a=C2=A0new=C2=A0PCIe=C2=A0driver=C2=A0for=C2=A0artpec-8=C2=A0=
SoC=C2=A0platform=C2=A0=0D=0A>>>>=C2=A0and=C2=A0maintain=C2=A0it=C2=A0in=C2=
=A0the=C2=A0future.=0D=0A>>>=0D=0A>>>=C2=A0We=C2=A0also=C2=A0want=C2=A0to=
=C2=A0maintain=C2=A0Exynos=C2=A0PCIe=C2=A0driver=C2=A0in=C2=A0the=C2=A0futu=
re.=0D=0A>>>=0D=0A>>>=C2=A0Best=C2=A0regards,=0D=0A>>>=C2=A0Krzysztof=0D=0A=
>>=C2=A0=0D=0A>>=C2=A0Hi,=C2=A0=0D=0A>>=C2=A0Sorry=C2=A0for=C2=A0delay=C2=
=A0response.=0D=0A>=20=0D=0A>=20Sure,=C2=A0happens,=C2=A0but=C2=A0I=C2=A0do=
n't=C2=A0remember=C2=A0the=C2=A0discussion,=C2=A0so=C2=A0replying=C2=A0that=
=0D=0A>=20late=C2=A0will=C2=A0not=C2=A0help=C2=A0your=C2=A0cause.=0D=0A>=20=
=0D=0A>=20You=C2=A0know=C2=A0that=C2=A0if=C2=A0you=C2=A0(you=C2=A0as=C2=A0S=
amsung)=C2=A0worked=C2=A0with=C2=A0upstream,=C2=A0e.g.=C2=A0by=0D=0A>=20ext=
ending=C2=A0the=C2=A0drivers=C2=A0and=C2=A0keeping=C2=A0them=C2=A0in=C2=A0s=
hape,=C2=A0it=C2=A0would=C2=A0be=C2=A0much=C2=A0easier=0D=0A>=20for=C2=A0yo=
u=C2=A0(again=C2=A0you=C2=A0as=C2=A0Samsung)=C2=A0to=C2=A0actually=C2=A0add=
=C2=A0new=C2=A0features?=C2=A0It's=C2=A0much=0D=0A>=20better/effective=C2=
=A0approach=C2=A0than=C2=A0the=C2=A0path=C2=A0of=C2=A0pushing=C2=A0every=C2=
=A0time=C2=A0new=C2=A0driver=0D=0A>=20with=C2=A0explanation=C2=A0like=C2=A0=
=22we=C2=A0do=C2=A0not=C2=A0want=C2=A0to=C2=A0maintain=C2=A0older=C2=A0driv=
er,=C2=A0so=C2=A0we=0D=0A>=20want=C2=A0a=C2=A0new=C2=A0one=22...=0D=0A>=20=
=0D=0A>>=C2=A0I=C2=A0have=C2=A0listed=C2=A0some=C2=A0parts=C2=A0that=C2=A0a=
re=C2=A0different=C2=A0from=C2=A0exynos=C2=A0pcie=C2=A0driver.=0D=0A>>=C2=
=A0=0D=0A>>=C2=A0PHY=C2=A0driver=0D=0A>>=C2=A0PHY=C2=A0is=C2=A0different,=
=C2=A0so=C2=A0register=C2=A0map=C2=A0is=C2=A0also=C2=A0different.=0D=0A>>=
=C2=A0Three=C2=A0reference=C2=A0clock=C2=A0options=C2=A0are=C2=A0available=
=C2=A0in=C2=A0ARTPEC-8.=0D=0A>>=C2=A0=C2=A0=C2=A0It=C2=A0operates=C2=A0by=
=C2=A0selecting=C2=A0one=C2=A0clock=C2=A0among=C2=A0XO,=C2=A0IO,=C2=A0and=
=C2=A0SOC=C2=A0PLL.=0D=0A>>=C2=A0=C2=A0=C2=A0However,=C2=A0the=C2=A0exynos=
=C2=A0phy=C2=A0driver=C2=A0sets=C2=A0one=C2=A0ref=C2=A0clk=C2=A0though=C2=
=A0sysreg.=0D=0A>=20=0D=0A>=20It=C2=A0usually=C2=A0trivial=C2=A0to=C2=A0cod=
e=C2=A0such=C2=A0difference=C2=A0in=C2=A0the=C2=A0driver.=0D=0A>=20=0D=0A>>=
=C2=A0The=C2=A0reset=C2=A0method=C2=A0and=C2=A0type=C2=A0of=C2=A0PHY=C2=A0f=
or=C2=A0initialization=C2=A0are=C2=A0different.=0D=0A>>=C2=A0The=C2=A0overa=
ll=C2=A0sysreg=C2=A0configuration=C2=A0is=C2=A0different=0D=0A>=20=0D=0A>=
=20Indeed.=0D=0A>=20=0D=0A>>=C2=A0Artpec-8=C2=A0requires=C2=A0a=C2=A0separa=
te=C2=A0sequence=C2=A0for=C2=A0phy=C2=A0tuning,=0D=0A>>=C2=A0but=C2=A0it=C2=
=A0does=C2=A0not=C2=A0exist=C2=A0in=C2=A0exynos=C2=A0phy=C2=A0driver.=0D=0A=
>>=C2=A0Artpec-8=C2=A0requires=C2=A0pcs=C2=A0resources,=C2=A0but=C2=A0exyno=
s=C2=A0phy=C2=A0driver=C2=A0does=C2=A0not=C2=A0exist.=0D=0A>>=C2=A0=0D=0A>=
=20=0D=0A>=20For=C2=A0the=C2=A0phy=C2=A0driver=C2=A0indeed=C2=A0it=C2=A0mig=
ht=C2=A0require=C2=A0much=C2=A0effort=C2=A0to=C2=A0create=C2=A0one=C2=A0dri=
ver.=0D=0A>=20=0D=0A>>=C2=A0Controller=C2=A0driver=0D=0A>>=C2=A0Sub=C2=A0co=
ntroller=C2=A0is=C2=A0different,=C2=A0so=C2=A0register=C2=A0map=C2=A0is=C2=
=A0also=C2=A0different.=0D=0A>>=C2=A0And=C2=A0it=C2=A0is=C2=A0different=C2=
=A0handles=C2=A0lane=C2=A0control,=C2=A0link=C2=A0control,=C2=A0PHY=C2=A0cl=
ocking,=0D=0A>>=C2=A0reset,=C2=A0interrupt=C2=A0control.=C2=A0=0D=0A>>=C2=
=A0The=C2=A0number=C2=A0and=C2=A0type=C2=A0of=C2=A0clock=C2=A0resources=C2=
=A0used=C2=A0are=C2=A0different.=0D=0A>>=C2=A0The=C2=A0overall=C2=A0sysreg=
=C2=A0configuration=C2=A0is=C2=A0different=0D=0A>>=C2=A0=0D=0A>>=C2=A0Also=
=C2=A0artpec-8=C2=A0is=C2=A0performed=C2=A0in=C2=A0dual=C2=A0mode=C2=A0that=
=C2=A0supports=C2=A0both=C2=A0RC=C2=A0and=C2=A0EP.=0D=0A>>=C2=A0As=C2=A0des=
cribed=C2=A0above,=C2=A0the=C2=A0PHY=C2=A0and=C2=A0sub=C2=A0ontroller=C2=A0=
are=C2=A0different=0D=0A>>=C2=A0and=C2=A0the=C2=A0regiser=C2=A0map=C2=A0is=
=C2=A0different.=0D=0A>>=C2=A0sysreg=C2=A0is=C2=A0also=C2=A0different.=C2=
=A0And=C2=A0there=C2=A0are=C2=A0differences=C2=A0such=C2=A0as=C2=A0reset.=
=0D=0A>>=C2=A0The=C2=A0driver=C2=A0will=C2=A0be=C2=A0much=C2=A0more=C2=A0co=
mplicated=C2=A0if=C2=A0both=C2=A0hardwares=C2=A0should=C2=A0be=0D=0A>>=C2=
=A0supported=C2=A0in=C2=A0the=C2=A0same=C2=A0driver.=0D=0A>=20=0D=0A>=20May=
be,=C2=A0quite=C2=A0probably.=C2=A0The=C2=A0reluctance=C2=A0to=C2=A0extend=
=C2=A0any=C2=A0existing=C2=A0code=C2=A0makes=0D=0A>=20me=C2=A0doubting=C2=
=A0this,=C2=A0but=C2=A0I=C2=A0admit=C2=A0that=C2=A0there=C2=A0are=C2=A0many=
=C2=A0differences.=0D=0A>=20=0D=0A>>=C2=A0For=C2=A0these=C2=A0reasons,=C2=
=A0my=C2=A0opinion=C2=A0is=C2=A0that=C2=A0better=C2=A0to=C2=A0create=0D=0A>=
>=C2=A0a=C2=A0phy,=C2=A0controller=C2=A0both=C2=A0driver=C2=A0with=C2=A0a=
=C2=A0new=C2=A0file.=0D=0A>>=C2=A0Please=C2=A0let=C2=A0me=C2=A0know=C2=A0yo=
ur=C2=A0opinion.=0D=0A>=20=0D=0A>=20At=C2=A0the=C2=A0end=C2=A0it's=C2=A0mos=
tly=C2=A0the=C2=A0decision=C2=A0of=C2=A0PCIe=C2=A0and=C2=A0phy=C2=A0subsyst=
em=0D=0A>=20maintainers=C2=A0whether=C2=A0they=C2=A0want=C2=A0to=C2=A0have=
=C2=A0separate=C2=A0drivers=C2=A0for=C2=A0DWC=C2=A0PCIe=0D=0A>=20blocks=C2=
=A0in=C2=A0ARMv8=C2=A0Samsung=C2=A0SoCs.=0D=0A>=20=0D=0A>=20In=C2=A0any=C2=
=A0case,=C2=A0the=C2=A0driver=C2=A0code=C2=A0looks=C2=A0like=C2=A0copied-pa=
sted=C2=A0from=C2=A0some=C2=A0vendor=0D=0A>=20sources,=C2=A0so=C2=A0you=C2=
=A0need=C2=A0to=C2=A0bring=C2=A0it=C2=A0to=C2=A0shape.=0D=0A>=20=0D=0A>=20B=
est=C2=A0regards,=0D=0A>=20Krzysztof=0D=0A=0D=0AHi,=0D=0A=0D=0AThank=20you=
=20for=20your=20kindness=20review=20over=20several=20e-mails.=0D=0AI=20will=
=20improve=20on=20PATCH=201,2,3,4=20and=20i=20will=20return=20with=20v2.=0D=
=0A(yaml=20and=20phy,=20controller=20driver=20code=20improvement)=0D=0AAt=
=20that=20time,=20i=20would=20like=20ask=20to=20you=20and=20phy,=20controll=
er=20=0D=0Amaintainer's=20opinion=20again.=0D=0A=0D=0AThank=20you.