Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 19 Apr 2022 21:36:17 -0500
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Cc:     agross@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_msavaliy@quicinc.com, dianders@chromium.org
Subject: Re: [V4 1/2] arch: arm64: dts: qcom: sc7280-idp: Configure cts
 pinctrl to bias-bus-hold
Message-ID: <Yl9xoYo8z7z4gSTT@builder.lan>
References: <1650349697-13540-1-git-send-email-quic_vnivarth@quicinc.com>
 <1650349697-13540-2-git-send-email-quic_vnivarth@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650349697-13540-2-git-send-email-quic_vnivarth@quicinc.com>
Precedence: bulk

On Tue 19 Apr 01:28 CDT 2022, Vijaya Krishna Nivarthi wrote:

> WLAN rail was leaking power during RBSC/sleep even after turning BT off.
> Change sleep pinctrl configuration to handle same.
> 

As I said before, I would like the subject to contain the word
"bluetooth" (or possibly BT if bluetooth doesn't fit).

And drop "arch: " from the subject prefix. If you're uncertain what to
put there, run below command and follow what everyone else does:

  git log --oneline -- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi

> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
> ---
> v4: modify subject of patch to indicate file it is applying to
> v3: apply same change to active state and other sc7280*.dts* as well
> v2: used bias-bus-hold as per review comments
> v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only
> ---
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 015a347..85e7467 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -400,10 +400,10 @@
>  
>  &qup_uart7_cts {
>  	/*
> -	 * Configure a pull-down on CTS to match the pull of
> -	 * the Bluetooth module.
> +	 * Configure a bias-bus-hold on CTS to lower power usage
> +	 * when BT is turned off.

This comment would just leave a future reader with the question about
_why_ does this lower the power usage...

This problem you're seeing is likely to come back in the next platform
and your successor (or even yourself) will have no use of this comment
to figure out what bias to configure on these pins.

Thanks,
Bjorn

>  	 */
> -	bias-pull-down;
> +	bias-bus-hold;
>  };
>  
>  &qup_uart7_rts {
> @@ -495,10 +495,10 @@
>  		pins = "gpio28";
>  		function = "gpio";
>  		/*
> -		 * Configure a pull-down on CTS to match the pull of
> -		 * the Bluetooth module.
> +		 * Configure a bias-bus-hold on CTS to lower power usage
> +		 * when BT is turned off.
>  		 */
> -		bias-pull-down;
> +		bias-bus-hold;
>  	};
>  
>  	qup_uart7_sleep_rts: qup-uart7-sleep-rts {
> -- 
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.
>