Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 21 Apr 2022 19:22:01 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     lkp@intel.com, gregkh@linuxfoundation.org, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH V5] staging: rtl8192e: Fix signedness bug in
 rtllib_rx_assoc_resp()
Message-ID: <20220421162201.GC2462@kadam>
References: <202204211558.TapLZO4j-lkp@intel.com>
 <1650529277-7893-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1650529277-7893-1-git-send-email-baihaowen@meizu.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8734LlMA944VKssRoBaOhdOY0LIvG73lkMWTf0Z9xRImoDVnq7FS/DQlvEf/?=
 =?us-ascii?Q?kz+G2eRs6dswcwJEDORF7gZa6mdIXVolIdNfV2OWRBbXQEzZOpRgnLsE8eau?=
 =?us-ascii?Q?B8gDysAXeYMRzgQrtKzKK03c37THfxtwLqPZY0S9UbMKQ5GyDd4uS5obn8yC?=
 =?us-ascii?Q?9fwtgz6C+tbQKn4qtT/P08atBLtyBto6cN3PShyhH9+jIfYNkqCqtkI2MDw0?=
 =?us-ascii?Q?Ew0tveRZBmCPwCSK99LKMCkI3MsxOosNWk2SY6TFdrv6V+i7+/Plh0jv2K/I?=
 =?us-ascii?Q?NJC9ippGGcUTO6LX4Tbq7wh1lO8TFmbsHMw8dBskUMnEHQEVMzHsOgQP2tVz?=
 =?us-ascii?Q?8fW6ak9o6GjFL6kebj8lAyDH16u6or8VMW5sUjNCEwdMq+InKAZoZLQRGokL?=
 =?us-ascii?Q?wgyVWKdwrUqxufXD4HqeoUdBXLeXtW48KfleIOYFZtKc0z9GIIGlNrOYiE2N?=
 =?us-ascii?Q?GbRC7eLWmolMQR6ES4upQG8rSFmKvlIMmoeyg1ciZfZn9yMxW76E1ppOOEgx?=
 =?us-ascii?Q?kIAqFQX7BVaz+u2G6Cq1XgZ4bubirdjNhmuY0PtpS788oLJG2CYYE7LfhQQ2?=
 =?us-ascii?Q?FsxBDDzx6DGZVTQ6Z5jyvptEREaUkljSqRj1raOK3jWMH+h7nTm8mQWHamFl?=
 =?us-ascii?Q?Dbug/xPqicbUloU64hOAMU+IUqKL02t6kgwzzEp+6MsJuIkDSId8xcM14D4R?=
 =?us-ascii?Q?VABvQ8NA+dIykSNdfRBzs5dHSQCADlhtsCBRPY0Cm8GXRbWlKoVuiYRvOmWs?=
 =?us-ascii?Q?OSd6oo85Dq+/Th02VA/GPq2JnFAY12jLURowCo1slJ2ueLp7brvV7KxKuyxW?=
 =?us-ascii?Q?9N6HCd2aKXLRIPhFqNhrDUUc+HTHBvhLt0FcNeVOEjS2hwdD6iejMSAaX6Ow?=
 =?us-ascii?Q?jmqP4lhXDBEI1PjSaEzWQKm2nkO7WPwKkZ6ZwkMT+oYAJAIskkB7dBeXxIhp?=
 =?us-ascii?Q?jtF28kXMOVss2gIv1eOjEkwMXwlNFGBPD1Lz0GBpusFFsPCZVFw2EAq0TcKV?=
 =?us-ascii?Q?xtxkqtXe9sihT+NSgiU2J7yBRdd3NYCoemHoy9aMsEhaU78zzwf65CJk5jag?=
 =?us-ascii?Q?DR6SOmZaUVNnISjUA5OF2tzXZoMcdOBLSobKa64NOBt8pMOa4gl0WzJXGwrE?=
 =?us-ascii?Q?HZbEp92IAQc77pp2oT6w5o2tocgoC6mV8FVc7wYjZNVJ6vWUS7c8a5VXfam/?=
 =?us-ascii?Q?nEgaaGnxO2WwN1aR9ISu91eTaw/TKTHJ1qWlu07ziFFyLITnVhc5agxvABzS?=
 =?us-ascii?Q?vEG94C5EbMXz8eD1DJRyZUWDl5tAohSo8El7uTLTflg585D4oRISsMWB/s7u?=
 =?us-ascii?Q?IrpAt2OUNoBUFoWa0WUUIiCo22EGAU1WFra8UyBwc2jBQrpmlavOiZik9xZx?=
 =?us-ascii?Q?9h15jtoB5a87XXHGha4bQT0saeTBc+K6GlKOPv/eCSsf2Duiq8R6dgXoGe+z?=
 =?us-ascii?Q?lSOig0SP7eDRE4oX85S7S+MqgtYlq5Hfy69Y4wzkh0/fOm7PzL++YJpkN8Hn?=
 =?us-ascii?Q?ebUqmR2JMoux8j6AXX2Tii3WOWgHt3sdtNzK+1Ri+iKrRaueFiVsTXOVcc7r?=
 =?us-ascii?Q?esFR6tpZ/XTMHc9mm0z2MQQM/Q3cfkmYC470WICQ4+Lvm0gC3HeDlnTNVRu5?=
 =?us-ascii?Q?l24ef4+Ust9XtFvvjpC3eF/Cni0JE/z4OPtP/1TVCuR+J9iwDbLd+NN5X9kV?=
 =?us-ascii?Q?mXRF7JHyDT2E3B6xOc3AwZLPG6+lmqzw7aqzhL5LMK8RgIIbF6x8zAJSttCK?=
 =?us-ascii?Q?Vp2OfQ7dA763fBLgM98NS7e4jwGSpT0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a650010a-cf81-4050-130b-08da23b3174a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 16:22:12.7882
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G24LSs+eurBM/QmxAImsSg9HJaY+QlIU6RY58PifYYiOR/ogDBRBHa1IizKC5PS8oJlX0LGdAD6tQxgp8wjpYWI+pEXWuAdoY7gEP1h2nsU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2551
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-21_02:2022-04-21,2022-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204210087
X-Proofpoint-GUID: mgnEEJB0eVuuR_h2tPNdPIyPVCr8MuXo
X-Proofpoint-ORIG-GUID: mgnEEJB0eVuuR_h2tPNdPIyPVCr8MuXo
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 21, 2022 at 04:21:17PM +0800, Haowen Bai wrote:
> The rtllib_rx_assoc_resp() function has a signedness bug because it's
> a declared as a u16 but it return -ENOMEM.  When you look at it more
> closely it returns a mix of error codes including 0xcafe, -ENOMEM, and
> a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG.  This is a mess.
> 
> Clean it up to just return standard kernel error codes.  We can print
> out the a->status before returning a regular error code.  The printks
> in the caller need to be adjusted as well.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: reduce return random value; print its own error message.
> V2->V3: change commit message; change s16 -> int.
> V3->V4: 
> 1. change message suggested by Dan Carpenter;
> 2. hold a->status in auth_parse() and return error code or 0 on success.
> 3. print le16_to_cpu(errcode) -> int %d.
> V4->V5: fix compile error.
> 

Looks ok.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter