Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 22 Apr 2022 14:24:05 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     "ying.huang@intel.com" <ying.huang@intel.com>
CC:     Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@suse.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: swap: determine swap device by using page nid
Message-ID: <YmJKBaq1yj6/iBJ3@ziqianlu-desk1>
References: <20220407020953.475626-1-shy828301@gmail.com>
 <Yk6cutNf5sOuYbDl@ziqianlu-nuc9qn>
 <CAHbLzkq+eKcKCsxXDTiOcBxk8FjMdWBqOxwi4N_NG7PZWbAAkA@mail.gmail.com>
 <Yl/FS9enAD4V8jG3@ziqianlu-nuc9qn>
 <f27ec36beb3cf1dbbfc3b8835e586d5d6fe7f561.camel@intel.com>
 <YmETEHnK/FiNbLO7@ziqianlu-desk1>
 <6f7210be7353d1c01dc9f872b2692b83f87f5452.camel@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6f7210be7353d1c01dc9f872b2692b83f87f5452.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3aHfeClzLR347pvXlFfceg0Gd9Uk3QlrF05qC1Y3Pv/cA4UnoXqwwPrsvam8?=
 =?us-ascii?Q?vUTg1QQlP8zaNfpOioeX2Vu+z1bblCeSdRb4bMMexZDDoSpOBRwUTo64UVYU?=
 =?us-ascii?Q?t/2pwNLyAp9MCiE+dx3TQ2CZzbDA4sYzbAKMXfF73FHOaIm6yDSNqPHmHGvR?=
 =?us-ascii?Q?dudKFWrV/MspuuTx1M2z4YgCo9ItunwVfuA9Ey2G4+N9NbXtyfbrZS3X81qd?=
 =?us-ascii?Q?CpH1kHUVtQwaU+uGLNZhzbtOyD99D5DTOCQX+wny+9NUiuaFhXGCdNo506VA?=
 =?us-ascii?Q?mbuGYrz0Pmch05c1r7XNPrjrwKDoGmk+pAuLZOcRJAm5fv0MwS6iMARuEeut?=
 =?us-ascii?Q?QxERt/pplx9b1VDWf2XWuQ+GlNRro+UONpuSqkj0cnT+Jqh2pJse0e3eZ5Al?=
 =?us-ascii?Q?jLo0bdpxyoQ9QDoowwh29n0g6pDJGeMm0Sc5IC6EvI7h5Q6ozxaxEi3C9Nml?=
 =?us-ascii?Q?fu+UwnATU8uwWTE5N1k5+yVsrfVojkpUXSmEOx7p7KRtGQiSVxJqg+0IIjok?=
 =?us-ascii?Q?+ivn9H49jk8wSVCjtMgKh03+qio553AZWAGqwfIf66qz5539t63OsARSdrOf?=
 =?us-ascii?Q?BjY0RYQ3rdx6qqUN4RRrbnJX0sY+O53kwr6iNgzTigMe2uoTjn7lWP5JIkp9?=
 =?us-ascii?Q?x0s+b21xxOW01+YweT0wBKxhORU1ufiRz9xTO4fx9YnSSXPx27rZJgwnaQve?=
 =?us-ascii?Q?gze9SKnTJsedaXIAU3fioZQv1Ziga6aDxoYPn4r9BEAQM0NzOagW/vxvMrfS?=
 =?us-ascii?Q?VQhz00npC/5ZaVKtN5iD/VI8fhnYCbLnvlYKiRue+/9dZ6t92ZFzm9uLZEZR?=
 =?us-ascii?Q?nnyaC7ugs3XMz7k5+xw2WHXL6Ri2zqUoWKGzjM8s7hjtMjnw+EzXgaS6e/7w?=
 =?us-ascii?Q?Zg7OQhkDR1IE+5HduRdvRsTvlj+ui38zKI4/Dv3JsAGyVHdBYI8lDAKz3k4y?=
 =?us-ascii?Q?Rh543sxsKJjVMeMK7ysYWqNNkqWd8zvttsT4/3IWoLmoa2en7ara5zCPOc/a?=
 =?us-ascii?Q?4Pu7p7CWqNuc96QhKgGMgN07mHdtiNyodsVnqqsBNZjzvn3iRkNsLYVlCKFC?=
 =?us-ascii?Q?vOuJ99sBhyUsYjlGf+nv5zACOtzit5Htu43X+hyGsz9ez0nISV1GE3YyQZvg?=
 =?us-ascii?Q?xPBtWQYx0hVNy18+PnL+kB2WbVfqVO2lcp7eOX2y8yN7Br6D2RqvxvpRxxg4?=
 =?us-ascii?Q?IL9hi6h4xn1oSY79Svi+c4H+9CxpLZNL2AZ7xB3K7ahl25As5OWqqcmFL1Er?=
 =?us-ascii?Q?i5PfBxqJ54LtoJEipBLJXmEkT+qI6Mlt55xCWm6pKcqkZx89PGvvOGfRmonq?=
 =?us-ascii?Q?ldath/PqMQCZdAfIs7eaepahW0+mN9aqEK5yUfpU/od7wMEhsZ1DAyqOa2KM?=
 =?us-ascii?Q?D9OPzSv68AkVBOXnS0EYqb0xbgnktX1rT8MnH/0po8JAfWS8v7o2OtygD1WG?=
 =?us-ascii?Q?KoxGrZQGZ5ZbRpUU9jOQulq5aui0M/G5sVKWsgJleLWB1SAHGBFZd/f2fhg9?=
 =?us-ascii?Q?hgTJsbaY8mQ1YxyvWViS5JRU14VIUQ8jlF7UfQxDLlHql+n1/LzzHHFz6DFo?=
 =?us-ascii?Q?vHnXTzjI+sgPoVUktgU7xqAD6XuJTrsVfoDe9ILdeR1lowr8xv9Ic0Auda3+?=
 =?us-ascii?Q?bb1ek4qe11+mgAGGLmtIkgATIwS0YwSFridylhGG128CGgGUC0uMhq/TSFri?=
 =?us-ascii?Q?7Re80R2h0k2gQd9XLteqJUrNaxBPTTBjlmdYNT9LVZZJNEoCCcI2leHN91lk?=
 =?us-ascii?Q?HNNEQ28VZw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f931b2a6-3caa-490e-3606-08da2428b880
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3062.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 06:24:14.2798
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yfqDuCDL3gfS4JpWySXKXTQyVMG2oLgVadF73IkYwDltlOO/LaJVQcxi/fR/aNBhvVFWMsohdwJARIUZu7yf2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4855
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 21, 2022 at 04:34:09PM +0800, ying.huang@intel.com wrote:
> On Thu, 2022-04-21 at 16:17 +0800, Aaron Lu wrote:
> > On Thu, Apr 21, 2022 at 03:49:21PM +0800, ying.huang@intel.com wrote:

... ...

> > > For swap-in latency, we can use pmbench, which can output latency
> > > information.
> > > 
> > 
> > OK, I'll give pmbench a run, thanks for the suggestion.
> 
> Better to construct a senario with more swapin than swapout.  For
> example, start a memory eater, then kill it later.

What about vm-scalability/case-swapin?
https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/tree/case-swapin

I think you are pretty familiar with it but still:
1) it starts $nr_task processes and each mmaps $size/$nr_task area and
   then consumes the memory, after this, it waits for a signal;
2) start another process to consume $size memory to push the memory in
   step 1) to swap device;
3) kick processes in step 1) to start accessing their memory, thus
   trigger swapins. The metric of this testcase is the swapin throughput.

I plan to restrict the cgroup's limit to $size.

Considering there is only one NVMe drive attached to node 0, I will run
the test as described before:
1) bind processes to run on node 0, allocate on node 1 to test the
   performance when reclaimer's node id is the same as swap device's.
2) bind processes to run on node 1, allocate on node 0 to test the
   performance when page's node id is the same as swap device's.

Ying and Yang,

Let me know what you think about the case used and the way the test is
conducted.