Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp922661pxb; Fri, 22 Apr 2022 14:23:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfd3g6lDjU5RYd0313fHDxRF459Kgos6ZTBxdik6K/mPVWai1HlEJCtjc3P4xB54w+E2aZ X-Received: by 2002:a17:902:b58b:b0:15b:5a3f:814b with SMTP id a11-20020a170902b58b00b0015b5a3f814bmr6135888pls.154.1650662637974; Fri, 22 Apr 2022 14:23:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650662637; cv=none; d=google.com; s=arc-20160816; b=nJk4N9M7zx3DVBWJ77AjFW/UvA85drzt/kxMfoZS75HD3vh7FSrrZBcB5lcXeiR7y3 YjUuYNaZY1XMpj3RVn7Czy8QbHdQqANPaZ+f7F3+o5nuGcuIwWzC5t2g3kUeqBh4BFZt scJQMlfx2So7MQq8kaN85WWnug9RSgpQt9O/ir9mkeALdRSkaGZuBU3APgaoUSiCL0rv kWvYoQgpihNsbjXXQv0WB9BWNOZG/lXm5Ep+NiSmPu094r+fYsgfXs/8wr2zvtZAvmXE SQcvdXV73A/mtKeuUT0bdhxQU4HzAHCKJANvpKM2Q4o9G3dTPeDuWuBKs/vv1ENe7Hhq ZPcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gzGTp3lVytHT+2S7bNB+PpaqbFEeGTH/QS27bpeupmg=; b=Ty0OOtRxBq68cr3gQ/GpKwS4PGmmc/Ewsa3m+L28ehHYxWl2S8Ij8H1+H75yZJEHX2 rJJaNKMH/LHhaooj0vQIB+7yOO8F4bD8R0OGiwpizCMFsUNUHp5nYyy6tuLegkkllevp OrM0xdggDbGbttFrazJLF7WZf12tKuAe7mJsQIEUfn69tvkbRRa7YET0j1fQ/+QLhrri vgcPFLiOmY516VvXviCCsF2sFimPlQ6BvDDc1nMkHg7Lo6gkfs3Omw/8mWoRG2yyw/I3 g0wQFhCgdtHSHE7wEoGPC8vEC3i/ElE7r2CfTK8QdXhDr77sSh1TLSg9PI0DQwqf12k1 mFGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EUyO0fqD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 31-20020a630d5f000000b003aa33b2b6d0si9497632pgn.765.2022.04.22.14.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 14:23:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=EUyO0fqD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 51F2F2C3900; Fri, 22 Apr 2022 12:31:01 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443303AbiDVCQh (ORCPT + 99 others); Thu, 21 Apr 2022 22:16:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231551AbiDVCQf (ORCPT ); Thu, 21 Apr 2022 22:16:35 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7E464B1C2 for ; Thu, 21 Apr 2022 19:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650593624; x=1682129624; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=a3Q0zOlJmqzKbq1TioWMjq8UWQWJ+hPrxq2cIoPXurE=; b=EUyO0fqDn+uDfl4GpLn4jguL2xWHc3QTT7wUfVZngzBgR7VH5IJEcm+q i39MVH3imci0aAg9GMkQCLT7n4pvIOMV2dAvRmS630QeocdKOf5xE23E+ KsgjZEHf9dn8j24ixEVlK3+II82Ts11R/AudYiNXe0caz109fwj7zdTTK 6PvJqVI3Hqi8Q6vVw0vr+OOabUQZA9oBVnVaVtig4P4mVlqGUb6Jhuty2 gNoKcNaeUrZtBPwcPBL3Cd+wnxkZ8nLjY8Gj9hNJhHDh9o1IA+BCouoGQ JfaHJdXFAtS5xS0omjtGz0ktdO/IhZ/exkkE9PKe374hNCWUopb0GFJNa g==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="324991674" X-IronPort-AV: E=Sophos;i="5.90,280,1643702400"; d="scan'208";a="324991674" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 19:13:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,280,1643702400"; d="scan'208";a="671617883" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 21 Apr 2022 19:13:42 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 6F61E120; Fri, 22 Apr 2022 05:13:42 +0300 (EEST) Date: Fri, 22 Apr 2022 05:13:42 +0300 From: "Kirill A. Shutemov" To: Borislav Petkov Cc: Kuppuswamy Sathyanarayanan , X86 ML , LKML Subject: Re: [PATCH] x86/tdx: Annotate a noreturn function Message-ID: <20220422021342.wpxpubqan6ndsajx@black.fi.intel.com> References: <20220420115025.5448-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220420115025.5448-1-bp@alien8.de> X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 01:50:25PM +0200, Borislav Petkov wrote: > From: Borislav Petkov > > objdump complains: > > vmlinux.o: warning: objtool: __tdx_hypercall()+0x74: unreachable instruction > > because __tdx_hypercall_failed() won't return but panic the guest. > Annotate that that is ok and desired. > > Fixes: eb94f1b6a70a ("x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions") > Signed-off-by: Borislav Petkov Have not seen REACHABLE before. Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov