Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <18d8cc4875244211e3a89ae55f28abc9a73270b9.camel@linux.ibm.com>
Subject: Re: [PATCH v3 1/4] PCI: Clean up pci_scan_slot()
From:   Niklas Schnelle <schnelle@linux.ibm.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        linux-s390@vger.kernel.org, linux-pci@vger.kernel.org
Date:   Thu, 21 Apr 2022 13:14:42 +0200
In-Reply-To: <8225cf74d6d81c3ce149d677b5bf47689d8e3fd2.camel@linux.ibm.com>
References: <20220421021446.GA1356365@bhelgaas>
         <8225cf74d6d81c3ce149d677b5bf47689d8e3fd2.camel@linux.ibm.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-Ms39hFMWmUk7Ygg8vUOB"
Mime-Version: 1.0
Precedence: bulk


--=-Ms39hFMWmUk7Ygg8vUOB
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> > > +	return (fn <=3D 6) ? fn + 1 : -ENODEV;
> > >  }
> > > =20
> > >  static int only_one_child(struct pci_bus *bus)
> > > @@ -2643,24 +2645,19 @@ static int only_one_child(struct pci_bus *bus=
)
> > >   */
> > >  int pci_scan_slot(struct pci_bus *bus, int devfn)
> > >  {
> > > -	unsigned int fn, nr =3D 0;
> > > -	struct pci_dev *dev;
> > > +	int fn, nr =3D 0;
> > > +	struct pci_dev *dev =3D NULL;
> > > =20
> > >  	if (only_one_child(bus) && (devfn > 0))
> > >  		return 0; /* Already scanned the entire slot */
> > > =20
> > > -	dev =3D pci_scan_single_device(bus, devfn);
> > > -	if (!dev)
> > > -		return 0;
> > >=20

As it might not have been clear in my previous mail. The above !dev
test just for the "devfn + 0" case is equivalent to the new:

if (!dev && fn =3D=3D 0)
	return -ENODEV;

As fn doesn't wrap around anymore fn =3D=3D 0 is true only for the first
iteration. Both in the existing and in the changed code the first
pci_scan_single_device() happens before the first next_fn() call though
with the new code that then breaks the loop instead of the above
return. This makes sense in my mind because if the first function
doesn't exist there are no more functions except if we have isolated
PCI functions due to a hypervisor.

--=-Ms39hFMWmUk7Ygg8vUOB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSiikNOrnCUNbxSj4j7H22hwInkVgUCYmE8ogAKCRD7H22hwInk
Vm+HAP45A1zy11Y/5W/jNQUnT9LxW54xIwvl4lOPryiadpR6RwD/SSQw6KM6h2NS
C28XCesj1ws2dTi+n9nTjZk5JGh7Wgg=
=wWn8
-----END PGP SIGNATURE-----

--=-Ms39hFMWmUk7Ygg8vUOB--