Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 19 Apr 2022 13:11:44 -0500
From:   Rob Herring <robh@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: gnss: Add Broacom BCM4751 family bindings
Message-ID: <Yl77YPzpjT0hLNRN@robh.at.kernel.org>
References: <20220414214337.311880-1-linus.walleij@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220414214337.311880-1-linus.walleij@linaro.org>
Precedence: bulk

On Thu, Apr 14, 2022 at 11:43:37PM +0200, Linus Walleij wrote:
> The Broadcom BCM4751 family of (A-)GPS chips have been around for
> some years. The latest iteration BCM4753 is for example mounted
> on the Huawei HiKey970.
> 
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  .../bindings/gnss/brcm,bcm4751.yaml           | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml b/Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml
> new file mode 100644
> index 000000000000..f06a4acf21cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/brcm,bcm4751.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gnss/brcm,bcm4751.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM4751 family GNSS Receiver Device Tree Bindings
> +
> +maintainers:
> +  - Johan Hovold <johan@kernel.org>
> +  - Linus Walleij <linus.walleij@linaro.org>
> +
> +description:
> +  Broadcom GPS chips can be used over the UART or I2C bus. The UART
> +  bus requires CTS/RTS support. The number of the capsule is more
> +  elaborate than the compatibles BCM4751 may be printed
> +  BCM4751IFBG for example.
> +
> +allOf:
> +  - $ref: gnss-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm4751
> +      - brcm,bcm4752
> +      - brcm,bcm4753
> +
> +  reg:
> +    description:
> +      The I2C Address, not required on UART buses.
> +
> +  vdd-auxin-supply:
> +    description:
> +      Main voltage supply, pin name VDD_AUXIN, typically connected
> +      directly to a battery such as LiIon 3.8V battery or a 2.6V supply.
> +
> +  vddio-supply:
> +    description:
> +      IO voltage supply, pin name VDDIO, typically 1.8V
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: An optional active low reset line, should be flagged with
> +      GPIO_ACTIVE_LOW.
> +
> +  enable-gpios:
> +    description: Enable GPIO line, connected to pins named REGPU or NSTANDBY.
> +      If the line is active low such as NSTANDBY, it should be tagged
> +      GPIO_ACTIVE_LOW.
> +
> +required:
> +  - compatible
> +  - enable-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    serial {
> +        gnss {
> +            compatible = "brcm,bcm4751";
> +            vdd-auxin-supply = <&vbat>;
> +            reset-gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
> +            enable-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> +            current-speed = <38400>;
> +        };
> +    };
> -- 
> 2.35.1
> 
>