Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 21 Apr 2022 10:37:59 -0700
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Miroslav Benes <mbenes@suse.cz>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v3] scripts: Create objdump-func helper script
Message-ID: <20220421173759.ijvytapqhoqpt22n@treble>
References: <4d3ab1f17230f0188698cfbc7ba08696fe1abfe9.1650474927.git.jpoimboe@redhat.com>
 <20220421085244.GL2731@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220421085244.GL2731@worktop.programming.kicks-ass.net>
Precedence: bulk

On Thu, Apr 21, 2022 at 10:52:44AM +0200, Peter Zijlstra wrote:
> On Wed, Apr 20, 2022 at 10:16:36AM -0700, Josh Poimboeuf wrote:
> 
> > +${OBJDUMP} -wdr $OBJ | gawk -M -v f=$FUNC '/^$/ { P=0; } $0 ~ "<" f ">:" { P=1; O=strtonum("0x" $1); } { if (P) { o=strtonum("0x" $1); printf("%04x ", o-O); print $0; } }'
> 
> Two noteworthy changes:
> 
>  - $@ went missing, I've occasionally abused that to add extra argument
>    to objdump.

Just to clarify, you'd add the extra arg at the end like this, right?

  objdump-func <file> <func> -Mintel

>  - you removed the glob after FUNC, I had that so that .cold and
>    .constprop etc.. variants of the function also show up.

Sure, I'll match ".whatever" if there's a period, but not other
substring matches, e.g. "put_page" shouldn't match "put_pages_list".

  {OBJDUMP} -wdr $@ $OBJ | gawk -M -v f=$FUNC '/^$/ { P=0; } $0 ~ "<" f "(\\..*)?>:" { P=1; O=strtonum("0x" $1); } { if (P) { o=strtonum("0x" $1); printf("%04x ", o-O); print $0; } }'


-- 
Josh