Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Zhang, Tianfei" <tianfei.zhang@intel.com>
To:     "Xu, Yilun" <yilun.xu@intel.com>
CC:     "Wu, Hao" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: RE: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Topic: [PATCH v2] uio: dfl: add HSSI feature id
Thread-Index: AQHYTjZdVn4DreM1yUm1T9RcZPeV3qzypXkAgARHneA=
Date:   Tue, 19 Apr 2022 08:17:34 +0000
Message-ID: <BN9PR11MB5483EFD16305C1440107DB0EE3F29@BN9PR11MB5483.namprd11.prod.outlook.com>
References: <20220412062353.53984-1-tianfei.zhang@intel.com>
 <20220416144752.GA301222@yilunxu-OptiPlex-7050>
In-Reply-To: <20220416144752.GA301222@yilunxu-OptiPlex-7050>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.401.20
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?59qiO1Wx//dtNQBhIvE7KvLOKrkelHvC4CF843rCGqlLVeVxjYcAgCQ8U6F7?=
 =?us-ascii?Q?qUUrl935PuYuSHHC4ww6nmwaHSlxAGq/wkdehBtT8Y1oUb2j2kk/sNponZyg?=
 =?us-ascii?Q?CY1OgcX00/Pn5uC8hwlCAo7aByRsuxqJCDx6MyACjW1i4NfO6cb4rtQ6q0nC?=
 =?us-ascii?Q?iVoYJ7Osx3l6bf0s7kFlbbARTac4zQ7ewBhz3K8EEdSLiQc9GZbjo4swk6qc?=
 =?us-ascii?Q?UkjsDZm7zPUx/Pm9sIaoPJeeiBgFCDD6Xd7QtDvO4TmNaF8ZVMeK82hdoKeC?=
 =?us-ascii?Q?T7+chh8/Xrhv9403fy2eAPSSMmrigS3MK0lV71kH+MobDzY4oQxhtxbHtox8?=
 =?us-ascii?Q?ebaxC/TdaqTtj5JXEnuhg9oTG2ZIt5exJ3qz3lprvw4eQI0d+B46IBguj/M4?=
 =?us-ascii?Q?0r2WdYEFmhcV1eejlUdyNwKkWr0wOD2bUaOgRVoOToLR5mdsT1rSU8IUWqNz?=
 =?us-ascii?Q?95wm3+pyphMmvLPjZbG/ssHjIU9NKBtZltfx42BuyKppANFKdx7kY/KibrA8?=
 =?us-ascii?Q?l79cxojly1bnf8atkz+FlH0f+o6UJDN233/54LeF+Zh00W+U3FmrQfPXSK+H?=
 =?us-ascii?Q?VehUiV4w+TC+JUvlwkW6eymIo4VWj+pWryeMjvmA/5OmQgb9pB3ZKK0neAOC?=
 =?us-ascii?Q?BmQn8OPMSUSmPwoJDypXs/QINmahUjzp6ml5guyXqrNvqFeIqqhNWSMKSRLz?=
 =?us-ascii?Q?EPgrHvDHZ1Tc5FYHWRSj4mRFS6hNXMrE+O5SSv+rqvzkGz0vqf0Sd0jbRJJS?=
 =?us-ascii?Q?2mzL2N0cwzmnl1f0K/6nG1DU6Ep8jamZ7ce7nBOVlPElb1lWuaxNvs8VYZR1?=
 =?us-ascii?Q?2oVrrfTMo+chdyH/1AWvRFbwROy54LxABc7nwa6tRMgTvrtVW1uU8Hv2zQ3r?=
 =?us-ascii?Q?U31bMqejudWIyVBB0ebcFdREL+18S7GAAOYEgGb8KMPm8ezvf28TCagBjhIo?=
 =?us-ascii?Q?BXiEHSIpJQGYUSfZTEOvbapukTv7D2bYp2kv3ktCBFmD2pQmV7UC6jZPOjPJ?=
 =?us-ascii?Q?9fYsTnzPsN0D3Pya2e/kW2hQd5P0XNV9WYgVxN5aQCmJnjopTWrEk9Q/7mo6?=
 =?us-ascii?Q?bTIB9n6jglcdvYgM1SfOOyxkUx3YyytVwjgrH2Y22LVlD5gM3jd1+z4XISuj?=
 =?us-ascii?Q?LCylRkTCkU0qewbCHZyhnILYnANm57nnzwj2TQHnIEn65dbZIqq1vfukEpWx?=
 =?us-ascii?Q?pBcYbHJu93Tl+jxJaRpDIgBMYsB+VWayBWQnLXKjPPbAq4cEnT7eYXEHwQfA?=
 =?us-ascii?Q?/A8fUCgqfP6eFipdDHL1BIkgxwQXq0YJpiB2YZZZCmbOlPswqd5skqdYR6+W?=
 =?us-ascii?Q?64nRFMrv82Ulo7d2hDCme/6ekSLlYZrdujVPqrZLTxiykdGBbebzWV+4M0i6?=
 =?us-ascii?Q?NmFivPbfkDTOSLpTod6o5CPx9h2Q8fegRybV/Tye6D0LqRIzUbyW7Px4Ki9p?=
 =?us-ascii?Q?5LsKnreRWKpXXOl0j4PJ/sNxbBYIc37/0s8MdRyVjDvJQFMQgWej4EPRRs3l?=
 =?us-ascii?Q?JG9KLD6Lgb7IZH4txnRgyJ8BgBMjRfGmlmjo3PKQ2ILyw9IEYa7PStFlcDoC?=
 =?us-ascii?Q?cN56nPWou18lA0jtO0yCsCzJu8k0gHPqQ+EWo0qKlQ51oVLbrhhPW6r7AEfT?=
 =?us-ascii?Q?g3C3p291JzBDIs/UZxRCkzy6Kip2sYNh4eQmexOtJYGpn0zd2CEOnspuyhLR?=
 =?us-ascii?Q?D2p+dPuJ2CsByvm1UlWRWCro6nyJNfdzNGY+KvO8/7pbXFq5g1+WRpBpVhb6?=
 =?us-ascii?Q?1sCbUKEdfw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bce8e777-7af4-4b9e-11e4-08da21dd0ec4
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2022 08:17:34.4628
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BaF6jyMI5RYDW8GxmN90OE5/j8R0oGgPuSGFQ5r3SdhFANRc+vj+2jJ6Me7yIgs5GCAXHLYB4713kC3WyMIFcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3181
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Xu, Yilun <yilun.xu@intel.com>
> Sent: Saturday, April 16, 2022 10:48 PM
> To: Zhang, Tianfei <tianfei.zhang@intel.com>
> Cc: Wu, Hao <hao.wu@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> fpga@vger.kernel.org; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Subject: Re: [PATCH v2] uio: dfl: add HSSI feature id
>=20
> On Tue, Apr 12, 2022 at 02:23:53AM -0400, Tianfei Zhang wrote:
> > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >
> > Add the feature id of the OFS HSSI (High Speed Serial Interface)
> > subsystem to table of ids supported by the uio_dfl driver. HSSI
> > subsystem consists of harden/soft Ethernet MAC to support various
> > ethernet usages and PCS/FEC/PMA direct modes for non-ethernet usages.
> >
> > We leverage the uio_dfl driver to access the HSSI subsystem on user
> > space, because the HSSI subsystem was designed for specific purposes
> > and does
>=20
> Could you explain what's the main difference between this MAC and other
> MACs, which prevents it from fitting into net kernel subsystem?

This MAC in FPGA has not implemented the full functional for PHY driver, we=
 use uio_dfl
driver for faster verification and product prototype when we reload a new f=
pga image. The
major work for driver include setting the loopback mode for MAC and getting=
 the MAC statics.=20

>=20
> For FME_FEATURE_ID_ETH_GROUP, it is not designed as the full functional
> ethernet controller. It is specially developed for the Intel N3000 NIC.
> Since it is an FPGA based card, it is designed for the users to runtime r=
eload part
> of the MAC layer logic developed by themselves, while the ETH GROUP is
> another part of the MAC which is not expected to be reloaded by customers=
, but
> it provides some configurations for software to work with the user logic.
>=20
> And what's the difference for the FME_FEATURE_ID_OFS_HSSI?

I think ETH_GROUP is designed for N3000 NIC card, and the HSSI is a new des=
ign for N6000 NIC card.

>=20
> Thanks,
> Yilun
>=20
> > not fit into the standard MAC and net kernel subsystems.
> >
> > The Feature ID table of DFL can be found:
> > https://github.com/OPAE/dfl-feature-id
> >
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > ---
> > v2: add HSSI introduction and the git repo of Feature ID table.
> > ---
> >  drivers/uio/uio_dfl.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > --- a/drivers/uio/uio_dfl.c
> > +++ b/drivers/uio/uio_dfl.c
> > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > }
> >
> >  #define FME_FEATURE_ID_ETH_GROUP	0x10
> > +#define FME_FEATURE_ID_OFS_HSSI		0x15
> >
> >  static const struct dfl_device_id uio_dfl_ids[] =3D {
> >  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > +	{ FME_ID, FME_FEATURE_ID_OFS_HSSI },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> > --
> > 2.26.2