Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <f8d78967-8842-57de-9464-4e281de2e7d7@gmail.com>
Date:   Tue, 19 Apr 2022 11:33:48 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v1] soc: bcm: Check for NULL return of devm_kzalloc()
Content-Language: en-US
To:     QintaoShen <unSimple1993@163.com>, f.fainelli@gmail.com
Cc:     bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1648110940-4684-1-git-send-email-unSimple1993@163.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <1648110940-4684-1-git-send-email-unSimple1993@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/24/2022 1:35 AM, QintaoShen wrote:
> As the potential failuer of allocation, devm_kzalloc() may return NULL.
> Then the 'pd->pmb' and the follow lines of code may bring null pointer dereference.
> 
> Therefore, it is better to check the return value of devm_kzalloc() to avoid this confusion.
> 
> Signed-off-by: QintaoShen <unSimple1993@163.com>

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, 
thanks!

I modified your patch to have a Fixes: tag as replied, and follow 
Sergey's style recommendation.
-- 
Florian