Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <3a48ae9b-b8d9-138e-ec19-3512164bfc80@foss.st.com>
Date:   Fri, 22 Apr 2022 15:15:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH RESEND v3 12/13] ARM: dts: stm32: enable optee firmware
 and SCMI support on STM32MP13
Content-Language: en-US
To:     Alexandre TORGUE <alexandre.torgue@foss.st.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>
CC:     <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20220316131000.9874-1-gabriel.fernandez@foss.st.com>
 <20220316131000.9874-13-gabriel.fernandez@foss.st.com>
 <31f5d4af-5a4f-e683-c50e-d59b63135a99@foss.st.com>
From:   Gabriel FERNANDEZ <gabriel.fernandez@foss.st.com>
In-Reply-To: <31f5d4af-5a4f-e683-c50e-d59b63135a99@foss.st.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/21/22 17:23, Alexandre TORGUE wrote:
> Hi Gabriel
>
> On 3/16/22 14:09, gabriel.fernandez@foss.st.com wrote:
>> From: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>>
>> Enable optee and SCMI clocks support.
>>
>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>> ---
>>   arch/arm/boot/dts/stm32mp131.dtsi | 37 +++++++++++++++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp131.dtsi 
>> b/arch/arm/boot/dts/stm32mp131.dtsi
>> index 262de4eeb4ed..78eac53224d4 100644
>> --- a/arch/arm/boot/dts/stm32mp131.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp131.dtsi
>> @@ -27,6 +27,43 @@ arm-pmu {
>>           interrupt-parent = <&intc>;
>>       };
>>   +    scmi_sram: sram@2ffff000 {
>> +        compatible = "mmio-sram";
>> +        reg = <0x2ffff000 0x1000>;
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +        ranges = <0 0x2ffff000 0x1000>;
>> +
>> +        scmi_shm: scmi_shm@0 {
>
> rename to scmi-sram@0 to match with yaml description

ok


>
>> +            compatible = "arm,scmi-shmem";
>> +            reg = <0 0x80>;
>> +        };
>> +    };
>
> Can you move this sram node in Soc{ please?

ok

Thank's Alex


>
>> +
>> +    firmware {
>> +        optee {
>> +            method = "smc";
>> +            compatible = "linaro,optee-tz";
>> +        };
>> +
>> +        scmi: scmi {
>> +            compatible = "linaro,scmi-optee";
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +            linaro,optee-channel-id = <0>;
>> +            shmem = <&scmi_shm>;
>> +
>> +            scmi_clk: protocol@14 {
>> +                reg = <0x14>;
>> +                #clock-cells = <1>;
>> +            };
>> +
>> +            scmi_reset: protocol@16 {
>> +                reg = <0x16>;
>> +                #reset-cells = <1>;
>> +            };
>> +        };
>> +    };
>>       clocks {
>>           clk_axi: clk-axi {
>>               #clock-cells = <0>;
>