Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966937AbXEGVuO (ORCPT ); Mon, 7 May 2007 17:50:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966716AbXEGVuJ (ORCPT ); Mon, 7 May 2007 17:50:09 -0400 Received: from an-out-0708.google.com ([209.85.132.249]:21212 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966912AbXEGVuH (ORCPT ); Mon, 7 May 2007 17:50:07 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=WAxQbtJ+rTom2hPWeWLP/SOcvprxOc1r5zFRWSwa4TTqHrmVhATy5yCeytHmtQKsbisaUtn2kWkI7Jpcp+c1GL65HySZn38MiVrijA1CLeRKowSitUcA9lBi13M4L/JsKA/xzq1rhUI42eInWUjwIt2u2LPKUK0G4r11RPxFcTU= Message-ID: <463F9EFF.1040705@gmail.com> Date: Tue, 08 May 2007 01:49:51 +0400 From: Manu Abraham User-Agent: Thunderbird 1.5.0.10 (X11/20070306) MIME-Version: 1.0 To: Michael Krufky CC: Mauro Carvalho Chehab , linux-dvb@linuxtv.org, linux-kernel@vger.kernel.org Subject: Re: [linux-dvb] DST/BT878 module customization (.. was: Critical points about ...) References: <46389278.1070208@gmail.com> <20070502155125.280320@gmx.net> <4638C046.1020005@gmail.com> <20070503112013.272380@gmx.net> <4639F554.1040505@gmail.com> <20070503153129.268110@gmx.net> <463A0462.5070106@gmail.com> <463A0B36.5080204@gmail.com> <1178215045.12651.124.camel@localhost> <463A31EE.20907@gmail.com> <1178388401.12541.115.camel@localhost> <463CD106.3000706@gmail.com> <1178571269.18383.296.camel@localhost> <463F9941.1060303@gmail.com> <463F9B4F.7020708@linuxtv.org> In-Reply-To: <463F9B4F.7020708@linuxtv.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2062 Lines: 64 Michael Krufky wrote: > Manu Abraham wrote: >> Mauro Carvalho Chehab wrote: >>> Hi Manu, >>> >>>> From my side, quite some time has been put forward to write that mail. >>>> Inspite of that if you feel that you do have to go your own way, then >>>> it is completely upto you. I would say: do as you feel in such a case. >>> The point is that those issues are pending for a long time, and they >>> should be solved, especially the module removal issue (*) >>> >>> If you are so afraid about applying those changes, maybe the better is >>> to apply those patches at v4l-dvb tree and at -mm, asking people to >>> test. >>> >>> We may hold their commit on kernel mainstream until the next kernel >>> release, if nobody complains about, or otherwise revert the changes, if >>> they proofed to cause troubles at dst and/or dvb-bt8xx. >>> >>> Also, you (or others) may write another approach keeping the fixes with >>> an strategy more adequate for dst. >>> >>> Do you agree with this way? >> NACK >> >>> -- >>> Cheers, >>> Mauro >>> >>> (*) Currently, dst can be removed only with "rmmod -f", due to a wrong >>> usage count. With Trent's patches, this were fixed. >> http://article.gmane.org/gmane.linux.drivers.dvb/27792/match=re+linux+dvb+unable+rmmod+dst+bt8xx > > Just to make things clear, Manu, Are you telling us that the patch in the above > link addresses the use count bug? > Yes > If that is the case, are you suggesting that that patch be applied to the > repository instead of Trent's changesets? > Yes > Moreso, if that is the case, then the patch in the above link lacks a > sign-off... We need to apply SOMETHING to fix this problem, and you know the > rules... > Signed-off-by: Manu Abraham > What should be done to fix the use count bug? > It does fix, AFAIR Regards, Manu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/