Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp938102pxb; Fri, 22 Apr 2022 14:50:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLVqnN4+4EZ8gRUnNtdkeoFAgOQG9R9Rw/hWWL8/W1t3NMb1rPjj3+DRlsEJI+Yg67/qCm X-Received: by 2002:a17:902:820f:b0:158:c308:d4c5 with SMTP id x15-20020a170902820f00b00158c308d4c5mr6281993pln.155.1650664241961; Fri, 22 Apr 2022 14:50:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650664241; cv=none; d=google.com; s=arc-20160816; b=Z0SEi2YuZO9Os56unCpzXp+kHp/YXEcHKUwuzDY6TSMM28g4wV8HIfjmLsUhZvu+nI 6nISRUnClbUPOvJ5NTrq1gr1AJQhy1LvSGRNCLgvpyVKno7YQuUr4bwrvzUUfFQkIB9L MYwgc6VtI8/cNGKNkjihaCqF3r0rjvECaHTcwtAoBTHu8cO3eElai9S5KjHgclDedljG v9KMRMw5QqYF8zeYpYlXndEyzOourFm4r8CRChnikfXlrXQYIJ3zN91nzIllHklAdRMX aB/bWlf8WgMq/8r3jA3gu4m/LqlTqtaZf3wpLieKtpgBFeNC0NVpkIC5XFu/4I9/fEN7 I2ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=6rqH8Gx2RVwMYf+TS8MXycqGm3xyri8xQNCtBGYmGfw=; b=cLK/B3Wo2o8B/9q/eTaWxryYNOm8Rr+lHzX1z6alFEbdJVL9bKS7JWKMn7oCeTjG1d CFmAVd+66BM27I9b7ROU1jGroHOq0Ipo8FRV3bp/8AwZyrAUyL2GeWuB1J0Xc5aPr3eC FMsi6M1ePQAOtNkwS2FfYoHbN2bNBq2IlyZF/TTLWx7CKr8Dm9hBIlNDIcuIAoRpV35l X2MaHHITiLFjzwGJSKTnTDFsdesFE7FyUGUK+PLSw+lO3TuuhfE/bbFSimHF/2GYG4EJ rtERDEccwiX8X6/LtX7kDPbBt5VPe0zU0MgSR8+hOUnWPdnVFkOyfhzuJ5GKQiFwhhun vsIw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o12-20020a63a80c000000b003a97e8f54c2si9982014pgf.244.2022.04.22.14.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 14:50:41 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1F8243459FE; Fri, 22 Apr 2022 12:58:33 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389812AbiDUPDy (ORCPT + 99 others); Thu, 21 Apr 2022 11:03:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1389886AbiDUPDq (ORCPT ); Thu, 21 Apr 2022 11:03:46 -0400 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DBA34704D; Thu, 21 Apr 2022 08:00:46 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R591e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VAgCgRW_1650553238; Received: from 192.168.31.65(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VAgCgRW_1650553238) by smtp.aliyun-inc.com(127.0.0.1); Thu, 21 Apr 2022 23:00:41 +0800 Message-ID: <9b99e246-fbdf-2d78-7773-bf4481a8e122@linux.alibaba.com> Date: Thu, 21 Apr 2022 23:00:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v9 05/21] cachefiles: implement on-demand read Content-Language: en-US To: David Howells Cc: linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com, zhangjiachen.jaycee@bytedance.com References: <20220415123614.54024-6-jefflexu@linux.alibaba.com> <20220415123614.54024-1-jefflexu@linux.alibaba.com> <1445520.1650550446@warthog.procyon.org.uk> From: JeffleXu In-Reply-To: <1445520.1650550446@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/22 10:14 PM, David Howells wrote: > Jeffle Xu wrote: > >> A new NETFS_SREQ_ONDEMAND flag is introduced to indicate that on-demand >> read should be done when a cache miss encountered. > > That may conflict with changes I'm making - but it's just a matter of flag > renumbering. > >> +#define CACHEFILES_IOC_CREAD _IOW(0x98, 1, int) > > I wonder if CACHEFILES_IOC_READ_COMPLETE would be a better name, Okay, it sounds more readable. Thanks. but apart > from that: > > Acked-by: David Howells -- Thanks, Jeffle