Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 07:58:38 +0200
Message-ID: <s5h35i5veup.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Miles Chen <miles.chen@mediatek.com>
Cc:     <alsa-devel@alsa-project.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
        <perex@perex.cz>, <rdunlap@infradead.org>, <tiwai@suse.com>
Subject: Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used
In-Reply-To: <20220422025312.7718-1-miles.chen@mediatek.com>
References: <s5ha6cm4xy2.wl-tiwai@suse.de>
        <20220422025312.7718-1-miles.chen@mediatek.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 22 Apr 2022 04:53:12 +0200,
Miles Chen wrote:
> 
> Hi Taksshi,
> 
> >> We observed: 'dmasound_setup' defined but not used error with
> >> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
> >> 
> >> Fix it by adding __maybe_unused to dmasound_setup.
> >> 
> >> Error(s):
> >> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
> >> 
> >> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
> >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> >> Cc: Takashi Iwai <tiwai@suse.com>
> >
> >Thanks, applied.
> 
> This patch is needed in 5.18-rc3 [1] too, should I submit another patch or
> you can pick it to the mainstream?

It's included in the branch for the next PR to 5.18.


thanks,

Takashi