Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 12:11:32 +0200
From:   Jiri Olsa <olsajiri@gmail.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>,
        Song Liu <songliubraving@fb.com>, Hao Luo <haoluo@google.com>,
        bpf@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Blake Jones <blakejones@google.com>
Subject: Re: [RFC 0/4] perf record: Implement off-cpu profiling with BPF (v1)
Message-ID: <YmJ/VAt2yblZC9HN@krava>
References: <20220422053401.208207-1-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220422053401.208207-1-namhyung@kernel.org>
Precedence: bulk

On Thu, Apr 21, 2022 at 10:33:57PM -0700, Namhyung Kim wrote:

SNIP

> The perf bench sched messaging created 400 processes to send/receive
> messages through unix sockets.  It spent a large portion of cpu cycles
> for audit filter and read/copy the messages while most of the
> offcpu-time was in read and write calls.
> 
> You can get the code from 'perf/offcpu-v1' branch in my tree at
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> Enjoy! :)

  CC      builtin-record.o
builtin-record.c:52:10: fatal error: util/off_cpu.h: No such file or directory
   52 | #include "util/off_cpu.h"

forgot to add util/off_cpu.h ?

jirka

> 
> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (4):
>   perf report: Do not extend sample type of bpf-output event
>   perf record: Enable off-cpu analysis with BPF
>   perf record: Implement basic filtering for off-cpu
>   perf record: Handle argument change in sched_switch
> 
>  tools/perf/Makefile.perf               |   1 +
>  tools/perf/builtin-record.c            |  21 ++
>  tools/perf/util/Build                  |   1 +
>  tools/perf/util/bpf_off_cpu.c          | 301 +++++++++++++++++++++++++
>  tools/perf/util/bpf_skel/off_cpu.bpf.c | 214 ++++++++++++++++++
>  tools/perf/util/evsel.c                |   4 +-
>  6 files changed, 540 insertions(+), 2 deletions(-)
>  create mode 100644 tools/perf/util/bpf_off_cpu.c
>  create mode 100644 tools/perf/util/bpf_skel/off_cpu.bpf.c
> 
> 
> base-commit: 41204da4c16071be9090940b18f566832d46becc
> -- 
> 2.36.0.rc2.479.g8af0fa9b8e-goog
>