Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp945293pxb; Fri, 22 Apr 2022 15:02:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOK3OoSigY7G5gxbJp0LZaTVy8W5gJSbvJDwwHT7CzFx2EcBjtCV7tPwTfkcLlpBWLXtVN X-Received: by 2002:a63:4722:0:b0:3a9:fd43:fce9 with SMTP id u34-20020a634722000000b003a9fd43fce9mr5651063pga.620.1650664953260; Fri, 22 Apr 2022 15:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650664953; cv=none; d=google.com; s=arc-20160816; b=WxGvJul86LOsVcDXWQkS6+JpWeSVioeG/zyQkdyNPTRhm04aprOhcf3lFjieMHfbkt z4kNOlXJ22w4Q51PzGgD5QdA4HlAiW8QsXWoKzhYy0EcUMxFGZdVEqQXlev8FNlpILJk peh/Z5CjAcrLZ6ySQv58rkVT3m4fPoQb9Te9n/fBchpnA6xG5WX0E1O851RWng2XNlZK 6xnybxuQPE7hR/p8XzLwzJgJBtjoWrTF2Edgyx8ywkrDbRBfdIArloNl3vdkee7Bl9nX SFSCQwe6JSc3c9BFH6RFz4TcUBl7tQ0zDC3sEyf9Txdf+IrR51oUucwShv422E/MeKxe 9ilQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=52B8PO4dJpBFpgQzTz5+exc2Y/hsqZBwLBqvHWqmCaw=; b=M4YOWw2gGiCkSroYx+tfVe9QC6v//Gdiq4M8u8kiZZH8RJIM0u3K8j9Cy+FB2vy06j M5OLlT8V0yl0zHhbrIJ41GT29zUSz6vOa3RCG+cblzDWSFMFZSb3t8EQyUSMjXxi2N9G DT5GirtsLjSEgcH2tICgV+X1mVk8Si5LwOPYrktQKpVxIH2PcKQDGRLBK3tqsG8dM4oa Zlb0XYdx7ftp16znFH3EsLWnXGdFdDgIbApdQP7DTbBPAHcMwZcvBJjGqKjVSBX0gwXc UwvNs6yF+wRjkBhvY92hOExJp9brVEW2k+LqsZ0llocUTdTDGO5g/EUybZEqFUni9rx1 Xmqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K9hJ8Keg; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u6-20020a170902bf4600b001560b636be5si8592846pls.189.2022.04.22.15.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 15:02:33 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K9hJ8Keg; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3EEE4257C9B; Fri, 22 Apr 2022 13:10:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444809AbiDVH3v (ORCPT + 99 others); Fri, 22 Apr 2022 03:29:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241347AbiDVH3s (ORCPT ); Fri, 22 Apr 2022 03:29:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA4A450456; Fri, 22 Apr 2022 00:26:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B0CBB82A89; Fri, 22 Apr 2022 07:26:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB6FEC385A0; Fri, 22 Apr 2022 07:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650612413; bh=8DAigWYGNyU0r2gEJ6nTrSLjjq33DLSFxok7TZ9V1JQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K9hJ8KegjOYNQHdCNCs8ADQuOalbo8HDW9+EGePILQtDgDVzMQQkL7z2pkFEEc/eC xYuSFRf/5VVTxn/q8WiNlygCXOzsB5+nYL0if57asM+hkioxTrVtNMpghDxHM64KpM mMfgcYcDwYanlEciwfsaREs0zNQcNutTnrEyk4gbqXYMKN/KPMAZkd/Bf46I+xcoF9 Iu9+NM8ZLhZGll9F6qM/y89nWE9DQaCbV1ZtCZqx5YZeyvpptS6WpNII4iuZ/PsZK1 yG0PnaxMR87ondqP4Q7v0vTaMT6UUmKA5bDyVNLRkv6Ko5D5U0mSEvv4tSbiluZNAR Dh4IvK0epIcRQ== Date: Fri, 22 Apr 2022 12:56:49 +0530 From: Vinod Koul To: Yunbo Yu Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dmaengine: mv_xor_v2 : Move spin_lock_bh() to spin_lock() Message-ID: References: <20220420122754.148359-1-yuyunbo519@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220420122754.148359-1-yuyunbo519@gmail.com> X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-04-22, 20:27, Yunbo Yu wrote: > It is unnecessary to call spin_lock_bh() for that you are already > in a tasklet. Applied, thanks -- ~Vinod