Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Radhey Shyam Pandey <radheys@xilinx.com>
To:     Shubhrajyoti Datta <shubhraj@xilinx.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
CC:     git <git@xilinx.com>, Michal Simek <michals@xilinx.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Shubhrajyoti Datta <shubhraj@xilinx.com>
Subject: RE: [PATCH] gpio: xilinx: Trivial patch
Thread-Topic: [PATCH] gpio: xilinx: Trivial patch
Thread-Index: AQHYJ+5SXJDI9ULDFk2U38/oBwuucqz8Ps4A
Date:   Fri, 22 Apr 2022 12:56:52 +0000
Message-ID: <SA1PR02MB856096D050BE00410EA3A0E2C7F79@SA1PR02MB8560.namprd02.prod.outlook.com>
References: <20220222131548.17513-1-shubhrajyoti.datta@xilinx.com>
In-Reply-To: <20220222131548.17513-1-shubhrajyoti.datta@xilinx.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A9GT/aKIcfu8/vNu67Z47Gv6CGG9M8ErxoDQEyhmDh7lNijrtZnP7dwNLAL2?=
 =?us-ascii?Q?9/7kxxwytSqi7PqkeBJz9lpQA0wQqdqk3+9AoAzCNsWxd7GMFWGGHsaQ2pgG?=
 =?us-ascii?Q?Rt1FaTMAwHlyPOWCr7yjONexsiZHSjK3naAYBOdXYXN/KnAuchPiEiSay022?=
 =?us-ascii?Q?Oj3JNfDFW9ojr0fA6WP2zg9efQVE68ZT5VzqFaeISisBidiwN5H4ofNtEfWL?=
 =?us-ascii?Q?xwMkbOPWswrBKU4+4WTOjdDg5e0+XJOwJhNCMLuqj7LEi9+315BjgxfPHCbO?=
 =?us-ascii?Q?vuLbobfU8QFwayaJVGonTnhrHqUXJlxNNCdy5VahoFzCj83IQf5gqlCgk7SH?=
 =?us-ascii?Q?7w/ea20S0iEDOhZlBC6XVoCSSY7MYIUK2+uZn2NNM90C/Lz272Y/JAqiwTkz?=
 =?us-ascii?Q?J8g9zpgIFoVJ+DAjv4NeBh/y+/A+kfGOCMshWd7Vog5k/W6km+sJQa7DkCzt?=
 =?us-ascii?Q?6nCw1qTooY2k0PKde+eAI+gkVrFvIs19irJncmyMGTQ8c4NTBlyH6W53G5gf?=
 =?us-ascii?Q?WScQoWeSwh7xsBrUJ7E2ayp2en+J5I+w8o2x0VieDfWEsKC3FrcT4j9sR88t?=
 =?us-ascii?Q?9FVu2ttUAN+xiRKe4/l7CHPKIzBMpDQGTXbN13LidGEisgKVLzVm8KfG7kHf?=
 =?us-ascii?Q?5FTPB9u51lUuPh5Va57GqExQWkIrv8HEYngqCF5DmbT8+dRZ7Ez7LV/onp4C?=
 =?us-ascii?Q?uw7Gcmr6hivGLGBFdoRISwEK2uxrA1Jl0G0D2YrREoHX4b2NAc4a05kYHMyf?=
 =?us-ascii?Q?QcNcQo8bHpDzcUssuV9zXoZ2JWUr4Mx/fx/spJW+1dmosSDkyxmR4O0OtWAE?=
 =?us-ascii?Q?Ri1l7+czHjuQ1M430lxGLMjvB8zayi+mHiNJ64wGhmE1VAcRKKU/ao6C+FLy?=
 =?us-ascii?Q?+UVGp69/pMiNxo1/eeO4pL89rNioZD1oj9mMsEuCb/ViAslial+KJg8RNDWA?=
 =?us-ascii?Q?AQiKxQAG7fJoOsTNsX5/wZrxNcI95NIXc2TbSp/3qmhCpWL3ovgL7MDElBnG?=
 =?us-ascii?Q?Hc1segpeiR5IEJb4GYtzHMof3pQ4dmfBPh3NWzWotk/eGr9WyldJ0k1QVJwd?=
 =?us-ascii?Q?61mU+qETK4YY3pJ+c6yPEkIsHHCSkZyUjWYcJzfdMxbZTHd3YTZnkRZYyWvR?=
 =?us-ascii?Q?+b6tOcSLJzS6YMDzY+dL5Kh0EwlMbGtynHALtiprlggB3ABEG0K/JYoMum+d?=
 =?us-ascii?Q?+ISy97yihgjbdjz/lMLQSTANG+dDdyn5YsitzAkv7qiNQRSpcMjYHTBPgs4g?=
 =?us-ascii?Q?mKCaASTJv1eqmEAWdL+IAy75/N0tX9kAPPqBLB96I4F5uo/fxrAk9OKhInCi?=
 =?us-ascii?Q?M4eqCBMJ2kbWWkrByvuD4GHWBSNw7zTc5dXr540lsa/x9KkjWhjrRkxkdRxQ?=
 =?us-ascii?Q?laVd5F5Cft1UnQXblUWaM/PPARmyzNLBrwWPbfHQpVc/3wvspeSjpvgPxJ5V?=
 =?us-ascii?Q?8AbXzklite1xloAZou+ruCaaZG4wjoHhsZtDZis3Cc4QkTNwmm7ev+s9ZPRh?=
 =?us-ascii?Q?H4UsTrHbPvPbWO7M2L0vrMy2dXZoj31Maj0e6yX+NeRzWxL27DpQN6s26iqE?=
 =?us-ascii?Q?Wmsr1IiCuxuB+W7XrNdDAmbbEHInFMNAlG7Kjqt70heiU0mcmjkC5IxJiDnc?=
 =?us-ascii?Q?7KbX/xjJrkhOkQoPU0l5VFI8NiLaprEhYRUM9RuDv1TXkN+pr0ID2Mqe+0h2?=
 =?us-ascii?Q?/pYT+7pZUOduVKeBTGZ+zFUQCYuOYHz5xsdtKBkH3L3+VSnxH3nn6eU1HTrI?=
 =?us-ascii?Q?aEKpyjXPQw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR02MB8560.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38bc9999-d29d-44b4-2502-08da245f92b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 12:56:52.7781
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 96vXn7MPt4bVKln2y+aXsUcaRF5NDbN4PyVXcMWGImNvVsnCEIYlTyMtpbGJOcH47CEZvH9QPZjYSzXcTJF8Ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5862
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Sent: Tuesday, February 22, 2022 6:46 PM
> To: linux-gpio@vger.kernel.org
> Cc: git <git@xilinx.com>; Michal Simek <michals@xilinx.com>; linux-
> kernel@vger.kernel.org; Shubhrajyoti Datta <shubhraj@xilinx.com>
> Subject: [PATCH] gpio: xilinx: Trivial patch

Minor nit - Better to say about the change instead of "trivial patch".
gpio: xilinx: add missing blank line after declarations

>=20
> Add a missing blank line. No functional changes.
>=20
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> +       void __iomem *addr =3D chip->regs + reg + xgpio_regoffset(chip, b=
it / 32);
> +       xgpio_set_value32(a, bit, xgpio_readreg(addr));
>=20
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> +       void __iomem *addr =3D chip->regs + reg + xgpio_regoffset(chip, b=
it / 32);
> +       xgpio_writereg(addr, xgpio_get_value32(a, bit));
>=20
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thanks!
> ---
>  drivers/gpio/gpio-xilinx.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c inde=
x
> b6d3a57e27ed..7f129e7eae78 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_inst=
ance
> *chip, int ch)  static void xgpio_read_ch(struct xgpio_instance *chip, in=
t reg,
> int bit, unsigned long *a)  {
>  	void __iomem *addr =3D chip->regs + reg + xgpio_regoffset(chip, bit /
> 32);
> +
>  	xgpio_set_value32(a, bit, xgpio_readreg(addr));  }
>=20
>  static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit=
,
> unsigned long *a)  {
>  	void __iomem *addr =3D chip->regs + reg + xgpio_regoffset(chip, bit /
> 32);
> +
>  	xgpio_writereg(addr, xgpio_get_value32(a, bit));  }
>=20
> --
> 2.17.1