Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <5512261e-085b-65fa-605b-38692769f89c@amd.com>
Date:   Thu, 21 Apr 2022 12:10:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v4 1/2] x86/mce: Check for writes ignored in MCA_STATUS
 register
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>
References: <20220214233640.70510-1-Smita.KoralahalliChannabasappa@amd.com>
 <20220214233640.70510-2-Smita.KoralahalliChannabasappa@amd.com>
 <Yk267A1MKOo2AlXQ@zn.tnic> <6cda2827-af75-589d-3e43-a287d6683e7a@amd.com>
 <Yl/PupT3bAfc4IBW@zn.tnic>
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <Yl/PupT3bAfc4IBW@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amhRZE5aYzExZ1I2UEFNL3RySHlzSEVXMnU4MGwzQUkzK1RweGpoUVcvYmlx?=
 =?utf-8?B?RXdEdWJrdFhtbjF5c28zYzlXckFxNDU3bm5wWUFndlRzSm5wKzI3SE5CbXhG?=
 =?utf-8?B?Mm5GU3FIaHNWVEtqU3ZFU21FaTIyK3ozQmdaR2VjR1hCMitGQ1RIQjVpbUts?=
 =?utf-8?B?MWpPSmF5TkNaTnBuSUxtak9leWQ1Q1lQaTFCRnc4N0RBK0ZQZW11Zlp4VnUw?=
 =?utf-8?B?MjdvMkFqdElvMWRrVit2MGU2eERLbjNieGR6SUhWTUNKU0tjaktqc0hsNVdr?=
 =?utf-8?B?endoS2R6OElzWnRtVUNHSWd2eEJSTTJpUGRPTWg4ck5yb090NWV1MUdCYllt?=
 =?utf-8?B?SXcxcTlsaUV3d1NxVDYvSG5GVmdsaFE2YVZUTFhhR1g2UHlYWSs5UkdUcmxj?=
 =?utf-8?B?R0ZFMXFkQmhYTE1xUkVCV0FlK0NvcHNRdlRMQkpDQzk3YlRzVTNmWGVHT1hk?=
 =?utf-8?B?eUoyNTY0UmUrakQ0RlpkNCs3V1lqSk1lTzA2VUtJNUlSemVHTVlWY0tZaHRS?=
 =?utf-8?B?WmlCMjMycmhoTnZKUUMrNlBhVnh0bkdYME1vWmtGdmQreStBeXozZWtoanE2?=
 =?utf-8?B?Q01wUWFSUS9ic2swQjZjVjdGZEJCMjVVRTM3aGdSbWU2Rkc5SkdRT08xYUE2?=
 =?utf-8?B?ZUh6aTAxY0QvUEJLdFRFV3FOUjBwbnBwaUgwZGl1dlJTV3VwSHVnVHF3dVpq?=
 =?utf-8?B?MHJ4T0FoMGxyakpUQjFWQ1FMOFJpMlhaaXg0dTJtOUJheUZhUkozTGFxL2Y0?=
 =?utf-8?B?OER1Qi9wL0hicHhCYUlOMXJhS2hqeVBoRys4a3FWOHJrZzNiaStFbEgwKzBJ?=
 =?utf-8?B?Uk0xdDUwTTY5cm5waGFUZXBKS3R1eHBKNC9uNURKcXRGdUw0NjNmRDBWT2s2?=
 =?utf-8?B?Z2dhUFVNdk1oSXVveW96R3BwSnVjRDBDQTBCeGJmTzBRN1dibTA3WTBjdSsx?=
 =?utf-8?B?UlpRY0ZRQ3ZQeEpwMHBoNEJHdXhVZmpBdXZGd2tVNjQyVmdqVE84ZjJQQUV0?=
 =?utf-8?B?dTMxOUhURE5zV3drMXJHaWZnUVZRM0RDUmIrQmxUUmw1aGt5dGpGWW05L0J4?=
 =?utf-8?B?VTVZZ3hRbGZyeVAybDd2SDhwKytQNlhBUlhQa1Z0SXZOZXlZNVRma1N3Zzhn?=
 =?utf-8?B?V1pSL0NMcS9CK0RPQkdTdzF1OEdFRW1ML0cybkk1QmpRVldzMzMxcFVLajRj?=
 =?utf-8?B?NGtpOWp0SFdhajhtajRCWHlUT2N1Z25WcTdxKysvM0tTYmYyQXQ1a05qOXFH?=
 =?utf-8?B?Q0ZoYkNWaWkyT2JkN0duTGpEcjA5cjVDd0FBbisrcVRhc29xRUVCb3YxVVF0?=
 =?utf-8?B?Vit5R2lVS3Fpd0dKWnd1YlZLY1BpWVFoMDBLMVlrOG85QUpqRGI1Y0NaK250?=
 =?utf-8?B?VFVmN1o0QkE5bkQySFNLTnF2K1doS3lWN21NV1hBbDQzUkxCc1ViQVgydEhi?=
 =?utf-8?B?dG1IZlhKRncyR2VnbUx6Z3NEQmFiMWYvSmxFOGVNRnVYc2x3S1JsRTNERi8z?=
 =?utf-8?B?cEVvTjBHSklRY2JpWlhIaDdFSXZtNElXYk9idFhhRDdFcVg5TzRtbUR1RS8x?=
 =?utf-8?B?bk8wcUU4ckpVN2pxdkVoYXIvc2JPQ1F6eGFqbzFlNGVBYzdqb2M4MEswTTlI?=
 =?utf-8?B?RjM3OWg0TTd4RUI5a004K1N5UWdLOVNUbjhmZWlORkltWWFzajdackNXWUFN?=
 =?utf-8?B?cU5mS1JsempockFZR3VRK1h4RlAwVlh3cXQ2RmF6eGlKb25WdnhIdWcwNzNV?=
 =?utf-8?B?Y1AzNlc1YWZLUzBpdldlMkg0MVFZOWpwSmVlRFlDcndYd3JWdjFucW9vYUxT?=
 =?utf-8?B?ZnV3Ny90cVR3Nk44MDJ0dUtqWEI4aWZUck5yaThtQjNPQ082QlNwdFIwWUV1?=
 =?utf-8?B?WWw3QkxxcFZuNkQ2YWdBa1JQeGNnR2ZLMFJReDY0YTJBZUcyN29oTTQ4alBZ?=
 =?utf-8?B?V1JlY3FYN1I4UzF3THZ0MGw0eW1nQit0VHhtS2Z0RDlRbDFabVIxbWNlZmJq?=
 =?utf-8?B?TGpIYkNmY1NOWXk2ZnFqVTEvWHZCa3ZmbjcraWhLMmRodUJyUkg1WVdDVEVE?=
 =?utf-8?B?QTBFeS9paU1ZY1BRcFpMTXBXTG1WYm1jLzQ5WjFQSWhzL2xZUUgwMHVuSzEv?=
 =?utf-8?B?TmdRZ0FIUzJHZmw2RGhteGcwWURMR204c21QYkxtQUJnZG0xSXdJVWo3elJx?=
 =?utf-8?B?bmZOYldyOWY5ZVJFazlkN3kyc3EzMzBoa0xMcVQ5N2Z4YlU0Y1ZqSkZlYUFG?=
 =?utf-8?B?dUIzZ2VHUThZNjNOQldOQVpjZHJ1bVJZQlJrOTBiaWxTRVBlTUs3SnViNDFY?=
 =?utf-8?B?ZC8rdEFTQ0VWZStVaWc5ejQzeWt0Mm9kS3F0QnQ2dGN2a1hwc0V4dz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7172998d-e79a-4e56-3f28-08da23ca8d5c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 19:10:09.0220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7Uqz84Pq7MashTJRa50iCCa8wfPMaqf8vprCxXs85ke2qSDRyRHppmT+l9WT5MlB6KNEFR9XiahfC2qC3BwaVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1588
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/20/2022 2:17 AM, Borislav Petkov wrote:
> On Mon, Apr 18, 2022 at 08:24:35PM -0700, Smita Koralahalli wrote:
>> Why are we checking this here? This flag (hw_injection_possible)
>> is set to false inside prepare_msrs() called from
>> smp_call_function_single().
>> Should this check be done after the call to smp_call_function_single()?
> Why would you do that then?
>
> Is any of the code after
>
>          if (inj_type == SW_INJ) {
>                  mce_log(m);
>                  return 0;
>          }
>
> worth running if hardware injection is not possible?

Okay I got the gist of this now. This will be mainly useful for subsequent
hardware error injections.

Also, should we move this slightly before? In inj_bank_set() after we check
for sw injection and before reading IPID value?

>
>> Also, we already have inj_desc.err which returns error code to userspace
>> when WRIG in status registers. Why is this flag needed?
> To not do unnecessary work when you *know* hardware injection won't
> work.
>
> :-)

Okay.

>
> Btw, please trim your mails when you reply, just like I did.

I'm sorry. Noted for my next replies!

Thanks,
Smita
>
> Thx.
>