Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-33-arnd@arndb.de>
 <87d0egjzxk.fsf@belgarion.home>
In-Reply-To: <87d0egjzxk.fsf@belgarion.home>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 19 Apr 2022 17:55:52 +0200
Message-ID: <CAK8P3a1VfUqBZo_CMukwsLeb4pqg2C9i5mqG1KXaK8EpLAOc8g@mail.gmail.com>
Subject: Re: [PATCH 33/46] ARM: pxa: pcmcia: move smemc configuration back to arch
To:     Robert Jarzmik <robert.jarzmik@free.fr>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dominik Brodowski <linux@dominikbrodowski.net>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Daniel Mack <daniel@zonque.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 28, 2019 at 10:58 PM Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> > -static int pxa2xx_pcmcia_set_timing(struct soc_pcmcia_socket *skt)
> > -{
> > -     unsigned long clk = clk_get_rate(skt->clk);
> > -     return pxa2xx_pcmcia_set_mcxx(skt, clk / 10000);
> That curious, because you divide here by 10^4, while in the old
> pxa2xx_pcmcia_set_mcxx() that was 10^3 ... is that a fix I don't see ?

Revisiting an older patch here: I'm fairly sure the change was my typo,
fixed it now, thanks!

      Arnd