Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp972375pxb; Fri, 22 Apr 2022 15:41:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKUZBKy11jKShVAXX/GHolsqbmUtfs70tWb5G1I+sIGYD/AHHhbT2EAxjIoZSj6AuaqpIb X-Received: by 2002:a17:902:d541:b0:15c:7ae6:123e with SMTP id z1-20020a170902d54100b0015c7ae6123emr3962231plf.132.1650667265626; Fri, 22 Apr 2022 15:41:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650667265; cv=none; d=google.com; s=arc-20160816; b=J13dXVbSkhO9Ob+o3JGW5bRTjCwj0/J5IwrpYbqb9GG/qJ1twsCWVIzGDoLd/PZi5C Vx8NZ2Hlo9tUosBIPa+42SBo8f3I0nxD14MKMHnZpfHa+3QDFPCyoOXjmqBNvwfBog14 Fi7jn9vKeesS/7RLrqSv2Ki994ARpOcSGmKRhnBLQoadGkLac1HZ0xoWsNZb69dvz2lt FTWzdTLjVkIEj4EK5HOyWqp0vA5aEwHO2i2+C10rk2BB6BcGLVOgbhWLX4e8A3yFpYux HcUyS9S7vIyEnMtrI/y6Fr0O3Td+VIMBPHCz+wN41f2HGo5qUG0xIqSktLqqcxtXe0dG Lj8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/ZsiM/JVSStGy085+VUcOInF1XyD4vqdtylPW/d5gq8=; b=XfYu96hAV2t/2NMP3PnKygEZOlsinCYmZaz3Jj72G+Y8jcBaF1VWiGhZXFL/k0t1yE OAIs4IY8wFL37OkROfSPiZgcSCCeN47HgLFe1rhzxLUd63SvTcE9/c1N5gIN4wgZ60zr RehXlm35T5nr6QU/CN4jxAkpeyMW8waFSp1tIQb+LBkz7vx5uN2SNk5lw53+hgRS5T9b CxXx35ZuipbG2LK1JYbTh//lTlzmex1Q7BwUSlbxGSVZeulgHZU2u2yHL9zw06wQSb3g nGj3m059FgiJxXOfFSXw7IracB6YB93qeble/F+632fcGft38ggPFR6gh3AmtF6wd/cL uF3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=2rPNmR8q; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o2-20020a639a02000000b003a303daed2dsi9821096pge.631.2022.04.22.15.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 15:41:05 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=2rPNmR8q; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D42F23D1BE3; Fri, 22 Apr 2022 13:29:02 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1449603AbiDVP51 (ORCPT + 99 others); Fri, 22 Apr 2022 11:57:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1449587AbiDVP5Z (ORCPT ); Fri, 22 Apr 2022 11:57:25 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92004237FD; Fri, 22 Apr 2022 08:54:31 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23MExSaS028654; Fri, 22 Apr 2022 17:54:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=selector1; bh=/ZsiM/JVSStGy085+VUcOInF1XyD4vqdtylPW/d5gq8=; b=2rPNmR8qK7iYuF8eztJY/RH/AjGxVchq46xGxrCRGIxD4AX0udT3s9e7kO63Evlap+Um 2rvZTiD5JtgwEHStlzJjTn+OUnJbdmCs+TH7rZUY2NDYmbEpO5K24sacp1lXf3HsCpYK 4cQpffwgYwI+lz76MmlYic6DChgTyULQ7hjLlrqvxGlcBXs4loyMKy8eYG0rppUpQJ/5 XfrBcauEAsA3MgipT75hTZ7pyM6qLgrSr7R0Xv9O6PyG9lAAg31BSbZ2znY2k+1Prkp5 zfTHq8Dyz5/rHx/r2yVKfTrBcNL6mTvVnUzH8rVUo9CoYemfni/04lU2MUkVL6K93Zt3 Ug== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3fk4fvg40d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Apr 2022 17:54:27 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3CD5010002A; Fri, 22 Apr 2022 17:54:27 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 3611B23695A; Fri, 22 Apr 2022 17:54:27 +0200 (CEST) Received: from localhost (10.75.127.44) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Fri, 22 Apr 2022 17:54:26 +0200 From: Arnaud Pouliquen To: Bjorn Andersson , Mathieu Poirier CC: , , , , Hangyu Hua Subject: [PATCH] rpmsg: virtio: Fix the unregistration of the device rpmsg_ctrl Date: Fri, 22 Apr 2022 17:54:02 +0200 Message-ID: <20220422155402.721982-1-arnaud.pouliquen@foss.st.com> X-Mailer: git-send-email 2.24.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-22_04,2022-04-22_01,2022-02-23_01 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unregister the rpmsg_ctrl device instead of just freeing the the virtio_rpmsg_channel structure. This will properly unregister the device and call virtio_rpmsg_release_device() that frees the structure. Fixes: c486682ae1e2 ("rpmsg: virtio: Register the rpmsg_char device") Signed-off-by: Arnaud Pouliquen Cc: Hangyu Hua --- drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 3b7b47f785cf..0db8043e6c49 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -861,7 +861,7 @@ static void rpmsg_virtio_del_ctrl_dev(struct rpmsg_device *rpdev_ctrl) { if (!rpdev_ctrl) return; - kfree(to_virtio_rpmsg_channel(rpdev_ctrl)); + device_unregister(&rpdev_ctrl->dev); } static int rpmsg_probe(struct virtio_device *vdev) -- 2.24.3