Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 22 Apr 2022 10:07:15 -0700
From:   Darren Hart <darren@os.amperecomputing.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Quan Nguyen <quan@os.amperecomputing.com>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>,
        Derek Kiernan <derek.kiernan@xilinx.com>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Thu Nguyen <thu@os.amperecomputing.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v8 3/9] misc: smpro-errmon: Add Ampere's SMpro error
 monitor driver
Message-ID: <YmLgwwbVMFwViYBg@fedora>
References: <20220422024653.2199489-1-quan@os.amperecomputing.com>
 <20220422024653.2199489-4-quan@os.amperecomputing.com>
 <YmJJIb1DAIq5arCw@kroah.com>
 <82a6452a-965b-7fbe-eba2-919f0a6ed73a@os.amperecomputing.com>
 <YmLCcFrrobUJtiLI@kroah.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmLCcFrrobUJtiLI@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?orwUsD8QBylfjPADMjmkiW5Rf7uecyN1zow4hvMn5AviB2bC4lzC71K7Ki5K?=
 =?us-ascii?Q?LrHVvn3Dlb2PV5hKS2uWy1S9r2aaYZzoev3cNnaRkePRY24hDmAoZQv8gJXF?=
 =?us-ascii?Q?VHehHUS3yzcEX3lxVW8T4HSqREorJ1SZ59IUEXWVGqhlzgZWB2ulPUN5jzp7?=
 =?us-ascii?Q?uhz4IxMNOEZWUttpBoTdciv5CMH5R4qdlAGv+lxkNcPhX3KWonQcpqjfQVKU?=
 =?us-ascii?Q?UBEBO/spGgcomK8mHsigKKzt+FH4daUDTs/nVUe41QIGncChFzAj1xZbwO5O?=
 =?us-ascii?Q?w2lqgCgsVhIh9huRVifkO8UhecQiiqHblGV+7zyccUNGiAs0IkGo4k0+Vy/g?=
 =?us-ascii?Q?wlzemAbh/3S2lHy9mvMcdYerLfRzlVM8Bnp53A7m5HBHoorrfsvYtRQ8fch3?=
 =?us-ascii?Q?En0YWZsVDEhv38+OlbTqQig3qBATLO4XDl6GStZVdhNfTScfsBQWSSanccov?=
 =?us-ascii?Q?PQngXxKenKSdfvv5xF3FlahrtGTpfm/9afMZBCH7948075GWhmvppRx2MyiK?=
 =?us-ascii?Q?N5IQW6D/qh3HT2BaQE3rang5++gO59kaZjnWnWmHHzcT2UCd27377F6ZXwSo?=
 =?us-ascii?Q?SZGhJHUDnkVnmYK5gpSm5v7bXPVaa2LdRkng1ukgJZ4P1A30xg9jvj/cT2NL?=
 =?us-ascii?Q?PXegKv9eHm27fTC1oeMMAEumwFc2uRDZeQKEutsIC4MGhe6PIwj2sHFqb3h3?=
 =?us-ascii?Q?TICdr5r4l3nPia7UEvZUvdeVwjTmuApYwogpAUcW3Fe2j8AQR+TXLRMbraMv?=
 =?us-ascii?Q?X2mVv7dJZmda0gi37+Rgj5BOQLbOdHLOKbDwdfCGRFhi5ikF5fuz84XC5/Jp?=
 =?us-ascii?Q?KSjHHCLqqPhJ5NQ+m3V5/tM4End/oCLrrkH5Klk1PTwxsrvLgHJivz4n+8dW?=
 =?us-ascii?Q?U5WGlk1+bnkFMTzyMM2ZH6Fz6sMzTZp2FopzwsdJNzMFIUkiDcQaDToxrFxA?=
 =?us-ascii?Q?zhSFEMyGUS/7wAwkzCm+8QHwzG/w+lQayvfnBKUY++ZhrKyoX3A4eI1E0vqe?=
 =?us-ascii?Q?VJwkVsyc3tN9mVOxsU7hA00vP5cI6GRM337Hoo4kXpFns3w7HI/S1yOSf7xH?=
 =?us-ascii?Q?HDuQ9gs71m9kxrql3LNOdmlSZ/jtZAGIhK77PAyR0WZZHBV8URaCXroU+7Oo?=
 =?us-ascii?Q?HAztGDwzUsfdeywcceCBD0IHNZqDvq3G2ZEdyaPz/axZvIHGziWMPY3IkBZJ?=
 =?us-ascii?Q?mlNuy7Ndyi9eBYNsiWUegzGnsYKdSqEIxrw5OO4VaoIXABxQuHeo0zopy6i2?=
 =?us-ascii?Q?vQFKSN0vDX40AZAqmJ+zkSXxn3FHd58BfbhiMw8L6ahJzdzbKU+XfM5/sYjn?=
 =?us-ascii?Q?mR/Jk1YZWb4XFS8wUzOUEZnUvUngXe5RmBwT4dmXfeOV363CZTZPrtb3fQgq?=
 =?us-ascii?Q?UDfEwb7oLkkEtzBv+Sl1rcO41JPDXoRM7xHEuEto3PDJBjfKteoAg2iW5WRS?=
 =?us-ascii?Q?iAVyk2hmAQXD0iizRXPTy2UDAj7lWcWgy3u3pIRdpeqXH32uFbYiiDKG7cz/?=
 =?us-ascii?Q?T9u8isMZj+w5AOdEvn6nwtWQvQA1p7LJ+BuQzir2cbLaYmqIxVsjhHOFW0lo?=
 =?us-ascii?Q?rBsPnDiGNEBkDOdsbHubcyFpbIAirKqdY7UNoh51Vv+bDbWKYjUn7P76Tio6?=
 =?us-ascii?Q?OpXHMWRe2DL6Qr0mnZ7msRR0eUBvxgy+4wOY8kJ2gXyuKgx5F9mplBUMVioe?=
 =?us-ascii?Q?7b0vyj00TQO1LE+70Y52vYsNb4ZVhhECZg4jUYSmSe4orHF1+hgj9WfirDSj?=
 =?us-ascii?Q?R/2Gjgjcm6TkS2pNfXViCDesXm7/k28Rsw3ZFHMJa7ixzR5TdTm9?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4a4d520-622a-49b1-6857-08da24828e23
X-MS-Exchange-CrossTenant-AuthSource: SA0PR01MB6329.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 17:07:18.7084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 78REwfForVMq4WUovvJ9QPlDLL2SP8YBA3rmmQcj+pJZ0n6bVQkhhIaWoXjUzyA8mUYhbCsu1UeGcOANfXs0GgvZ2D7ypPN0kxX0Z38lik2LM0pposKAkyyhhhD0C82h
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR0102MB3554
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 22, 2022 at 04:57:52PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 22, 2022 at 09:43:39PM +0700, Quan Nguyen wrote:
> > On 22/04/2022 13:20, Greg Kroah-Hartman wrote:
> > > On Fri, Apr 22, 2022 at 09:46:47AM +0700, Quan Nguyen wrote:
> > > > This commit adds Ampere's SMpro error monitor driver for monitoring
> > > > and reporting RAS-related errors as reported by SMpro co-processor
> > > > found on Ampere's Altra processor family.
> > > > 
> > > > Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> > > > ---
> > > > Changes in v8:
> > > >    + Update wording for SMPRO_ERRMON on Kconfig file             [Quan]
> > > >    + Avoid uninitialized variable use               [kernel test robot]
> > > >    + Switch to use sysfs_emit()                                  [Greg]
> > > >    + Make sysfs to return single value                           [Greg]
> > > >    + Change errors_* sysfs to error_*                            [Quan]
> > > >    + Add overflow_[core|mem|pcie|other]_[ce|ue] sysfs to report
> > > >    overflow status of each type of HW errors                     [Quan]
> > > >    + Add some minor refactor                                     [Quan]
> > > > 
> > > > Changes in v7:
> > > >    + Remove regmap_acquire/release_lock(), read_i2c_block_data() [Quan]
> > > >    + Use regmap_noinc_read() instead of errmon_read_block()      [Quan]
> > > >    + Validate number of errors before read                       [Quan]
> > > >    + Fix wrong return type of *_show() function     [kernel test robot]
> > > >    + Adjust patch order to avoid dependence with smpro-mfd  [Lee Jones]
> > > >    + Use pointer instead of stack memory                         [Quan]
> > > > 
> > > > Changes in v6:
> > > >    + First introduced in v6 [Quan]
> > > > 
> > > >   drivers/misc/Kconfig        |  12 +
> > > >   drivers/misc/Makefile       |   1 +
> > > >   drivers/misc/smpro-errmon.c | 477 ++++++++++++++++++++++++++++++++++++
> > > >   3 files changed, 490 insertions(+)
> > > >   create mode 100644 drivers/misc/smpro-errmon.c
> > > > 
> > > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > > index 41d2bb0ae23a..9fbe6797c440 100644
> > > > --- a/drivers/misc/Kconfig
> > > > +++ b/drivers/misc/Kconfig
> > > > @@ -176,6 +176,18 @@ config SGI_XP
> > > >   	  this feature will allow for direct communication between SSIs
> > > >   	  based on a network adapter and DMA messaging.
> > > > +config SMPRO_ERRMON
> > > > +	tristate "Ampere Computing SMPro error monitor driver"
> > > > +	depends on MFD_SMPRO || COMPILE_TEST
> > > > +	help
> > > > +	  Say Y here to get support for the SMpro error monitor function
> > > > +	  provided by Ampere Computing's Altra and Altra Max SoCs. Upon
> > > > +	  loading, the driver creates sysfs files which can be use to gather
> > > > +	  multiple HW error data reported via read and write system calls.
> > > > +
> > > > +	  To compile this driver as a module, say M here. The driver will be
> > > > +	  called smpro-errmon.
> > > > +
> > > >   config CS5535_MFGPT
> > > >   	tristate "CS5535/CS5536 Geode Multi-Function General Purpose Timer (MFGPT) support"
> > > >   	depends on MFD_CS5535
> > > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> > > > index 70e800e9127f..483308a6e113 100644
> > > > --- a/drivers/misc/Makefile
> > > > +++ b/drivers/misc/Makefile
> > > > @@ -23,6 +23,7 @@ obj-$(CONFIG_ENCLOSURE_SERVICES) += enclosure.o
> > > >   obj-$(CONFIG_KGDB_TESTS)	+= kgdbts.o
> > > >   obj-$(CONFIG_SGI_XP)		+= sgi-xp/
> > > >   obj-$(CONFIG_SGI_GRU)		+= sgi-gru/
> > > > +obj-$(CONFIG_SMPRO_ERRMON)	+= smpro-errmon.o
> > > >   obj-$(CONFIG_CS5535_MFGPT)	+= cs5535-mfgpt.o
> > > >   obj-$(CONFIG_GEHC_ACHC)		+= gehc-achc.o
> > > >   obj-$(CONFIG_HP_ILO)		+= hpilo.o
> > > > diff --git a/drivers/misc/smpro-errmon.c b/drivers/misc/smpro-errmon.c
> > > > new file mode 100644
> > > > index 000000000000..df7d8fc4ff3f
> > > > --- /dev/null
> > > > +++ b/drivers/misc/smpro-errmon.c
> > > > @@ -0,0 +1,477 @@
> > > > +// SPDX-License-Identifier: GPL-2.0+
> > > 
> > > Are you sure you mean "or any later version"?  I have to ask.
> > > 
> > 
> > Thank Greg for the review.
> > 
> > Will change all to SPDX-License-Identifier: GPL-2.0-or-later in next
> > version.
> 
> That is not what I am asking (the SPDX tag format).  I mean, do you
> really mean "or later" for your license as that is not the license of
> the kernel overall?  If so, wonderful, but I have to ask that as your
> legal group needs to be aware of it, sorry.

Generally speaking we should be sticking with the standard license for projects
we engage with, in this case "GPL-2.0".

Quan, unless you have heard differently or have a specific reason to include the
"+", please drop from the next version. If you do feel the "+" is required,
let's have an internal conversation about that.

Apologies for missing that in earlier reviews.

Thanks,

-- 
Darren Hart
Ampere Computing / OS and Kernel