Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220422090505.551472-1-ldewangan@nvidia.com>
In-Reply-To: <20220422090505.551472-1-ldewangan@nvidia.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 23 Apr 2022 02:55:28 +0900
Message-ID: <CAK7LNARLFQdm+2Ka=0U1sX9LXyqCRb3ohzjPmg3Lpfs-ZEbz7A@mail.gmail.com>
Subject: Re: [PATCH V1 1/1] scripts/Kbuild: Add path of fixeddep script
To:     Laxman Dewangan <ldewangan@nvidia.com>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 22, 2022 at 6:05 PM Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
> Add path of the fixdep script from the object tree.
> This will make the path of script absolute rather than
> relative and execute the command from makefile from any
> location.


Why is this necessary?

Also, this patch does not make anything.
$(objtree)/ is still a relative path.
See the top Makefile.


>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>  scripts/Kbuild.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index cdec22088423e..e07e9265829f8 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -147,7 +147,7 @@ if_changed_dep = $(if $(if-changed-cond),$(cmd_and_fixdep),@:)
>
>  cmd_and_fixdep =                                                             \
>         $(cmd);                                                              \
> -       scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
> +       $(objtree)/scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
>         rm -f $(depfile)
>
>  # Usage: $(call if_changed_rule,foo)
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada