Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp976868pxb; Fri, 22 Apr 2022 15:46:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzUYV1EBqaPp3mvZKZ24sbChpPKjLK3raKiXahWIQjBSKx/ZN7bEZjGXquSS4MDo6NfUzn X-Received: by 2002:a05:6870:f21a:b0:dd:9bec:caf8 with SMTP id t26-20020a056870f21a00b000dd9beccaf8mr7110015oao.78.1650667604109; Fri, 22 Apr 2022 15:46:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650667604; cv=none; d=google.com; s=arc-20160816; b=jjN+gYmYEwy1sezW81sVpXFUh95OSIBbO4CkUV3DMfvlGFTxhLLqADR1XXCUhY2svG uZGp2d+QjSc4Jk4OB7Zo6D6pSW8d6z1zCBPOg9fMGYiBiJq7yxZFqHr3HkrM0JAw0MqJ vyV5QGgtrZNJmbXUTIbCM0MPXq7OC8u5PjfuJHpw3grRpKWzUPmdOF+dwWkJnQb9vpH2 lVrpkNJQ3Gkk8ayUOXyr13Im+UND++YXHfvoLYfHGxhU9SQnBZsi1tqcpdO+gAMzwShG tNZqjvT3N4P9bvfAIkDnM2Qk0LeQkjH5B+iW9ftgMUs2rY5oXwA2XolKbjEukpbqom20 YXlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Toyju6a+evnhzH+Nqks+WR6DENzUjw2yWJmWU3651y0=; b=Gq/VzeB15ZWKbEiyY6UHX5gZmZALxKkXJUq2bkjGJqmEUdORQlv5QJ+RYyjEPZ06RV zHmDc+VBLDTskQrBQW3zIGr3/yKYAmtStckZdveNDa8hYOshtlaQ/h/kEmmzDRg0Kxp0 YYKiVL+c1g6hh1sMM+6aTfi7OZyxUgKZYJt2Zq1rg6IXpLd+An2FMvvISuXFzoW3HKJa fB98oo2ESzaSbwo5pCXJjvth8wAi/ADdeVUum/ySUjVY2qlEyCmtVCZXIQaz7i3Jb81N xQRs7DqyTN7uX65VkHoSLBapkwImO/di+4eVnlJcH+iXD3bnfWuM0G5W3nXUBmk7zyMp x5pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=b0QAaktQ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a2-20020a056870d18200b000e324b33563si3707707oac.100.2022.04.22.15.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 15:46:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=b0QAaktQ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6DE4929680B; Fri, 22 Apr 2022 13:35:11 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbiDVSBW (ORCPT + 99 others); Fri, 22 Apr 2022 14:01:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234193AbiDVR6G (ORCPT ); Fri, 22 Apr 2022 13:58:06 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB5046F494; Fri, 22 Apr 2022 10:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Toyju6a+evnhzH+Nqks+WR6DENzUjw2yWJmWU3651y0=; b=b0QAaktQMlIxRfq/uHTuerhC7B Z53GTvIOeOO2kg5KrMW1hGLzc9YhdqWmc4rqrLeV63geBifrYl7QT8IfiaAx72PSDbHixmrAuTM5A 5N+FanBJW3e/1JOMd/6zxYCkQhoErfZ7wPYKKmQRYYgyBiYn9e8ztX+3O3JZOBaeDADGnZVO9fPxy MBreCn8jNX04jupKTnL29af4St2DmZDV7klFTdgRamsFyECj1miJZaxhwuIsylseJ9IbUzKoqw9bY JKbau1LLKiNZtUjjs59qyKi7sy1sbku1D89tsYC7ZK09divKAXHrXAqMfXATyTvHEgJAyF9lIMrns z4tW2xOg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhxQc-007lL9-E4; Fri, 22 Apr 2022 17:50:46 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id DA4C59861AE; Fri, 22 Apr 2022 19:50:44 +0200 (CEST) Date: Fri, 22 Apr 2022 19:50:44 +0200 From: Peter Zijlstra To: Tejun Heo Cc: David Vernet , lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/4] cgroup: Introduce cpu controller test suite Message-ID: <20220422175044.GX2731@worktop.programming.kicks-ass.net> References: <20220422173349.3394844-1-void@manifault.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2022 at 07:48:36AM -1000, Tejun Heo wrote: > Hello, David. > > On Fri, Apr 22, 2022 at 10:33:47AM -0700, David Vernet wrote: > > This patchset introduces a new test_cpu.c test suite as part of > > tools/testing/selftests/cgroup. test_cpu.c will contain testcases that > > validate the cgroup v2 cpu controller. > > > > This patchset only contains testcases that validate cpu.stat and > > cpu.weight, but I'm expecting to send further patchsets after this that > > also include testcases that validate other knobs such as cpu.max. > > > > Note that checkpatch complains about a missing MAINTAINERS file entry for > > [PATCH 1/4], but Roman Gushchin added that entry in a separate patchset: > > https://lore.kernel.org/all/20220415000133.3955987-4-roman.gushchin@linux.dev/. > > Looks great to me. Thanks for adding the much needed selftests. Peter, if > you're okay with it, imma route it through the cgroup tree. Sure, have at. Thanks!