Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967526AbXEHAVj (ORCPT ); Mon, 7 May 2007 20:21:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S967493AbXEHAVf (ORCPT ); Mon, 7 May 2007 20:21:35 -0400 Received: from mx1.redhat.com ([66.187.233.31]:52849 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967475AbXEHAVe (ORCPT ); Mon, 7 May 2007 20:21:34 -0400 Message-ID: <463FC1F7.7090806@redhat.com> Date: Mon, 07 May 2007 20:19:03 -0400 From: =?UTF-8?B?S3Jpc3RpYW4gSMO4Z3NiZXJn?= User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Christoph Hellwig , Kristian H??gsberg , John Stoffel , Stefan Richter , linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , linux1394-devel Subject: Re: [PATCH 3/6] firewire: char device interface References: <4637A29F.6070302@redhat.com> <20070502090007.GA28174@infradead.org> <17976.44988.734513.121919@smtp.charter.net> <4638FE91.6050001@redhat.com> <20070504094817.GA31811@infradead.org> In-Reply-To: <20070504094817.GA31811@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1043 Lines: 23 Christoph Hellwig wrote: > On Wed, May 02, 2007 at 05:11:45PM -0400, Kristian H??gsberg wrote: >> The firewire-cdev.h file is meant to be a self-contained userspace header >> file and shouldn't include other kernel header files. All duplicated >> values are standardized ieee1394 values and won't ever change. I should >> put a #ifndef __FW_COMMON_DEFINES protection around the duplicate values, I >> guess, but I'm just wondering why I never saw a "symbol redefined" >> warning... > > No, defining things in two places is not okay. Just add a new header > that defines these protocol constants, which needs to be included by > userspace that wants to use them. Ok, I split out the shared constants into linux/firewire-constants.h which gets included by linux/firewire-cdev.h. Kristian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/