Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Lee, RyanS" <RyanS.Lee@analog.com>
To:     Rob Herring <robh@kernel.org>, Ryan Lee <ryan.lee.analog@gmail.com>
CC:     "krzk+dt@kernel.org" <krzk+dt@kernel.org>,
        "pbrobinson@gmail.com" <pbrobinson@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "tanureal@opensource.cirrus.com" <tanureal@opensource.cirrus.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "cy_huang@richtek.com" <cy_huang@richtek.com>,
        "stephan@gerhold.net" <stephan@gerhold.net>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "drhodes@opensource.cirrus.com" <drhodes@opensource.cirrus.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: RE: [PATCH 1/2] ASoC: dt-bindings: max98396: add amplifier driver
Thread-Topic: [PATCH 1/2] ASoC: dt-bindings: max98396: add amplifier driver
Thread-Index: AQHYUSqfbf52IXb2okOGjW7bkRB5AazzHTuAgAMoKFA=
Date:   Mon, 18 Apr 2022 22:32:29 +0000
Message-ID: <SJ0PR03MB6681CB77F45CE973DF87B01E8AF39@SJ0PR03MB6681.namprd03.prod.outlook.com>
References: <20220416004024.210418-1-ryan.lee.analog@gmail.com>
 <1650147459.157752.3544948.nullmailer@robh.at.kernel.org>
In-Reply-To: <1650147459.157752.3544948.nullmailer@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AFZFxEHq1nV6AXs0oqxwHsRCl4MANHK5WUOWhVu6of+c3AoDnPy2bWSsJnzE?=
 =?us-ascii?Q?7Q7GdSYBk6yTrpMCvIcIevrduGOmICeuLEPl1KNS9sFvQyrGq9l5BsWpdlKY?=
 =?us-ascii?Q?sj335rHH1o78UTJZ1YdNHuTg4Lxr8pkE44ZMQZgvOrwMlUzyIQLjOHF7jDaQ?=
 =?us-ascii?Q?GOESvYy+xwV8saI8gzyoS7QSrB/txt/4XMQhrKmwrANQHqw5A0Ry2P1aQ4g/?=
 =?us-ascii?Q?103C/SuB1ASAZox6SkQWkanK8ITL2XuaBDUAwnV8M2mIUiAXDLe/UcVhpUO0?=
 =?us-ascii?Q?gHxiegbP3OdGei4YBO6bmTw+lOIzloo572HlvFBkY7fB3WbBrotFjR6XkpGk?=
 =?us-ascii?Q?OCWnGJvPHc3FGEf/iC5aAVQBCRoazMc8GB3f4syQe2TTm7InIRloDrqWYNin?=
 =?us-ascii?Q?rphLXnjd05VBpiNupeFHBa5dg9kNjETz+pNjt9sZX+92CesSXoVEoa8daCfy?=
 =?us-ascii?Q?YYtCzE4lEfS4mIcqtzf7gPZqSlPeB282zdLLMym8XFFa/uZiOO269yjf3Sc3?=
 =?us-ascii?Q?ivcFcpVDHNZUx30ebMl0TrWOZXCAk8P//tNlviHgw/duTB02BeMoHgHn6+p5?=
 =?us-ascii?Q?wB8zOjtVxLQShZMZPFpwcBFGzpGOeAvTWA1t00BEU2MTqeyPNTdnZfoHkHgf?=
 =?us-ascii?Q?WpS9kf5KnOS5kd/GkhnmsbmXwLyrPgrurQHajexMNZeVMSNRuhSk8a8w3LNJ?=
 =?us-ascii?Q?DaHClmEdWiJTsXoKlLKXxXh2l/5UBerdENdcU6YfKK6D78UuVA0KdN6IfJSi?=
 =?us-ascii?Q?WaLRAsYSQUUo57rXoaflCsDeaPO+fv3YspevMOhGZPIYq8thpyhlTzntBbBh?=
 =?us-ascii?Q?z0y6zOFXZLsVTxtkR8mK0BiBpN9g5YUIjqmdXh6yUIEnm+y8E8sWekArgiow?=
 =?us-ascii?Q?kZxtVsiMybDlhUrFObryB/jvJjPpmWGrV5KWb8IK6k1FsMybhx3tSYWduEcx?=
 =?us-ascii?Q?aDedaiGOJkj6a+EWm1W7PTPUocWribjQwAP+O9W9FVVnPbKQdqqmcuLMmuex?=
 =?us-ascii?Q?64VYPaPtJkeUEYPP2b2m01l59wKJ1ABjAMHvBlBCs++e/f1DNT+IVsk5LaSE?=
 =?us-ascii?Q?ziqRPU6VwKMf/bcaZAjS6zOr9nDMmTpEFOZSK6DJIMA/p5DYj9S2JIOHlYA9?=
 =?us-ascii?Q?0ZJ1FOiu+MjNEUMNoZt7RDdMcTmIpvMVQW0OcRXjwpCC3QrEH1gssSDMtzvS?=
 =?us-ascii?Q?BdK1Bz1j1A+oJwELDgJ4wyxJw6edkpq/JbMvb2NqYCI2c3VyxEvcuDhfWW9x?=
 =?us-ascii?Q?8HJYN2QAIpwyTOMjq06sUJkJTyxzjc6AcGNdJ2J4/VpjrVa9uan1Q9beuoaN?=
 =?us-ascii?Q?OIi9FuERMcviLxGxzNRipNiNStNCDIzqxKw/7/lOXhrWMvEi5bQc1cJ9sZoE?=
 =?us-ascii?Q?eHPdQ02XPgtYQiRcMaQtCQ2JslHgqgsDGU6M0+6LC5uQMr6c2vzrr0yeXfwL?=
 =?us-ascii?Q?fBTQzJiu9a4Nl0wz6LfZ+VRgOHGiel3iGZYn9wlOo8MLIFVNO7/E75anWH2L?=
 =?us-ascii?Q?3IamZIReOms5lvk7kul/YQMQ+jkFS/j6qzjj5WK3cfZuphwYTajkZF1RVhyC?=
 =?us-ascii?Q?qQ0PWWvDJSnd1Xq2cxt4/pDR7OmTo8hD7IQvdLo5df6XNMSAD/nZViua4viC?=
 =?us-ascii?Q?PAqFTWS3i1fhikK0ToHHnBDojMjSRNBZuegrbv+Pc5MTQXd+th1786udPE2+?=
 =?us-ascii?Q?ecHPa+2kJgxfUfQGXnlPCQKI5tHFwgUYeUhh7LcHP21iE6CtEMdAxBejwem7?=
 =?us-ascii?Q?C08oOR6QJw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6681.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a1b3097-706e-4283-6789-08da218b52b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 22:32:29.5819
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LUIjczbidugFqC36I8TppFA1BNYqVzyzE5sSWb3P/q0YlRInjk+2TZ4Hb1UMifod3vDguLw1wjSyQL6z6QOFlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2575
X-Proofpoint-ORIG-GUID: Gk3CtEvf2h7hUICNHQenas2oLOQqDc8E
X-Proofpoint-GUID: Gk3CtEvf2h7hUICNHQenas2oLOQqDc8E
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-18_02,2022-04-15_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 adultscore=0 bulkscore=0 clxscore=1011 impostorscore=0 priorityscore=1501
 mlxscore=0 spamscore=0 mlxlogscore=750 suspectscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204180125
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Saturday, April 16, 2022 3:18 PM
> To: Ryan Lee <ryan.lee.analog@gmail.com>
> Cc: krzk+dt@kernel.org; pbrobinson@gmail.com; linux-
> kernel@vger.kernel.org; ckeepax@opensource.cirrus.com;
> lukas.bulwahn@gmail.com; devicetree@vger.kernel.org; pierre-
> louis.bossart@linux.intel.com; srinivas.kandagatla@linaro.org; alsa-
> devel@alsa-project.org; tanureal@opensource.cirrus.com;
> broonie@kernel.org; tiwai@suse.com; cy_huang@richtek.com;
> stephan@gerhold.net; arnd@arndb.de; robh+dt@kernel.org;
> hdegoede@redhat.com; perex@perex.cz;
> drhodes@opensource.cirrus.com; Lee, RyanS
> <RyanS.Lee@analog.com>; lgirdwood@gmail.com
> Subject: Re: [PATCH 1/2] ASoC: dt-bindings: max98396: add amplifier
> driver
>=20
> [External]
>=20
> On Fri, 15 Apr 2022 17:40:23 -0700, Ryan Lee wrote:
> > From: Ryan Lee <ryans.lee@analog.com>
> >
> > This patch adds dt-bindings information for Analog Devices
> MAX98396
> > and MAX98397 Smart Amplifier.
> >
> > Signed-off-by: Ryan Lee <ryans.lee@analog.com>
> > ---
> >  .../bindings/sound/adi,max98396.yaml          | 84
> +++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/adi,max98396.yaml
> >
>=20
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20

I appreciate your feedback. I was able to check the same issues on my side.
I shall fix the problem and submit the updated patch.

> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/sound/adi,max98396.yaml:49:1
> 11: [warning] line too long (121 > 110 characters) (line-length)
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,spkfb-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 	'type' is a required property
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	Additional properties are not allowed ('maximum', 'default',
> 'minimum' were unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,spkfb-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,spkfb-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,interleave-mode: 'oneOf' conditional failed, one
> must be fixed:
> 	Additional properties are not allowed ('default' was
> unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,interleave-mode: 'oneOf' conditional failed, one
> must be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	Additional properties are not allowed ('type', 'default' were
> unexpected)
> 		hint: A vendor string property with exact values has an
> implicit type
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,interleave-mode: 'oneOf' conditional failed, one
> must be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,vmon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 	'type' is a required property
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	Additional properties are not allowed ('maximum', 'default',
> 'minimum' were unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,vmon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,vmon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,imon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 	'type' is a required property
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	Additional properties are not allowed ('maximum', 'default',
> 'minimum' were unexpected)
> 		hint: A vendor boolean property can use "type:
> boolean"
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,imon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'enum' is a required property
> 		'const' is a required property
> 		hint: A vendor string property with exact values has an
> implicit type
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	/builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: properties:adi,imon-slot-no: 'oneOf' conditional failed, one must
> be fixed:
> 		'$ref' is a required property
> 		'allOf' is a required property
> 		hint: A vendor property needs a $ref to types.yaml
> 		from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> 	hint: Vendor specific properties must have a type and
> description unless they have a defined, common suffix.
> 	from schema $id:
> https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/vendor-
> props.yaml*__;Iw!!A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGa
> Nyp2EOec4EnuAYY4aQ25BDE2H4waOpyi0_juZ-wiHiNs8$
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/sound/adi,max98396.ya
> ml: ignoring, error in schema: properties: adi,spkfb-slot-no
> Documentation/devicetree/bindings/sound/adi,max98396.example.dt
> b:0:0: /example-0/i2c/amplifier@39: failed to match any schema with
> compatible: ['adi,max98396']
> Documentation/devicetree/bindings/sound/adi,max98396.example.dt
> b:0:0: /example-0/i2c/amplifier@3c: failed to match any schema with
> compatible: ['adi,max98397']
>=20
> doc reference errors (make refcheckdocs):
>=20
> See
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/__;!
> !A3Ni8CS0y2Y!6AbqO57BdHk8HsfdSgsIJ96PVLttFGaNyp2EOec4EnuAYY
> 4aQ25BDE2H4waOpyi0_juZ-xmX_4-e$
>=20
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit.