Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220419160058.9998-1-markuss.broks@gmail.com>
 <20220419160058.9998-2-markuss.broks@gmail.com> <Yl7pqgjza/ZfajyM@sirena.org.uk>
 <0599e7ac-bd06-8d56-b510-0f27f4cc6790@gmail.com> <Yl8Jm9XqR3YTrW9Y@sirena.org.uk>
In-Reply-To: <Yl8Jm9XqR3YTrW9Y@sirena.org.uk>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
Date:   Fri, 22 Apr 2022 21:37:20 +0300
Message-ID: <CANhJrGPXJYf4Bf3oBLGB2v3AwyvJbompjX34qOaKXsEhFda0zw@mail.gmail.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: regulator: Add bindings for Silicon
 Mitus SM5703 regulators
To:     Mark Brown <broonie@kernel.org>
Cc:     Markuss Broks <markuss.broks@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        devicetree <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 22, 2022 at 9:05 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Apr 19, 2022 at 08:45:07PM +0300, Markuss Broks wrote:
>
> > I took an example from the rohm,bd71847-pmic.yaml MFD binding, they have
> > regulators at a separate regulators { } node, with a separate dt-binding for
> > it. I'm not sure what should I do, I'd be more than happy to follow a better
> > example if you can show me it.
>
> Basically either just remove the compatible and have the MFD directly
> instantiate the device like sky81452 or put a separate node for each
> regualtor like wm831x does (but without any DT support).

Just a note that the BD71847 does not have own "compatible" for the
regulators. There's only "compatible" in the MFD node - and MFD just
kicks the regulator driver. Regulators get the handle to the node from
the parent device. I think it should serve as a valid example of what
Mark described as

> Basically either just remove the compatible and have the MFD directly
> instantiate the device


Best Regards
-- Matti Vaittinen