Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp986075pxb; Fri, 22 Apr 2022 16:01:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNdXlSQJvM9zguzLbHCvSrLjVrss4SYGm043rep273jtEyTvdjzhsREK96SXSaBJNn066o X-Received: by 2002:a05:6a00:1484:b0:50b:f383:462b with SMTP id v4-20020a056a00148400b0050bf383462bmr7393589pfu.58.1650668512276; Fri, 22 Apr 2022 16:01:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650668512; cv=none; d=google.com; s=arc-20160816; b=leNc9oLjji834FkYI06xzoFG4CRMEJpg7vJyIznLU/81CotUhmQPeyawFdi+NdstHp Gj9PW/2HtQNg+mGbE4krf7ksqUKvnnRDGb4cilFYu+cEZiax3n+y2Mxu9LG5FujmkLIv f+iE7w5o2X9J21ydPt6Gx9sPFiSbuzXAsZj4gCfPeIQyV09oM5mBWjZy+JSUFasWDPt6 LecOlAVCqulkfpdH9LJlAlu2p3d+S2D0Fx2YNuQZHXNKF+PCxkXSOhKon0OIPlXFSxzR K4UA42+9eb1xv5x2N0ISirY+ommwMByvS8HROZJlpGQcrYMCIQmlBHWEHZsQKMwVpl8f r0Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=oBogXD/RGv/+w8acXX4r7RgMvYw/wbpLHSn+FTmYqdE=; b=QfzFom4PrWdpDu5GA63WcHu7lXrvV0n7jgOwVWGlTukPCpoRM7oLlNI4gczFacDZHA 4MJzR+FgXu1BSfOGaYxx/V7FTnf4LWtTt5wjDXuoaoorelKMOTjNnYigdD65pXfIwLnX vNzIxBVXYOGmnYDVXSoCZ3WZKGcyCfBndB/rdVC5g0LeUU83okXWBjKGMOh9UQtsilbh RdTTy5XQpvw2Fysh3j/DGmLnLcHQpAbCqiPXGSQMAeWBs/hbtKO6Zn4InHVnRQ/JuSQD F2IZtU/TmmSwY5LVcB512e68rcTU5aW00P5QYkQyDE3Fyyk+jUSz/aliZfNVzcFuzPgl QPwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=aUW8Ae3F; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=llO7MKno; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 3-20020a630003000000b0039954af1a2csi9723728pga.413.2022.04.22.16.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 16:01:52 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=aUW8Ae3F; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=llO7MKno; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4ECC225B415; Fri, 22 Apr 2022 14:56:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231314AbiDVV6s (ORCPT + 99 others); Fri, 22 Apr 2022 17:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231135AbiDVV62 (ORCPT ); Fri, 22 Apr 2022 17:58:28 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93CDB2B2A23; Fri, 22 Apr 2022 13:41:05 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C18231F388; Fri, 22 Apr 2022 20:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1650659558; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oBogXD/RGv/+w8acXX4r7RgMvYw/wbpLHSn+FTmYqdE=; b=aUW8Ae3FucLUripCmlu0nnpdkipuJgVHOcV3ppa7c1YHnssQF4LseU9e15pZPZcF1S8sqa XpwnrFkR5PYeF2ZaUMz6ke5gwVUbNUqEwdMoeDPHhaXf2wPyhg16lHhHPHqAPOS/Pm98xb 3GrpFxAAnm0bPSop2laDt8MaxGCUnEI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1650659558; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oBogXD/RGv/+w8acXX4r7RgMvYw/wbpLHSn+FTmYqdE=; b=llO7MKnogLajedR/xIuJeFfdG1JawzendS1HkM1cjttq3IX4N3s0zMyMa0HsIctMNHnNT6 5RVKGSyT+j3SvxAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 94BBD131BD; Fri, 22 Apr 2022 20:32:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HItTI+YQY2I4fwAAMHmgww (envelope-from ); Fri, 22 Apr 2022 20:32:38 +0000 Date: Fri, 22 Apr 2022 22:28:33 +0200 From: David Sterba To: Haowen Bai Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: Fix a memory leak in btrfs_ioctl_balance() Message-ID: <20220422202833.GI18596@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Haowen Bai , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <1650534677-31554-1-git-send-email-baihaowen@meizu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1650534677-31554-1-git-send-email-baihaowen@meizu.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 05:51:17PM +0800, Haowen Bai wrote: > Free "bargs" before return. > > Signed-off-by: Haowen Bai Thanks for the report, as the leak was in a staged patch it can be fixed in place, which I did by applying a fixup from Nikolay.