Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 13:40:21 -0500
From:   Nishanth Menon <nm@ti.com>
To:     <cgel.zte@gmail.com>, <tony@atomide.com>
CC:     <ssantosh@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] soc: ti: pm33xx: using pm_runtime_resume_and_get instead
 of pm_runtime_get_sync
Message-ID: <20220422184021.v2w55kbvllu3flar@daughter>
References: <20220418063059.2558074-1-chi.minghao@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220418063059.2558074-1-chi.minghao@zte.com.cn>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 06:30-20220418, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Tony: Could you check?

> ---
>  drivers/soc/ti/pm33xx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c
> index 7bab4bbaf02d..ce09c42eaed2 100644
> --- a/drivers/soc/ti/pm33xx.c
> +++ b/drivers/soc/ti/pm33xx.c
> @@ -555,11 +555,9 @@ static int am33xx_pm_probe(struct platform_device *pdev)
>  #endif /* CONFIG_SUSPEND */
>  
>  	pm_runtime_enable(dev);
> -	ret = pm_runtime_get_sync(dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(dev);
> +	ret = pm_runtime_resume_and_get(dev);
> +	if (ret < 0)
>  		goto err_pm_runtime_disable;
> -	}
>  
>  	ret = pm_ops->init(am33xx_do_sram_idle);
>  	if (ret) {
> -- 
> 2.25.1
> 
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D