Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp993109pxb; Fri, 22 Apr 2022 16:12:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzONc94/BLA7napix8+wZMwxs72taIgzz+gI40JxS54QQDh35VPsJgBEjDV5u5e8uPOh2WQ X-Received: by 2002:a17:902:8c87:b0:15b:af1c:c863 with SMTP id t7-20020a1709028c8700b0015baf1cc863mr6508344plo.21.1650669131911; Fri, 22 Apr 2022 16:12:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650669131; cv=none; d=google.com; s=arc-20160816; b=tXJgsbcCyWXFYh9WTp1mOToWIGXdV/R6Ld7Q2nicEPEorAj9pKvXpHO7EFqq/KXOP2 rdFx1aNnC+fIfVRqPw4SvyaSfMeXBERUUa1UFrFzfadxNSkS2r3Hi9xiob6YmiuuCG2J CuzPNdUTJpk35NOsSXtItItV+RY8R/ec/mYJtwDKTLD7A4JPTFteGqwJzGbnOz9RAFJm DJZ1dhA5IZZx7/Zid8iZrfuaemPpjQocGrKGN29VX0tkn9hDLUMeoDrywI2YFiVyiv0o ACO0+7iZl1fOsjQY3TUYiwNpWF2bCh+Jd+5rxXE0L64N+cJ2xyfK56EVs/DDtpHJnwQD 4atA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=gmRkt5N52LVAcW5jIpeF1Nn5yhhAyoF29FUFsd01Fns=; b=wyExT8eAaRMdiqi5BdBlsSL/JWUe8qJVAoeDtbW0qzlfb+tgaQBpc1i+KhrmCk90D0 ZJR5PVa0g3ScL+WBcp1fp10CwRrIM2DBnhKhS7XT56ICP800EHf9q7qQEp0msG2AMH/h SCfSKTpiSNZ0MlFWA+83H78bANllzSuNBbtRYo+gxtH/mMboFLhGdYRNH2cpKWR5LFFu 3l8cxBYXVR7OO6nQjdZQ8RBGolrqySC8FKxosAob4PDwBTrig0taSf5opPV2DHLzvh3I fjOTUfPTpfUkf9ibFKYLh/4Q02xm2HwlyAAATyxP54S6YUi9qykOL/Ko4BrfvAvZ7FUG xtuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=brYIpV1+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 2-20020a630602000000b003aa488678bcsi9903622pgg.709.2022.04.22.16.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 16:12:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=brYIpV1+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 454A922815F; Fri, 22 Apr 2022 15:13:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232283AbiDVWPb (ORCPT + 99 others); Fri, 22 Apr 2022 18:15:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232321AbiDVWPO (ORCPT ); Fri, 22 Apr 2022 18:15:14 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19B7F23E3F2 for ; Fri, 22 Apr 2022 14:05:05 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id n126-20020a1c2784000000b0038e8af3e788so6034864wmn.1 for ; Fri, 22 Apr 2022 14:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gmRkt5N52LVAcW5jIpeF1Nn5yhhAyoF29FUFsd01Fns=; b=brYIpV1+gbZnACdgtobiaHYB0nSPaEQY0ScB0C1CEeIsPotvLvC9d7oCAEPCZgA89C uxr4XWWt08JrUjRW2taPLwIBI0l08LIQ+tdBDD3Dcvl2N+LHeNiiWLLSiJ/2nAXSmxbW 5V6Qt8AQIHi92IOyOLysC7CDhQRUu7lZDi7hKcHVobTK+mt9yg3GXLl1gnF6CUN511k8 2dACgkZB0zdoeD223DTUdfjYRFediBrQ/WkFCx20AwAddSmuDegIlAyVpQMaA+YkJeVl i9/jYTuvmZKVUkEHz5l8/VZdcoi46D7lI/zvaAmJgrcM3qXnC1vMcqvjxQtND51sdUpm 7npA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gmRkt5N52LVAcW5jIpeF1Nn5yhhAyoF29FUFsd01Fns=; b=Mv9TphPu+oSFPk1fFbitWobXuhyUXSDdtoyZHkv1SnMimvK90ilUOHDON/sDvijY25 MR7qNBSzKG2mT7f0p0XdrRsvdYDGfRPgLFwkf4UDGKw9P+9MjUVRcfmIybBgLas0/aZ3 Qfwuk02nXuBlUFS9WfOd7jCPyZAgWjh8mn5ixF+h0l4w3ciHEK1slVzFZZkecB0+HQVr sQ9dssKWAEEKNF+bg7MWICfY+EQZbSOzll7rOn0MNAkn9Bs6QiEp8nj3+BP971pKWlX3 2ddNflF+xovKHTUjZTr0C+m70imqHeD9doPe8/YH+20gts2tlYvQQgwf32s89cxyOiKx M0IQ== X-Gm-Message-State: AOAM533A/lBUhU3DFiOzReSyVCwV7CmkQ3qTM0SDlWCdfNk//PdTnCGs n6FkLFvzwIuVZgG30uRcKdnFHWLx9/vO5Wr+u9o= X-Received: by 2002:a05:600c:3011:b0:38e:ba57:8b79 with SMTP id j17-20020a05600c301100b0038eba578b79mr14709846wmh.26.1650661503393; Fri, 22 Apr 2022 14:05:03 -0700 (PDT) MIME-Version: 1.0 References: <20220405173918.1000846-1-robdclark@gmail.com> In-Reply-To: From: Rob Clark Date: Fri, 22 Apr 2022 14:06:08 -0700 Message-ID: Subject: Re: [PATCH] drm/virtio: Add execbuf flag to request no fence-event To: Chia-I Wu Cc: ML dri-devel , Rob Clark , David Airlie , Gerd Hoffmann , Gurchetan Singh , Daniel Vetter , "open list:VIRTIO GPU DRIVER" , open list Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 5, 2022 at 10:57 AM Chia-I Wu wrote: > > On Tue, Apr 5, 2022 at 10:38 AM Rob Clark wrote: > > > > From: Rob Clark > > > > It would have been cleaner to have a flag to *request* the fence event. > > But that ship has sailed. So add a flag so that userspace which doesn't > > care about the events can opt-out. > > > > Signed-off-by: Rob Clark > Reviewed-by: Chia-I Wu > > Might want to wait for Gurchetan to chime in as he added the mechanism. It turns out this patch is unnecessary.. I can simply not set VIRTGPU_CONTEXT_PARAM_POLL_RINGS_MASK instead so self-nak for this patch ;-) BR, -R > > --- > > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 8 +++++--- > > include/uapi/drm/virtgpu_drm.h | 2 ++ > > 2 files changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > index 3a8078f2ee27..09f1aa263f91 100644 > > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > @@ -225,9 +225,11 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, > > goto out_unresv; > > } > > > > - ret = virtio_gpu_fence_event_create(dev, file, out_fence, ring_idx); > > - if (ret) > > - goto out_unresv; > > + if (!(exbuf->flags & VIRTGPU_EXECBUF_NO_EVENT)) { > > + ret = virtio_gpu_fence_event_create(dev, file, out_fence, ring_idx); > > + if (ret) > > + goto out_unresv; > > + } > > > > if (out_fence_fd >= 0) { > > sync_file = sync_file_create(&out_fence->f); > > diff --git a/include/uapi/drm/virtgpu_drm.h b/include/uapi/drm/virtgpu_drm.h > > index 0512fde5e697..d06cac3407cc 100644 > > --- a/include/uapi/drm/virtgpu_drm.h > > +++ b/include/uapi/drm/virtgpu_drm.h > > @@ -52,10 +52,12 @@ extern "C" { > > #define VIRTGPU_EXECBUF_FENCE_FD_IN 0x01 > > #define VIRTGPU_EXECBUF_FENCE_FD_OUT 0x02 > > #define VIRTGPU_EXECBUF_RING_IDX 0x04 > > +#define VIRTGPU_EXECBUF_NO_EVENT 0x08 > > #define VIRTGPU_EXECBUF_FLAGS (\ > > VIRTGPU_EXECBUF_FENCE_FD_IN |\ > > VIRTGPU_EXECBUF_FENCE_FD_OUT |\ > > VIRTGPU_EXECBUF_RING_IDX |\ > > + VIRTGPU_EXECBUF_NO_EVENT |\ > > 0) > > > > struct drm_virtgpu_map { > > -- > > 2.35.1 > >