Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp995672pxb; Fri, 22 Apr 2022 16:16:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/jqPvY0qo/aHVTaeUML/6bcsibPx/03nuL0zmOICj2UGoONxet7DTC58o4mkMT9sEZzYC X-Received: by 2002:a17:90a:384d:b0:1d2:97de:eb8c with SMTP id l13-20020a17090a384d00b001d297deeb8cmr18943558pjf.208.1650669379185; Fri, 22 Apr 2022 16:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650669379; cv=none; d=google.com; s=arc-20160816; b=tIOfTsN56slLH0cFEjiy38CnEFIrHyMRaleDb0b5wKzex8nY+M5OVl+kRcqbOh3ZnK 4QbEo2J4mNtOx/Ls+XykJV0ACBTpE6QgwVUOdwo/uTPljWiqFkmQS57Qlg18lv/xmhxJ f2xAZsS8pDXzd9PK6gc5DxKWirRBsY0i3GlY3DqIVdqoT7qzuuTXNnDLu7+RitR2/+rz HoPKWBrx9s+rdQI1Iy1ZuoHb600cH2ER+PXyUTvXU7lSNJkOkS9Cn26U4T8fmSMgmQDj FgnHk8QFRD/gKicsM5eNpMv+Xvv5qKKL3e6WHsNEjF77983C1rbyW6M+QzcaTYPp6J66 wQaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XSpt1IJ1KFQ65bi+jyiXwQSZangsC0Zf0U2JxFg+R7I=; b=AvlbO8nCNyJxehGYeQeRavW/iDIwDwvqn2LIrsSIalG/u3pX0t8LPCVUfEWGnfxVlF apgcDSh6MV6qnPxWt3EseNwBm9apAm2XfnPwBVCqsZAxJ8jgFRkaAktT4Ey8l+dypEng U8hfqCjO5U0Hp8xJXTnLwAO0Y4jpBVbWLc6FbTZGMNoKwQJuFTW849jyAXyupiXLeepR 0W1K6RoRL8eKQNz6XdVDJWIFPl/iVYLp7y4kD/CnrO+xoycE7bBAvJjP+Nld9GKXnVRd UQQ3cg0p5JC1jrEc/ubPfivtpXbIZXY5k37hvIaNmJlS5wssm0kd2IsLg5IG3lnSA/6/ 45FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ELivqPkO; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id y2-20020a170902b48200b00158dd229950si9313886plr.573.2022.04.22.16.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 16:16:19 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ELivqPkO; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CB71F3B434A; Fri, 22 Apr 2022 15:23:06 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232394AbiDVWZg (ORCPT + 99 others); Fri, 22 Apr 2022 18:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbiDVWZI (ORCPT ); Fri, 22 Apr 2022 18:25:08 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 021EA2A7429; Fri, 22 Apr 2022 14:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=XSpt1IJ1KFQ65bi+jyiXwQSZangsC0Zf0U2JxFg+R7I=; b=ELivqPkObppEztRJnsptUc9UsI akAJaMckp1HEg+hvy+lMYW1VvCWv6w8Hrj8Loib1tTVEkcEWgzuKU18Top0de6EDDJlXIQIls4rne 6cOONwv2lRxXV3V0PDQ1YY8gESxsggllQvE+ylPsNrqH/vOexLMRLZ3+X2FfSbJ3dj5w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nhzuM-00H2Yn-4L; Fri, 22 Apr 2022 22:29:38 +0200 Date: Fri, 22 Apr 2022 22:29:38 +0200 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next 0/5] net: ipqess: introduce Qualcomm IPQESS driver Message-ID: References: <20220422180305.301882-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422180305.301882-1-maxime.chevallier@bootlin.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2022 at 08:03:00PM +0200, Maxime Chevallier wrote: > Hello everyone, > > This series introduces a new driver, for the Qualcomm IPQESS Ethernet > Controller, found on the IPQ4019. > > The driver itself is pretty straightforward, but has lived out-of-tree > for a while. I've done my best to clean-up some outdated API calls, but > some might remain. > > This controller is somewhat special, since it's part of the IPQ4019 SoC > which also includes an QCA8K switch, and uses the IPQESS controller for > the CPU port. Does it exist in a form where it is not connected to a switch? As Florian has suggested, if we assume frames are always going to/coming from a switch, we can play around with the frame format a little. A dummy tag could be added to the head or tail of the frame, which the MAC driver then uses. That gives us a more normal structure. Andrew