Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp996935pxb; Fri, 22 Apr 2022 16:18:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4S9gLMiaR/cgrfi6xJOSv6RTSu6DfAvTDZJ9FYmKsnamuupXTusZDsqHci6SNho56B/+7 X-Received: by 2002:a17:90b:4ac9:b0:1d2:c13c:7988 with SMTP id mh9-20020a17090b4ac900b001d2c13c7988mr18759224pjb.133.1650669489062; Fri, 22 Apr 2022 16:18:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650669489; cv=none; d=google.com; s=arc-20160816; b=PRx0QJ+4h1Uw+bdOJqlUaQe9f2VzI/oWodgO11IPMlEtyEFKzi5bGqQbVxBl+Xl/82 tXxFyEJDbxf49I1Vf8vVGpHl35CFstnKEqf9fFWQ9vSjCYL7sZZJWQ/vjYDZSrlL1OuL Hcvq6C01n/CmC0xrX4kcPPx6+3p1g5ASmGduCyIpT7iLnSDtQmZ8F7CvSkw2QEO7rjY8 fOEeIw5Ie/oqxmpVW2q9xhzVYG/y3HTEO3t2XF0KnpxZrabG2ate3J1j4Pq36nbLa811 Hf32b7XdjhdweqWTSKxm3Id757tCcyS8f/eqLsth1XZedo30CaaXa2DRq/t7wPko/qw4 /6mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=NNQJP7ntF8soE81iHLRX4D3rG4OVRx16kjDK5B0hv+E=; b=GVwYecDaicjW27F5W0V93zWjQzXf2Sc6SQ5y8Npl9QRDp8FWfiOrA/mAmpP73bhhur 5pfx0qBIBpgk04Q/TppOLjtJDKNvT9M4rnYYjDjqFy8MP4cI0baPfENP6bTJ5i2C4fdH U0OsDv5QzFHGJdl8NGsjy3f5iXCq+wIhL4At4b/8nrtwvzsXoRptBS1LmRVphlJUleu1 F/3JpWT9/H8b4L/MU99daDk+0O4yWl/z8CmB9eKDLTmqDKb1sY73XBU37HyL/BZcDAM9 FCr+x/OoqqdqJXqPSzbeoIqcqMO7wqxPQNvUD5g6CfWbqeSizt6VbzOQbdwH/WQK3NQ6 qKGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pWfQKYNk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e21-20020a17090a4a1500b001c6d5497bb9si11261626pjh.28.2022.04.22.16.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 16:18:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pWfQKYNk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F01F3289153; Fri, 22 Apr 2022 15:26:24 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232603AbiDVW3N (ORCPT + 99 others); Fri, 22 Apr 2022 18:29:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233367AbiDVW1n (ORCPT ); Fri, 22 Apr 2022 18:27:43 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6101343E5F for ; Fri, 22 Apr 2022 14:58:19 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-2ef5380669cso98914787b3.9 for ; Fri, 22 Apr 2022 14:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NNQJP7ntF8soE81iHLRX4D3rG4OVRx16kjDK5B0hv+E=; b=pWfQKYNkMMZJG9PgkJeJ10O0wcxeCiz9fbN53VOitR3Jgn6iD6bHOE0TaZa6BoDjMG /0y4+UcKW3gaHILLuTRNBUEikivRNDHV6EhM+wkH4JsIAcxZpEUeS+jqi4yRhcqbgBGH LJa2Zlj22o8pt1vbAV/M0CA9z3p3+0UwqWaSgfQ6lwaeoiOE2YsAfmYV6oR668MMsCjd WPQwsweyVem8CCU/2FazMcS46azD5MomO3E2Ome+pa2BqkhgiFtRdq49gyKcagra7/T5 tuShQiWL1DnAq7DyRYnVQn89PtwxxHp2DRoMLHDp8QbMp40VTeFoAHWr4lT5zDeyA5Iz PrKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NNQJP7ntF8soE81iHLRX4D3rG4OVRx16kjDK5B0hv+E=; b=hv02jH8LGtdNPTYzQAg8d6a82zN+ElgdnIOAgO4q30M5HZ7pTZJ1AYqXuyybBmPaOS gZQxnWcSvktfeqXuWXgcDvjIL3jfZ7UY+oZOg+U9ZRiX5EW0UPGOXCSxe+dPMcry5MdM u+CANBVLlFnJS0pYyE1QoPx2tdIukEZlFT51LRSZTP7glzQBO0iN8tiT41alrcn+m+6V YZLasyHaV59wJU8b7r+4c2FqNktbNLm1SmDJhTcfLodlzv5SsWk/2ErrLnXFQ7jEMEOF JywdJ5aX7VfHNZ0H/xA40S6y07Np3+OiuEtX9aVxOiWOTX0+hBCwV/OGOW29Zrs8RT/W vdXA== X-Gm-Message-State: AOAM530iHOLZjKRQoxOekHt9h6cZnKWSgM2e7ibDo67Ppsy1UXvONzvs VxT0KOkYxnPxdZfBO2uHtE+STylEnKuhMMrdCD6eJA== X-Received: by 2002:a81:2154:0:b0:2f4:d79e:35dc with SMTP id h81-20020a812154000000b002f4d79e35dcmr7091549ywh.126.1650664699156; Fri, 22 Apr 2022 14:58:19 -0700 (PDT) MIME-Version: 1.0 References: <20220421094228.2141569-1-nobuhiro1.iwamatsu@toshiba.co.jp> In-Reply-To: <20220421094228.2141569-1-nobuhiro1.iwamatsu@toshiba.co.jp> From: Linus Walleij Date: Fri, 22 Apr 2022 23:58:08 +0200 Message-ID: Subject: Re: [PATCH v2] gpio: visconti: Fix fwnode of GPIO IRQ To: Nobuhiro Iwamatsu Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 11:42 AM Nobuhiro Iwamatsu wrote: > The fwnode of GPIO IRQ must be set to its own fwnode, not the fwnode of the > parent IRQ. Therefore, this sets own fwnode instead of the parent IRQ fwnode to > GPIO IRQ's. > > Fixes: 2ad74f40dacc ("gpio: visconti: Add Toshiba Visconti GPIO support") > Signed-off-by: Nobuhiro Iwamatsu Reviewed-by: Linus Walleij Yours, Linus Walleij