Date: Mon, 7 May 2007 19:54:26 -0700
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@osdl.org>,
       Linus Torvalds <torvalds@osdl.org>, Greg KH <gregkh@suse.de>,
       linux-pm@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] Re: [patch] suspend/resume debugging: device filter
Message-ID: <20070508025426.GA28166@kroah.com>
References: <20070125110501.GA25151@elte.hu> <20070126015536.GA14917@suse.de> <20070505092425.GA23125@elte.hu> <20070505100855.GC25704@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070505100855.GC25704@elf.ucw.cz>
User-Agent: Mutt/1.5.15 (2007-04-06)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1360
Lines: 35

On Sat, May 05, 2007 at 12:08:55PM +0200, Pavel Machek wrote:
> Hi!
> 
> > > Here's a (compile tested only) patch that does this on a per-device 
> > > basis, which is smaller, and should work just as well as your patch.
> > > 
> > > It creates a new file in the power/ directory for every device called 
> > > "can_suspend".  Write a '0' to it to prevent that device from being 
> > > suspended.
> > > 
> > > Does this work for you?
> > 
> > yeah, i was able to use this too to debug suspend/resume problems. But 
> > i've added the check to the resume path too - for example sw-suspend 
> > does a resume of devices during its suspend cycle, cutting off much of 
> > the netconsole output.
> > 
> > which makes the can_suspend flag mis-named - perhaps rename it to 
> > exclude_pm ?
> 
> debug_exclude_pm? I do not want people playing with it, then
> complaining that they broke the suspend.

I can make the attribute only show up if CONFIG_DEBUG_DRIVER is enabled.
Would that be better?  We can also write to the syslog when the
attribute is changed that they just might have broken something.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/