Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Jingar, Rajvi" <rajvi.jingar@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     "bhelgaas@google.com" <bhelgaas@google.com>,
        "david.e.box@linux.intel.com" <david.e.box@linux.intel.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        "koba.ko@canonical.com" <koba.ko@canonical.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Russell Currey <ruscur@russell.cc>,
        Oliver O'Halloran <oohall@gmail.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [PATCH v4 2/2] PCI/PM: Fix pci_pm_suspend_noirq() to disable PTM
Thread-Topic: [PATCH v4 2/2] PCI/PM: Fix pci_pm_suspend_noirq() to disable PTM
Thread-Index: AQHYQIGzE0/LKKZHKkmXPRchVsogIazv0DwAgAzeSwCAACSt0A==
Date:   Sat, 23 Apr 2022 00:43:14 +0000
Message-ID: <SJ0PR11MB507047C0109C5163EF20D9AE9EF69@SJ0PR11MB5070.namprd11.prod.outlook.com>
References: <ba571993-90fb-ae67-6617-0b63571298be@intel.com>
 <20220422222446.GA1522716@bhelgaas>
In-Reply-To: <20220422222446.GA1522716@bhelgaas>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NehV+Sw0guYNcdXrgh5iyDs5s7RXURhAlwGAFXChfTtCdoOhu+m6XxJhjAzx?=
 =?us-ascii?Q?I70Nq7cx4vKh+TEqkw08VO5H3/o6U7xJ24K/vGEH5o77aOROv5Uy82ORzn68?=
 =?us-ascii?Q?e8UYD4EFFcdPY4bwA0LBPhNElNg+D1AUsjwQgrqb2aoj4QEMeNtJTob7Un69?=
 =?us-ascii?Q?BSm8wd2uWgcrJOdscqUqsfK04aMzEDVTnaP3rlyUIMnpUQRYqLdspHBMCkHP?=
 =?us-ascii?Q?x+MNENSZGY7hJ5m2BMkmpl1ixyh00GuqZrN7PbkTzF3bsGQAcptJpDfC9MQQ?=
 =?us-ascii?Q?KOteEq0xHrzIl9IPmutXQk1XmRai9sGDfd+NKqVBI+hLw414W6epYaX8hz1C?=
 =?us-ascii?Q?TaPbGzhU0JlV5Z7Fbj5NU1BejOgecux8cYY2yCc5kCW6zjjgPQBRtst/rTFn?=
 =?us-ascii?Q?G+uypTAYechIMZtHrmS8QGyYJkc0+1OmEfh5ocdBa2gGjnigR3C7uSpOeH5c?=
 =?us-ascii?Q?aDmkmG5rFGlYUczkOtIY5CbVUSBkSHKhJLaBfAeVIFcGsBFD7OcuJgsPmz+I?=
 =?us-ascii?Q?oOdW5lqM5i5q+gHmFYcTrw2kBwsCS2RHgmbox/z/cBUegkAGoMX2Clshpovk?=
 =?us-ascii?Q?RIB9THJhcvZN7BGJus8ZNm3oAzaTJzhL5I5gqbUDa4wMwBsbV+/FLNFvDoF+?=
 =?us-ascii?Q?XQSHJQuzbn8N69NUryFvp8cqRlowTbM3QEg2dT2wHw3DRh+Fet3WX9tJm6rN?=
 =?us-ascii?Q?K2s4OO3blIf+l0cR4mVuGNy06NxcQURMD818oYgqs3BgJ8JgebHoZ/6Mpt5q?=
 =?us-ascii?Q?+YdIGEfN3aspu/l/gFeLBSyaIau7KXgqPkZRrBLTw0tPkJnrUZ91OsuUJh7y?=
 =?us-ascii?Q?G1cQGuWripVM1DtsXoReIi6pt3E1k2V7Hrzl9Gakw6oJd5OMmNg9xtSxKbQc?=
 =?us-ascii?Q?qAqAOrSHAese2O4v5qPoeSQMtfZbd7aUYdFAjDlrBGJYINFdHQPjbDeOdfu2?=
 =?us-ascii?Q?rcYkkhXaEK6d5hanfwKTW8QKYo992rLAgqXOiPJhekHaC6KHdsp6coWsDB5c?=
 =?us-ascii?Q?7eTUev+umi6mgPSxims/Z3tKnutr6TQs1gET/U1pUA3HCXE9uoriqoNpaHez?=
 =?us-ascii?Q?W7uhYLRyO2IaV26uTN7yEkbNwi7UqKFypa5M7MiCGreXd8AtRknm2cUzgmnI?=
 =?us-ascii?Q?HfLBf3W3dkdmS1rKviXa+gMktA2B5e2rWFCf874rzLdk4kJzPOmxmuTWDfrA?=
 =?us-ascii?Q?9sQ947h7qZ49r4IQeSRd4HBDx4S/YbSaNqDeZYUpIJtw3oU2mglClgjCISuH?=
 =?us-ascii?Q?o1dwinlNwGSWtmy4KGXgXd9O8arTNBsdt1e5sF6hVfNpI8UIv2ge0GXNnlm9?=
 =?us-ascii?Q?MOegYDs7XZ+W/F2OTh5qPpmyAjJpLV6Yj18YGonB0yzv5XjAzwodP9l30ewY?=
 =?us-ascii?Q?OuLEEdXZdvtW98qqQbpuvkD64aNkKONV/UNM1NbkDv8r+8qCdMgo0uJR+5kE?=
 =?us-ascii?Q?44+kJW2eLHEeGPQZO2lJhkbCfLW0s1a+bQFpIpUGzK5fParkSDsIL20xTTRF?=
 =?us-ascii?Q?wgFfOCHWiKSj6peNZ8mZvNNH9gh/JR6LxyPbq9aotTiCoSNCDLmK3OhirGQz?=
 =?us-ascii?Q?kzIA38LeBFNcZ2eQ1laVtst8u6Q8Htf2byF72hJ50Tp5KGGHy+lKAfkl3EOk?=
 =?us-ascii?Q?/s0dsOzxGkQFloVDmISzh8bX2JNjh8vTYcCRXmcKirkIUvkYEGU0VPgFZKQ2?=
 =?us-ascii?Q?mPLkW9XhpnsXCFaH9trM4M6hNsF5MmkCQLigTXLz6hesfuzMNjGMr5/8lud/?=
 =?us-ascii?Q?hgpfHWsukw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5070.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd349aa4-95d9-4280-3b1a-08da24c2402e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2022 00:43:14.5061
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OSFB/KD4hJVCQooDJ+tYvUkPJoLFE0PL18A+T8v1lvkB154wHH6VuU0ftaragwuydo1pL2QzQ1KZQMI2dkcQfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5812
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Friday, April 22, 2022 3:25 PM
> To: Jingar, Rajvi <rajvi.jingar@intel.com>
> Cc: bhelgaas@google.com; david.e.box@linux.intel.com; linux-
> pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux-pm@vger.kernel.o=
rg;
> Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Kai-Heng Feng
> <kai.heng.feng@canonical.com>; mika.westerberg@linux.intel.com;
> koba.ko@canonical.com; baolu.lu@linux.intel.com;
> sathyanarayanan.kuppuswamy@linux.intel.com; Russell Currey
> <ruscur@russell.cc>; Oliver O'Halloran <oohall@gmail.com>; linuxppc-
> dev@lists.ozlabs.org
> Subject: Re: [PATCH v4 2/2] PCI/PM: Fix pci_pm_suspend_noirq() to disable=
 PTM
>=20
> [+cc other folks interested in PTM from
> https://lore.kernel.org/r/20220408153159.106741-1-
> kai.heng.feng@canonical.com]
>=20
> On Thu, Apr 14, 2022 at 07:54:02PM +0200, Rafael J. Wysocki wrote:
> > On 3/25/2022 8:50 PM, Rajvi Jingar wrote:
> > > For the PCIe devices (like nvme) that do not go into D3 state still n=
eed to
> > > disable PTM on PCIe root ports to allow the port to enter a lower-pow=
er PM
> > > state and the SoC to reach a lower-power idle state as a whole. Move =
the
> > > pci_disable_ptm() out of pci_prepare_to_sleep() as this code path is =
not
> > > followed for devices that do not go into D3. This patch fixes the iss=
ue
> > > seen on Dell XPS 9300 with Ice Lake CPU and Dell Precision 5530 with =
Coffee
> > > Lake CPU platforms to get improved residency in low power idle states=
.
> > >
> > > Fixes: a697f072f5da ("PCI: Disable PTM during suspend to save power")
> > > Signed-off-by: Rajvi Jingar <rajvi.jingar@intel.com>
> > > Suggested-by: David E. Box <david.e.box@linux.intel.com>
>=20
> > > ---
> > >   v1 -> v2: add Fixes tag in commit message
> > >   v2 -> v3: move changelog after "---" marker
> > >   v3 -> v4: add "---" marker after changelog
> > > ---
> > >   drivers/pci/pci-driver.c | 10 ++++++++++
> > >   drivers/pci/pci.c        | 10 ----------
> > >   2 files changed, 10 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> > > index 8b55a90126a2..ab733374a260 100644
> > > --- a/drivers/pci/pci-driver.c
> > > +++ b/drivers/pci/pci-driver.c
> > > @@ -847,6 +847,16 @@ static int pci_pm_suspend_noirq(struct device *d=
ev)
> > >   	if (!pci_dev->state_saved) {
> > >   		pci_save_state(pci_dev);
> > > +		/*
> > > +		 * There are systems (for example, Intel mobile chips since
> Coffee
> > > +		 * Lake) where the power drawn while suspended can be
> significantly
> > > +		 * reduced by disabling PTM on PCIe root ports as this allows the
> > > +		 * port to enter a lower-power PM state and the SoC to reach a
> > > +		 * lower-power idle state as a whole.
> > > +		 */
> > > +		if (pci_pcie_type(pci_dev) =3D=3D PCI_EXP_TYPE_ROOT_PORT)
> > > +			pci_disable_ptm(pci_dev);
>=20
> Why is disabling PTM dependent on pci_dev->state_saved?  The point of
> this is to change the behavior of the device, and it seems like we
> want to do that regardless of whether the driver has used
> pci_save_state().
>=20

Because we use the saved state to restore PTM on the root port.=20
And it's under this condition that the root port state gets saved.

> Bjorn