Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220418110455.2559264-1-chi.minghao@zte.com.cn>
References: <20220418110455.2559264-1-chi.minghao@zte.com.cn>
Subject: Re: [PATCH] clk: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
To:     cgel.zte@gmail.com, mturquette@baylibre.com
Date:   Fri, 22 Apr 2022 19:02:16 -0700
User-Agent: alot/0.10
Message-Id: <20220423020218.8DCE5C385A0@smtp.kernel.org>
Precedence: bulk

Quoting cgel.zte@gmail.com (2022-04-18 04:04:55)
> From: Minghao Chi <chi.minghao@zte.com.cn>
>=20
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
>=20
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/clk/clk.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index ed119182aa1b..544e940bf40b 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -113,12 +113,8 @@ static int clk_pm_runtime_get(struct clk_core *core)
>         if (!core->rpm_enabled)
>                 return 0;
> =20
> -       ret =3D pm_runtime_get_sync(core->dev);
> -       if (ret < 0) {
> -               pm_runtime_put_noidle(core->dev);
> -               return ret;
> -       }
> -       return 0;
> +       ret =3D pm_runtime_resume_and_get(core->dev);
> +       return ret;

	return pm_runtime_resume_and_get()

? I got it.