Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220422230013.1332993-2-bjorn.andersson@linaro.org>
References: <20220422230013.1332993-1-bjorn.andersson@linaro.org> <20220422230013.1332993-2-bjorn.andersson@linaro.org>
Subject: Re: [PATCH v2 2/2] clk: qcom: add sc8280xp GCC driver
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>
Date:   Fri, 22 Apr 2022 18:53:52 -0700
User-Agent: alot/0.10
Message-Id: <20220423015354.6558BC385A0@smtp.kernel.org>
Precedence: bulk

Quoting Bjorn Andersson (2022-04-22 16:00:13)
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc828=
0xp.c
> new file mode 100644
> index 000000000000..16bfe62efca2
> --- /dev/null
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -0,0 +1,7451 @@
[...]
> +static struct clk_branch gcc_video_vcodec_throttle_clk =3D {
> +       .halt_reg =3D 0x28020,
> +       .halt_check =3D BRANCH_HALT_SKIP,
> +       .hwcg_reg =3D 0x28020,
> +       .hwcg_bit =3D 1,
> +       .clkr =3D {
> +               .enable_reg =3D 0x28020,
> +               .enable_mask =3D BIT(0),
> +               .hw.init =3D &(struct clk_init_data){

The clk_init_data can be const too, right?

> +                       .name =3D "gcc_video_vcodec_throttle_clk",
> +                       .ops =3D &clk_branch2_ops,
> +               },
> +       },
> +};