Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9525d336040d2fc89005d2923f0d8ee98597ac86.camel@aosc.io>
Subject: Re: [PATCH 1/2] dt-bindings: thermal: sun8i-thermal: add binding
 for R329 THS
From:   Icenowy Zheng <icenowy@aosc.io>
To:     Vasily Khoruzhick <anarsoul@gmail.com>
Cc:     Yangtao Li <tiny.windzz@gmail.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        arm-linux <linux-arm-kernel@lists.infradead.org>,
        linux-sunxi@lists.linux.dev,
        linux-kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <CA+E=qVfMm=8aQOM_HW_3EeqqLi-Fgn1Ex3h6kor89FQ0KfTvRw@mail.gmail.com>
References: <BYAPR20MB24721F9954252BECBEF486ACBCF79@BYAPR20MB2472.namprd20.prod.outlook.com>
         <CA+E=qVfMm=8aQOM_HW_3EeqqLi-Fgn1Ex3h6kor89FQ0KfTvRw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date:   Sat, 23 Apr 2022 07:51:54 +0800
User-Agent: Evolution 3.40.4 
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2022-04-22星期五的 11:44 -0700，Vasily Khoruzhick写道：
> On Fri, Apr 22, 2022 at 9:12 AM <icenowy@outlook.com> wrote:
> > 
> > From: Icenowy Zheng <icenowy@aosc.io>
> > 
> > R329 has a thermal sensor controller that has only one sensor, and
> > the
> > structure of it is like the H6 one.
> > 
> > Add device tree binding for it.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> >  .../devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml  | 3
> > +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-
> > ths.yaml
> > b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-
> > ths.yaml
> > index 6e0b110153b0..87b4103e0a5f 100644
> > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-
> > a83t-ths.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-
> > a83t-ths.yaml
> > @@ -20,6 +20,7 @@ properties:
> >        - allwinner,sun50i-a100-ths
> >        - allwinner,sun50i-h5-ths
> >        - allwinner,sun50i-h6-ths
> > +      - allwinner,sun50i-r329-ths
> > 
> >    clocks:
> >      minItems: 1
> > @@ -63,6 +64,7 @@ allOf:
> >              enum:
> >                - allwinner,sun50i-a100-ths
> >                - allwinner,sun50i-h6-ths
> > +              - allwinner,sun50i-r329-ths
> > 
> >      then:
> >        properties:
> > @@ -85,6 +87,7 @@ allOf:
> >          compatible:
> >            contains:
> >              const: allwinner,sun8i-h3-ths
> > +            const: allwinner,sun8i-r329-ths
> > 
> >      then:
> >        properties:
> 
> There's also a check at line #99 that requires clock, clock-names and
> resets properties for thermal sensors in other Allwinner SoCs. Are
> these not required for r329?

Thanks for this tip, I will add R329 to this check in the next
revision.

> 
> Also are you planning to add a node for thermal sensor to r329 dtsi?
> 
> 
> > --
> > 2.35.1
> >