Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f2ca9d19-023f-76d9-5c76-6f08ccfbe348@oracle.com>
Date:   Sat, 23 Apr 2022 18:49:49 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v8 00/10] kernfs: Remove reference counting for
 kernfs_open_node.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org
References: <20220410023719.1752460-1-imran.f.khan@oracle.com>
 <YmLfxHcekrr89IFl@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <YmLfxHcekrr89IFl@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmpQMGJFeHVtN1ZqL3JFQTRXRTBvRDBYU0dQSGRDcXdWbGxjdEp2dkJwSkZ2?=
 =?utf-8?B?SFFKbmRtVW5LaGQ1RjM0Q0JqOER1L2czRktuUzZjTzVRcWdPNktzdFgwMVp4?=
 =?utf-8?B?MFhudVBqMy9JR0pWWVFqL3dwY21WZXRDakRwNjBFQXFNeDE4NmV0Y2ZURm9q?=
 =?utf-8?B?cXZaQ1ZjY2pIcXBveFQyM2lLY2haajJkNStJaGVHSmV6b0Y0M0xNdTIzV05y?=
 =?utf-8?B?aElhTEpEOVNQaUFpNHV1ek8xY3hQeHcrRGFDWU45Wm1kc0VPbjdiODNPdVBm?=
 =?utf-8?B?QXBjdWx6U3RnUmlQYWFycjVHaFdWRjdHS0oxa2lBenpaWUNNN2N4M0ZuRXQ3?=
 =?utf-8?B?NFdkZ1dVMWNMaXoxNlAvY2drZzNqbDg1M1A5Uis1cFNKMmlHcS91cDdMc1VR?=
 =?utf-8?B?Rm1xcktPWDd0NzQzRkd2NkNOTTVvb1puWUtGaDdMM3FTLzBFVVF0bVJ4cGp3?=
 =?utf-8?B?c2V5eW5Nc2FlSjI5VzlKMjhBbGZCMzhQR0UxWHZUbjRwUXdveVpvOFA2TDZR?=
 =?utf-8?B?SWJFeG12OWFwYXFqV1ErY29oWlVYZHhoVXY5QkdMZGlqOFZCRFJnVXhQcVVS?=
 =?utf-8?B?THA5K0lxZ0FmVk5IeVhDbGo5K1BCTzNUU1E3akYvR2tJVGg3UzJzL2M0czZC?=
 =?utf-8?B?M0JZMkkyYnp2Y3VaOVpCNFJiRFBwelNDUHR1L1UyTGpocW0rZ0xHUUlpa1Ns?=
 =?utf-8?B?M3FDTW56amd1dkYxMFJDalNEOU9xMWx6cVhqVmh0WWZYVWhFbWJobzdZR1VD?=
 =?utf-8?B?b3Y5UU5aT1M4REwwRFdSL1dvTUhHbXBBN3UxTWtFSlBFbE56MlM4aWhTd3pZ?=
 =?utf-8?B?d0ZMaEkvMW90K2pSUlhraFU2eEZmczB0UjhqemMwdW14VTFUUFgycExOdWZ3?=
 =?utf-8?B?ZVZzWElHRi90Q2dWZEFHK3J0Z1g5dlRyNEpsRmMwVXhMSFVZdm5CclNQeFZz?=
 =?utf-8?B?QXpYbURZMVVyMFJOYlA0VGIvb1p3a1AxTG5HWTdpalozM0ZmVGk0Y1Rkclg5?=
 =?utf-8?B?RXVNU0Y5cFZmR21BeTRZM1lmendSWDNZWnJiZHIxWXlZd25vbEpNVVVEQ25z?=
 =?utf-8?B?dXlXaGN2OHJkMlpsdndJT21kVER5QThXWHJXMGIyMTJzMFI1eFgzdEJJbDN2?=
 =?utf-8?B?UStOMjhOMHhtUk9qRlBzYWNIT1Q3MmtiM1ZXQWFHOExocklQcU05amRqTGc4?=
 =?utf-8?B?VnNKMEdtZmIraWZjUGpEM3NtUDIyaUJUMklkc0FnNFZoNGFISXU4RmZ0Mmkz?=
 =?utf-8?B?M28rdGtJejhFT0Erd0NGUy9RcmQ2ZkJmVEJMZWE5a0dvSXplVitMQm1hRDVp?=
 =?utf-8?B?L25wcXpseDVjU2Z0ZXhjL09IUkE3cjhnZE5lWktwTjJXRTJvVU0zcEwzSjF2?=
 =?utf-8?B?UHhDZkh4ZS9WRzhvd2dDMVg2eUlBZjFQY0l0T0xEbjFHRForWmtrOVB2NEVU?=
 =?utf-8?B?a3Y2L0VZeFZpUStoelFSVG1HNzB3dEFnbjI2TlpEMTl2ZThKanJaSlZjQm9C?=
 =?utf-8?B?YkIzRU8rMkN6T1YvSFdUVkp4RTI3dW4vRmFESEF1ODFUbXIzWGp4Y0VseHd2?=
 =?utf-8?B?dGxQb0E1RllYajBEODdyVTQyR3hBM2ZTOS9BS1I4RjEwYldvVzlNR2YzME9Z?=
 =?utf-8?B?a3FZZUxpRk1NNndOcHJkNFBpU2ZUMEkyeTdwZmw5OGZ1a2ZnNTRuS2tyR0ZJ?=
 =?utf-8?B?bUR0TnRVWlFSeUtQb0Urd0Y1aWl1dGw0TVRQR3VBanZIOG5mM0YrdnBIVERS?=
 =?utf-8?B?ZlZNVC9UUDJIUkdkRi9MUVY0ZitZYkpHem8yWSt4L3hDYnFFWTBETURXYXE2?=
 =?utf-8?B?Z3U2WEdNRjlTc0ZQVU5QSENqRnNNRWc0UzVpOHAxdCtUTjdHOEV4ZjRRT1hw?=
 =?utf-8?B?bVZwTHQvREIvWG9vdFB2b0E1REZ0em5Qb3pLK2xpWThsL0JSejhTd1pUK3VC?=
 =?utf-8?B?NU1lemRUWFpSSXowYXZNOS9odm1waUU3R3BRSnZYeHBYb3BNRVFHbkw4SUpJ?=
 =?utf-8?B?dDRVb1RxOGJCTmRIbzRuWjBoR1hLcnJoczVyMEdTMllXSE4xV0g1bWU2Tmtq?=
 =?utf-8?B?YWE5U2V5RWNpL1N5dDFwOUlQT1h3RnJ1TjlmeU4rR1l0VzJIb0FMQXBaOFFO?=
 =?utf-8?B?dFA2NU1jSUFzMEN5OThNRjNDdXp4dmpaQXEwWTVsRjlnSGMvd2J6d1ZuU1Uw?=
 =?utf-8?B?YVQ2OUk0VG8zaTdIVTNXZ0VkT1dqMCtHVU1lbWhnRzFVL0xYOGhoM2VYUjlG?=
 =?utf-8?B?MlZteWZaUGdYNURxOEFoaHl5bjFna2ZnVUdPeDlzT2ZtM3JibURKQ1E5RmRR?=
 =?utf-8?B?dVp1VlJJQWpMOS8rM1FJaURkM25jRWV2bFhReXR1UUlqbklNUFNLOXNtaVN1?=
 =?utf-8?Q?X95j0zWLgt97GU+c=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94dc3e6f-bd41-44b5-7bf5-08da25063de3
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2022 08:49:56.7989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xwTNUkmde86fDXVPzPnBclPOKkxin8yAXs32vEUlCq93rU7LXwfhRTSWC+KBKNNmRMvMy/Wiwh1osCTrX1r68A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2507
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-23_01:2022-04-22,2022-04-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204230039
X-Proofpoint-ORIG-GUID: DnIMDR42qYL_gXl0yt2pHxhpDL9aPZeN
X-Proofpoint-GUID: DnIMDR42qYL_gXl0yt2pHxhpDL9aPZeN
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,


On 23/4/22 3:03 am, Tejun Heo wrote:
> Hello, Imran.
> 
> I took a look to patch 5 and it looks like there's still some work left to
> do. Maybe it'd be easier to concentrate on the first two parts - the notify
> list conversion and open_file_mutex conversion first and then get to the
> rest later?
> 

Thanks again for reviewing this and I agree with your suggestion. So far
most of the concerns have been around usage of kernfs_rwsem and those
can be addressed independent of first 5 (even first 7 )changes here.
Just one question in this regard, should I send the new patch set
(addressing open_file_mutex and list conversion) as a separate patch set
or should I sent it as v9 of ongoing change set. I guess first option is
better but thought of confirming once before proceeding.

Thanks
-- Imran
> Thanks.
>