Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Sat, 23 Apr 2022 09:34:22 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Aleksa Savic <savicaleksa83@gmail.com>
Cc:     linux-hwmon@vger.kernel.org, Jack Doan <me@jackdoan.com>,
        Jean Delvare <jdelvare@suse.com>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Add support for
 Aquacomputer Farbwerk
Message-ID: <20220423163422.GA3964519@roeck-us.net>
References: <20220421072743.5058-1-savicaleksa83@gmail.com>
 <20220422183144.GA2637654@roeck-us.net>
 <YmQoEoU1UJ+KPhQ9@fedora>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmQoEoU1UJ+KPhQ9@fedora>
Precedence: bulk

On Sat, Apr 23, 2022 at 06:23:46PM +0200, Aleksa Savic wrote:
[ ... ]
> > > +	case USB_PRODUCT_ID_FARBWERK:
> > > +		priv->kind = farbwerk;
> > > +
> > 
> > 
> > Any special reason for this empty line ? It seems kind of random.
> > 
> > Guenter
> > 
> 
> That's how code in other cases of that switch is formatted (not visible
> from this patch directly), setting priv->kind and then the appropriate
> labels.
> 
Ah, ok. Looks odd here, but makes sense.

Thanks,
Guenter