Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <26c0caf1-4cfc-9c7d-ac51-180ba4501bf5@nvidia.com>
Date:   Sat, 23 Apr 2022 20:41:39 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V2 2/8] dt-bindings: PCI: tegra: Add device tree support
 for Tegra234
Content-Language: en-US
To:     Raul Tambre <raul@tambre.ee>, bhelgaas@google.com,
        lorenzo.pieralisi@arm.com, robh+dt@kernel.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com
Cc:     kishon@ti.com, vkoul@kernel.org, kw@linux.com, krzk@kernel.org,
        p.zabel@pengutronix.de, mperttunen@nvidia.com,
        linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-phy@lists.infradead.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20220423124858.25946-1-vidyas@nvidia.com>
 <20220423124858.25946-3-vidyas@nvidia.com>
 <50b80804-e95c-2137-5d74-2451e5bb826f@tambre.ee>
From:   Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <50b80804-e95c-2137-5d74-2451e5bb826f@tambre.ee>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVkvRjFjQWRVV0NNdjVPZm9ReXBNVGtaNFBPQk42R0Y0WnVzTG4vLzhDWWEy?=
 =?utf-8?B?MUNFaEtvL0x2cEtIellRdE9zc1VON1E1MVRJUHhxcWpOUmhzbWpWdlZEaXBn?=
 =?utf-8?B?MUh0VGUwSlFhOEhoSmZuejR6Q2ZQa1MzK2xwL092Y0tMemU5bk11Y3U3K0E4?=
 =?utf-8?B?TmhHT3F0UitLcVoyS1MzNVJJTzZsUlg0Q01QSWIzeWw5bDFWWTQ0UDI2OUJq?=
 =?utf-8?B?K1BYbFVESXVqL0V5dkY5aTNacGxsb1hlNE43NWdiRGVUYzd3b0Y4WUhlYzBZ?=
 =?utf-8?B?OTdnblczZTlWakR3SXVmWHZhM21qMjFjL2ZIeHpKWmtmSi9POENNU3BKR0VD?=
 =?utf-8?B?OFR3WkdIVnArTlM4dkx5TWN6aHdrSEk4bExWTHo2cU1rMHNjbGVwQWljNTg1?=
 =?utf-8?B?dlhjY3BhQklyTmpQRjJRUFRuV2pReTdDUTRDODhCOTZyUlhQKy9rblZGcnVR?=
 =?utf-8?B?MnY1R0ZYOElRcWhqamY2elduOVg0emZDVlVPS3MvRjh6Znd1SUpxRjVGRENK?=
 =?utf-8?B?d0QrK1lLbjdIY0RKYTUyTDRmRVlnR0RGQU5PZGQrbmI3MGp0YlZETmxuU0h4?=
 =?utf-8?B?UE1oUmdVeC9UM1ZaT0JWZkdjRkRMaFdTb2c2eFJzbGowQ2JhZytSZGUzMW1j?=
 =?utf-8?B?RnBuMWF3YnVlUGdWdk1XOWtOMlp4Z1VQTFpkUzZ5OUhmc0R0NnJDTFVoZGZU?=
 =?utf-8?B?Q2tVYzlROUxnQktZSW50OUNRWHJCTlUwYUNoanlEeEM5VGR0SWFraTNncFZQ?=
 =?utf-8?B?VmFtMVNRUHhObklkanlXNUx5WmZJc3BWL3h1Vk40RTlsS0l5aVVzNXNtU21N?=
 =?utf-8?B?di84Ui9iWmVKeDdDK005VEZXV21rcTBRNmwvNnVqcUVRYytxYytuSStlcWJy?=
 =?utf-8?B?L2VGZUZja1pteUhwTXNjajZYYUxJa09aSjNlWU1VV2pnTUVnamNJaFk2VWsw?=
 =?utf-8?B?R3hEODJ6MWxzakhXS2sybzNaTDdGR3F6QTNLUXBpVDdqZzR3M3ZEeDE1dlk1?=
 =?utf-8?B?Qkh1bTlnb3hNOW1mYlZBSTl1WkhuckpGRExNbFdsRjI2eURMUERpc293THR5?=
 =?utf-8?B?emRHRkRUOGF5aUVKY1VGU1ZqYkpWd000dzhtQ0NJbjczVlFWcEJuZTlmYWxq?=
 =?utf-8?B?cUhrNGlZK09ZaXJXQnlrK0NnZ1lnajgrbU5jYTEyVUdzbHEzTzJmWWdEUEJn?=
 =?utf-8?B?dEZnM3d4Zk9GRHh4ZmN0TWduNy94OVpmN2o2UWs3T3FYT01ZM1hneHpqMHY3?=
 =?utf-8?B?T3ZEdUYvL29kZU50aFltT0VnWURCT0p5LzJqRjVJcTBkSE5JTnl6ZmdUL09F?=
 =?utf-8?B?YTg2YjNPOEdjMW5FaEFpcEVUMEZ0bFVSMkM5VXgyVHM5NDNpSkpRN2Ntdkp1?=
 =?utf-8?B?UlQyZzdFUlRpSDQ1cXVnK2d4TWJkalpKSHRTcWcwMjBwQXlGaytoTlBwdVJI?=
 =?utf-8?B?Z1V0RDloOTNBMFcvZGFDSjRKN0hmeXI1NjRHb3ltd25lNmVhRENDYVpRNmUz?=
 =?utf-8?B?VlhaOHdseVFzT2lWZUphZVgxcUtFQTJqd3VlVDRGOXE1QWg5aENRWWowRHZj?=
 =?utf-8?B?V2s5ZUFvamNsckJ6YkVkMldXbGN5ZE81SGRvNE0va3lDeUhYNTdaNmxOS0xE?=
 =?utf-8?B?MExjd3Rnc3NvSmlHQ2JoVXhYcHkySC9yTUdrZmFSWmh6R1AwdjBxcGsyZEN1?=
 =?utf-8?B?TytSK0YxbHZXRW4yTEhQMldHb1ZNS2hBbkE5THpra3BYSmxWZmhTK2NHdkN0?=
 =?utf-8?B?bVR1eWxOUmRnWjBjUENZckhHZFVzMCtuYVNMKzVkV2VsdFc0eGdQd3IxZjh1?=
 =?utf-8?B?bUVzNzFQeHNQTkoyTi95YXo4bGZDdXU2ejBBY3hQVWh5OGVDUnB2MHdqN0kz?=
 =?utf-8?B?Y3pTb3h0RGVObVVoWWJpM1kwbGFDa2VSdlVjYTlHOSsvWWFFMElJQkkvVjBm?=
 =?utf-8?B?ZmgxUFEwdSs3S3Bvak5VZFlkOGM3Tkhqdkt1SDdlL2NYamJKTVhwUS9GNkpC?=
 =?utf-8?B?d21nUXBESzZacCt1OHRSeFRxaUVGVzJQOW03UEZ4eHdVdUtTQi8valUrWm1w?=
 =?utf-8?B?SmVWUHZpMGkvVmFIeStNZGxueWVyZUs4ZUp3TGk4MGx5cXFNeU5OMXkrUytP?=
 =?utf-8?B?OWVxa3Y1Z0FNR0toWVJ5bklHTERnWkd3bnZmQlZ5Y2lQQzVhVGphM1FuMjN3?=
 =?utf-8?B?ckg4SjREUU00R0hkTjFPRENHQXBqV3NuNk9RYUxkeE5MNVF5alNPRDZoNTY4?=
 =?utf-8?B?TjFGRTZnd0FRN3BmSkZvNDJNb2k0T2xUUGdzNk1nZEtkQmducTc3Wmp0Vm5U?=
 =?utf-8?B?SGR0VVZMSEx1MXhvS0NOdUZmWmlPRzd2ckVPN002WmZhS2IzazFmZz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b04b1e0b-906d-449f-1bb2-08da253b9b30
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2900.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2022 15:11:56.7328
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ZI3ZloztobfNGPyvxG4y3k886hYfNB7hULIyjlG3Zmefw13JBrpcpK+SfP8Fgsd6YhqdTRxBsc5zvZHVE0lpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5305
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/23/2022 7:57 PM, Raul Tambre wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 2022-04-23 15:48, Vidya Sagar wrote:
>> @@ -47,16 +64,33 @@ Required properties:
>>     "p2u-N": where N ranges from 0 to one less than the total number 
>> of lanes
>>   - nvidia,bpmp: Must contain a pair of phandle to BPMP controller 
>> node followed
>>     by controller-id. Following are the controller ids for each 
>> controller.
>> +  Tegra194:
>> +  ---------
>>       0: C0
>>       1: C1
>>       2: C2
>>       3: C3
>>       4: C4
>>       5: C5
>> +  Tegra194:
> 
> Should this be Tegra234?

Yes.
Oops... How did I miss this? My bad.

> 
>> +  ---------
>> +    0 : C0
>> +    1 : C1
>> +    2 : C2
>> +    3 : C3
>> +    4 : C4
>> +    5 : C5
>> +    6 : C6
>> +    7 : C7
>> +    8 : C8
>> +    9 : C9
>> +    10: C10
>