Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3ce4feb9-5477-e7fb-e98c-3d6342ddc7b5@gmail.com>
Date:   Sun, 24 Apr 2022 12:38:10 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
To:     baihaowen@meizu.com
Cc:     alexs@kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, seakeel@gmail.com,
        siyanteng01@gmail.com, siyanteng@loongson.cn
References: <1650424016-7225-3-git-send-email-baihaowen@meizu.com>
Subject: Re: [PATCH 2/2] doc/vm/page_owner.rst: Fix table display confusion
Content-Language: en-US
From:   Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <1650424016-7225-3-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Wed, 20 Apr 2022 11:06:56 +0800,
baihaowen wrote:
> After make htmldocs, the table which is made of tab will
> display all by one line. so we make a standard table for STANDARD
> FORMAT SPECIFIERS description.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  Documentation/vm/page_owner.rst | 34 ++++++++++++++++++++--------------
>  1 file changed, 20 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 422d5fa99e84..a8505e3a3044 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -174,22 +174,28 @@ STANDARD FORMAT SPECIFIERS
>  
>  For --sort option:
>  
> -	KEY		LONG		DESCRIPTION
> -	p		pid		process ID
> -	tg		tgid		thread group ID
> -	n		name		task command name
> -	st		stacktrace	stack trace of the page allocation
> -	T		txt		full text of block
> -	ft		free_ts		timestamp of the page when it was released
> -	at		alloc_ts	timestamp of the page when it was allocated
> +        ====            ==========      ============================================
> +        KEY             LONG            DESCRIPTION
> +        ====            ==========      ============================================
> +        p               pid             process ID
> +        tg              tgid            thread group ID
> +        n               name            task command name
> +        st              stacktrace      stack trace of the page allocation
> +        T               txt             full text of block
> +        ft              free_ts         timestamp of the page when it was released
> +        at              alloc_ts        timestamp of the page when it was allocated
>          ator            allocator       memory allocator for pages
> +        ====            ==========      ============================================
>  
>  For --curl option:
>  
> -	KEY		LONG		DESCRIPTION
> -	p		pid		process ID
> -	tg		tgid		thread group ID
> -	n		name		task command name
> -	f		free		whether the page has been released or not
> -	st		stacktrace	stack trace of the page allocation
> +        ====            ===========     ============================================
> +        KEY             LONG            DESCRIPTION
> +        ====            ===========     ============================================
> +        p               pid             process ID
> +        tg              tgid            thread group ID
> +        n               name            task command name
> +        f               free            whether the page has been released or not
> +        st              stacktrace      stack trace of the page allocation
>          ator            allocator       memory allocator for pages
> +        ====            ===========     ============================================

This patch looks like against akpm's tree (or linux-next).
So it is not applicable to docs-next of Jonathan's tree at the
moment.

You need to wait until docs-next catches up akpm's tree.

Patch 1/2 should wait until the English doc is updated,
I suppose.

By the way, I don't think the list of options need tables.
Literal blocks should suffice.

I mean, How about the simpler changes:

>  For --sort option:
   For --sort option::

>  For --curl option:
   For --curl option::

Thoughts?

       Thanks, Akira

> -- 
> 2.7.4